Displaying 2 results from an estimated 2 matches for "matchrotate".
2013 Oct 03
2
[LLVMdev] Question about DAGCombiner::MatchRotate function
Hi all,
While I test
"clang-tests/gcc-4_2-testsuite/src/gcc.c-torture/execute/20020226-1.c",
I faced something wrong with "DAGCombiner::MatchRotate" function.
This function tries to consume some patterns and generate "ROTL" or
"ROTR" dag node as following comments:
"DAGCombier::MatchRotate" function in DAGCombiner.cpp
Pattern1
// fold (or (shl (*ext x), (*ext y)),
// (srl (*ext x), (*ext (sub 32,...
2013 Oct 03
0
[LLVMdev] Question about DAGCombiner::MatchRotate function
Hi JinGu,
It's normally best to send patches to the llvm-commits list. That's
where most of the reviews happen.
> The problem is that code does not check this with new specific type "LArgVT"
> and "RArgVT" while processing above patterns. How do you think about this? I
> think checking code is needed.
I agree.
> I have attached simple patch to fix it.