search for: matchernam

...k or not. In the case that came up in review for me, the code I submitted is template <typename BaseT, typename DerivedT> void registerIfNodeMatcher(...) { auto NodeKind = ASTNodeKind::getFromNodeKind<DerivedT>(); if (!NodeKind.isNone()) NodeCtors[NodeKind] = std::make_pair(MatcherName, Descriptor); } but it was rejected as unreadable and I was given a link to the coding guidelines. 'NodeKind' appears three times in one line in that code and the requirement is to add it again. ASTNodeKind is a very commonly used class in that part of Clang, so it should be familiar...

...the code I submitted is > > > > template <typename BaseT, typename DerivedT> > > void registerIfNodeMatcher(...) { > > auto NodeKind = ASTNodeKind::getFromNodeKind<DerivedT>(); > > if (!NodeKind.isNone()) > > NodeCtors[NodeKind] = std::make_pair(MatcherName, Descriptor); > > } > > > > but it was rejected as unreadable and I was given a link to the coding > guidelines. > > I agree, this seems overly strict. > I mean maybe. But looking at the example, I don't have a clue what type `NodeKind` is. I think this is border...

On Dec 16, 2018, at 11:44 AM, Stephen Kelly via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > On 25/11/2018 14:43, Stephen Kelly via llvm-dev wrote: >> However this is a proposal for more modern thinking regarding the permissiveness of auto in LLVM codebases. >> Currently the rule on the use of auto is here: > > Hi, > > Thanks for the input on this topic,