search for: matchelements

I haven''t been able to find any discussion about this. It looks as if Selector.matchElements is broken (which means that Selector.findElement, Element.down(elt, cssselector) dont work properly. What I''m seeing is that (line 3310) the Selector.findElements is not called with the root node of the node you are wishing to find elements under (its not called with a parameter at all) -...

...do this) is messing up in the unmark() function on line 2295 (v.1.5.1.1) by setting the _counted property on the IMG and A elements to the string "undefined", as opposed to nothing. I assume that unmark() was called by _rows[0].down() in the addLineItem() function. So the line (#2595) in matchElements has "if (element._counted)", which returns true when it shouldn''t. Changing line 2595 to be explicitly: if (element._counted==true) caused an error "addEventListener is null or not an object" in IE6. I have no idea why. But changing line 2295 to: _counted = "&quot...

...'-' + (v || "").toUpperCase() + '-'); } + }, + + split: function(expression) { + var expressions = []; + expression.scan(/(([\w#:.~>+()\s-]+|\*|\[.*?\])+)\s*(,|$)/, function(m) { + expressions.push(m[1].strip()); + }); + return expressions; }, matchElements: function(elements, expression) { - var matches = new Selector(expression).findElements(), h = Selector.handlers; + var matches = $$(expression), h = Selector.handlers; h.mark(matches); for (var i = 0, results = [], element; element = elements[i]; i++) - if (element._counted) r...

Note that one of the 8 patches (#6) will be sent separately in reply to this email, as some of the replaced lines are too long, so git won't let me send the email. However, there is nothing wrong with that patch, and it should be applied in the sequence listed below. Note also that I assume this will be tested on a clean f11 install, rather than an upgrade of an existing ovirt server