search for: match_sub

...s file implements a POSIX regular expression matcher. > +// > +//===----------------------------------------------------------------------===// > +#include "llvm/Support/DataTypes.h" > +#include "llvm/Support/regex.h" I would like to get rid of this include. What if match_sub just took a SmallVector<std::pair<size_t, size_t>> to use for the matchs (or some equivalent). I think that the regex n_subs field has the number of matches, so match_sub can do the right thing. > +namespace llvm { > + class Regex { > + public: > + enum { > + /...

...ssion matcher. >> +// >> +//===----------------------------------------------------------------------===// >> +#include "llvm/Support/DataTypes.h" >> +#include "llvm/Support/regex.h" >> > > I would like to get rid of this include. What if match_sub just took a > SmallVector<std::pair<size_t, size_t>> to use for the matchs (or some > equivalent). I think that the regex n_subs field has the number of matches, so > match_sub can do the right thing. > Ok. > >> +namespace llvm { >> + class Regex { &g...

On 2009-08-24 20:14, Chris Lattner wrote: > On Aug 23, 2009, at 11:59 PM, Török Edwin wrote: >> If LLVM is going to have an integrated regex library I suggest using it >> regardless if the platform has one. >> The LLVM integrated regex library will provide consistent behaviour and >> execution time, the system one will not. > > Hi Edwin, > > Can you propose

On Aug 23, 2009, at 11:59 PM, Török Edwin wrote: > If LLVM is going to have an integrated regex library I suggest using > it > regardless if the platform has one. > The LLVM integrated regex library will provide consistent behaviour > and > execution time, the system one will not. Hi Edwin, Can you propose the openbsd implementation as a patch to lib/support? -Chris

...with NEWLINE flag. >>> +    // noteol:  The match-end-of-line operator always fails to match. >>> +    //    unless regex was compiled with NEWLINE flag. >>> + >>> +    bool matches(const char *string, bool notbol=false, bool noteol=false); >>> +    bool match_sub(const char *string, llvm_regmatch_t pmatch[], >>> +                   unsigned nmatch, bool notbol=false, bool noteol=false); >>> >> >> These should be doxymented, and I don't understand the flags. Does this mean >> that if I *don't* compile with NEWLINE,...

...gt;>>> + // noteol: The match-end-of-line operator always fails to match. >>>> + // unless regex was compiled with NEWLINE flag. >>>> + >>>> + bool matches(const char *string, bool notbol=false, bool noteol=false); >>>> + bool match_sub(const char *string, llvm_regmatch_t pmatch[], >>>> + unsigned nmatch, bool notbol=false, bool noteol=false); >>>> >>>> >>> These should be doxymented, and I don't understand the flags. Does this mean >>> that if I...

...+    // noteol:  The match-end-of-line operator always fails to match. >>>>> +    //    unless regex was compiled with NEWLINE flag. >>>>> + >>>>> +    bool matches(const char *string, bool notbol=false, bool noteol=false); >>>>> +    bool match_sub(const char *string, llvm_regmatch_t pmatch[], >>>>> +                   unsigned nmatch, bool notbol=false, bool noteol=false); >>>>> >>>>> >>>> These should be doxymented, and I don't understand the flags. Does this mean >>>>...