search for: master_lock

...urnal_commit_transaction 16218 D ls iterate_dir 16533 D mkdir dlm_wait_for_lock_mastery 31195 D+ ls iterate_dir So the code reviewed, and I found the order of the lock may wrong. In the function dlm_master_request_handler, the resource lock is held and so after the lock of &dlm->master_lock is locked. But in the function dlm_get_lock_resource, the &dlm->master_lock is locked first and so resource lock. They are different order in different function. If there are two task, one holds the res->lock waiting for the dlm->master_lock, with the function dlm_master_request_handle...

...urnal_commit_transaction 16218 D ls iterate_dir 16533 D mkdir dlm_wait_for_lock_mastery 31195 D+ ls iterate_dir So the code reviewed, and I found the order of the lock may wrong. In the function dlm_master_request_handler, the resource lock is held and so after the lock of &dlm->master_lock is locked. But in the function dlm_get_lock_resource, the &dlm->master_lock is locked first and so resource lock. They are different order in different function. If there are two task, one holds the res->lock waiting for the dlm->master_lock, with the function dlm_master_request_handle...

Hi, I've found some possible deadlock in fs/ocfs2/dlm/dlmmaster.c - version 2.6.28 (probably this code is in newer versions too). Could someone confirm this? Thank you. fs/ocfs2/dlm/dlmmaster.c ================== function dlm_master_request_handler: (res->spinlock <- dlm->master_lock) ----------------------------------- spin_lock(&res->spinlock); at line 1427 spin_lock(&dlm->master_lock); at line 1475 function dlm_migrate_request_handler: (dlm->master_lock <- res->spinlock) ------------------------------------------------------- spin_lock(&dlm->ma...

These patches convert the mle list to a hash. The same patches apply on ocfs2 1.4 too. Currently, we use the same number of hash pages for mles and lockres'. This will be addressed in a future patch that will make both of them configurable. Sunil

The changes from the last drop are: 1. Patch 11 removes struct dlm_lock_name. 2. Patch 12 is an unrelated bugfix. Actually is related to a bugfix that we are retracting in mainline currently. The patch may need more testing. While I did hit the condition in my testing, Marcos hasn't. I am sending it because it can be queued for 2.6.30. Give us more time to test. 3. Patch 13 will be useful

Please review the list of patches being applied to the ocfs2 1.4 tree. All patches list the mainline commit hash. Thanks Sunil

...0000000 +0200 @@ -192,25 +192,20 @@ static void dlm_print_one_mle(struct dlm static void dlm_dump_mles(struct dlm_ctxt *dlm) { struct dlm_master_list_entry *mle; - struct list_head *iter; mlog(ML_NOTICE, "dumping all mles for domain %s:\n", dlm->name); spin_lock(&dlm->master_lock); - list_for_each(iter, &dlm->master_list) { - mle = list_entry(iter, struct dlm_master_list_entry, list); + list_for_each_entry(mle, &dlm->master_list, list) dlm_print_one_mle(mle); - } spin_unlock(&dlm->master_lock); } int dlm_dump_all_mles(const char __user *data,...

Hi, The following patches comprise the bulk of Ocfs2 updates for the 2.6.30 merge window. Aside from larger, more involved fixes, we're adding the following features, which I will describe in the order their patches are mailed. Sunil's exported some more state to our debugfs files, and consolidated some other aspects of our debugfs infrastructure. This will further aid us in debugging

Found 15 patches (out of 162) that appeared relevant to ocfs2 1.4. Please review. Sunil

The following series of patches comprises the bulk of our outstanding changes for Ocfs2. Aside from the usual set of cleanups and fixes that were inappropriate for 2.6.25, there are a few highlights: The '/sys/o2cb' directory has been moved to '/sys/fs/o2cb'. The new location meshes better with modern sysfs layout. A symbolic link has been placed in the old location so as to