search for: mas_find

...looks > good. > > I've a lengthy comment about the iterator that I'm adding here to head > off anyone that may copy your example below. > >> >> \#define sample_iter_for_each_range(it__, start__, end__) \ >> for ((it__).mas.index = start__, (it__).entry = mas_find(&(it__).mas, end__ - 1); \ >> (it__).entry; (it__).entry = mas_find(&(it__).mas, end__ - 1)) > > I see you've added something like the above in your patch set as well. > I'd like to point out that the index isn't the only state information > that needs t...

...er the entry we just inserted, >> right? > > I don't understand the "outer" tree walk statement. I think I could have phrased this better. I just mean "my" iterator walking each tree entry rather than an internal tree walk, as it happens in e.g. mas_walk() or mas_find(). > >> >> 1 a 3 >> old: |-----------| (bo_offset=n) >> >> 0 b 2 >> req: |-----------| (bo_offset=m) >> >> 0 b 2 a' 3 >> new: |-----------|-----| (b.bo_offset=m,a.bo_offset=n+...

...;>>> + */ >>>> +struct drm_gpuva * >>>> +drm_gpuva_find_first(struct drm_gpuva_manager *mgr, >>>> + u64 addr, u64 range) >>>> +{ >>>> + MA_STATE(mas, &mgr->va_mt, addr, 0); >>>> + >>>> + return mas_find(&mas, addr + range - 1); >>>> +} >>>> +EXPORT_SYMBOL(drm_gpuva_find_first); >>>> + >>>> +/** >>>> + * drm_gpuva_find - find a &drm_gpuva >>>> + * @mgr: the &drm_gpuva_manager to search in >>>> + * @addr:...

...gt;>> >>> I don't understand the "outer" tree walk statement. >> >> I think I could have phrased this better. I just mean "my" iterator walking >> each tree entry rather than an internal tree walk, as it happens in e.g. >> mas_walk() or mas_find(). >> >>> >>>> >>>> 1 a 3 >>>> old: |-----------| (bo_offset=n) >>>> >>>> 0 b 2 >>>> req: |-----------| (bo_offset=m) >>>> >>>> 0...