Displaying 10 results from an estimated 10 matches for "mapping_matrix_validate".
2017 Oct 12
2
[PATCH] Support for Channel Mapping 253.
thanks for all your feedback. here's the revised patch:
On Wed, Oct 11, 2017 at 2:20 PM Timothy B. Terriberry <tterribe at xiph.org>
wrote:
> Jean-Marc Valin wrote:
> > I think you'll want something like:
> > (opus_int16)((unsigned)demixing_matrix[2*i+1] << 8)
> > (though you might want to check it too)
>
> FWIW, we use the construct
> int s =
2017 Oct 31
7
[PATCH] Support for Channel Mapping 253.
...() should be returning
> align(sizeof(MappingMatrix)) + rows * cols * sizeof(opus_int16)
> rather than:
> align(sizeof(MappingMatrix) + rows * cols * sizeof(opus_int16))
> to match what mapping_matrix_get_data() does
>
> Done.
> 5) I'm not sure I understand the purpose of mapping_matrix_validate().
> Can the user really cause the matrix not to be valid? If yes, then can't
> this cause problems even earlier in the code? If not, then maybe an
> assertion would be better. Also, is the size of the matrix the only
> thing you can validate?
>
> Removed it. You're right,...
2017 Nov 03
1
[PATCH] Support for Channel Mapping 253.
...s * sizeof(opus_int16)
> > rather than:
> > align(sizeof(MappingMatrix) + rows * cols * sizeof(opus_int16))
> > to match what mapping_matrix_get_data() does
> >
> > Done.
> >
> >
> > 5) I'm not sure I understand the purpose of
> mapping_matrix_validate().
> > Can the user really cause the matrix not to be valid? If yes, then
> can't
> > this cause problems even earlier in the code? If not, then maybe an
> > assertion would be better. Also, is the size of the matrix the only
> > thing you can validate...
2017 Oct 31
0
[PATCH] Support for Channel Mapping 253.
...on.h
4) I believe mapping_matrix_get_size() should be returning
align(sizeof(MappingMatrix)) + rows * cols * sizeof(opus_int16)
rather than:
align(sizeof(MappingMatrix) + rows * cols * sizeof(opus_int16))
to match what mapping_matrix_get_data() does
5) I'm not sure I understand the purpose of mapping_matrix_validate().
Can the user really cause the matrix not to be valid? If yes, then can't
this cause problems even earlier in the code? If not, then maybe an
assertion would be better. Also, is the size of the matrix the only
thing you can validate?
6) mapping_matrix_init() returns an error code, but the co...
2017 Nov 02
0
[PATCH] Support for Channel Mapping 253.
...align(sizeof(MappingMatrix)) + rows * cols * sizeof(opus_int16)
> rather than:
> align(sizeof(MappingMatrix) + rows * cols * sizeof(opus_int16))
> to match what mapping_matrix_get_data() does
>
> Done.
>
>
> 5) I'm not sure I understand the purpose of mapping_matrix_validate().
> Can the user really cause the matrix not to be valid? If yes, then can't
> this cause problems even earlier in the code? If not, then maybe an
> assertion would be better. Also, is the size of the matrix the only
> thing you can validate?
>
> Removed it....
2017 Nov 07
0
[PATCH] Support for Channel Mapping 253.
...nt16))
> > > to match what mapping_matrix_get_data() does
> > >
> > > Done.
> > >
> > >
> > > 5) I'm not sure I understand the purpose of
> > mapping_matrix_validate().
> > > Can the user really cause the matrix not to be
> valid? If yes,
> > then can't
> > > this cause problems even earlier in the code? If
> not, then
> > maybe an
> > ...
2017 Nov 09
2
[PATCH] Support for Channel Mapping 253.
...> >
> > > > > Done.
> > > > >
> > > > >
> > > > > 5) I'm not sure I understand the purpose of
> > > > mapping_matrix_validate().
> > > > > Can the user really cause the matrix not
> to be
> > > valid? If yes,
> > > > then can't
> > > > > this cause problems even earlier in the
>...
2017 Nov 09
0
[PATCH] Support for Channel Mapping 253.
...does
> > > >
> > > > Done.
> > > >
> > > >
> > > > 5) I'm not sure I understand the purpose of
> > > mapping_matrix_validate().
> > > > Can the user really cause the matrix not to be
> > valid? If yes,
> > > then can't
> > > > this cause problems even earlier in the
> code? If
>...
2017 Nov 09
0
[PATCH] Support for Channel Mapping 253.
...; > > > > Done.
>> > > > >
>> > > > >
>> > > > > 5) I'm not sure I understand the purpose
>> of
>> > > > mapping_matrix_validate().
>> > > > > Can the user really cause the matrix not
>> to be
>> > > valid? If yes,
>> > > > then can't
>> > > > > this cause problems even...
2017 Nov 10
2
[PATCH] Support for Channel Mapping 253.
... > > Done.
> > > > >
> > > > >
> > > > > 5) I'm not sure I understand the
> purpose of
> > > > mapping_matrix_validate().
> > > > > Can the user really cause the
> matrix not to be
> > > valid? If yes,
> > > > then can't
> > > > > this...