search for: mapping_matrix_multiply_float

...3) I'm not sure I understand why the opus_copy_channel_out*() functions had to be moved. 4) OpusPEncoder: I'd prefer a more explicit name: OpusProjectionEncoder 5) Do you need to expose the "generic" opus_projection_encode() and opus_projection_encode_float() in the API? 6) In mapping_matrix_multiply_float(), for the !FIXED_POINT case you're multiplying by (1.f / 32768.f), but I think in the FIXED_POINT case, you should instead >>15 7) In mapping_matrix_multiply_short(), I would prefer >>15 instead of /32768 even though most compilers are smart enough by now. 8) For both matrix mult...

..."generic" opus_projection_encode() and > opus_projection_encode_float() in the API? > > *I'm confused... How else would people be able to encode a packet of > audio using the projection encoder? * Sorry, I got confused when reviewing. Forget about that point! > 6) In mapping_matrix_multiply_float(), for the !FIXED_POINT case you're > multiplying by (1.f / 32768.f), but I think in the FIXED_POINT case, you > should instead >>15 > > *My mistake. Is there a good resource I can read about fixed point float > operations?* I'm not aware of any unfortunately. > 8...

...efer a more explicit name: OpusProjectionEncoder *Done.* 5) Do you need to expose the "generic" opus_projection_encode() and opus_projection_encode_float() in the API? *I'm confused... How else would people be able to encode a packet of audio using the projection encoder? * 6) In mapping_matrix_multiply_float(), for the !FIXED_POINT case you're multiplying by (1.f / 32768.f), but I think in the FIXED_POINT case, you should instead >>15 *My mistake. Is there a good resource I can read about fixed point float operations?* 7) In mapping_matrix_multiply_short(), I would prefer >>15 instead...

...ncode() and > > opus_projection_encode_float() in the API? > > > > *I'm confused... How else would people be able to encode a packet of > > audio using the projection encoder? * > > Sorry, I got confused when reviewing. Forget about that point! > > > 6) In mapping_matrix_multiply_float(), for the !FIXED_POINT case you're > > multiplying by (1.f / 32768.f), but I think in the FIXED_POINT case, you > > should instead >>15 > > > > *My mistake. Is there a good resource I can read about fixed point float > > operations?* > > I'm not aw...

...opus_projection_encode_float() in the API? > > > > *I'm confused... How else would people be able to encode a packet of > > audio using the projection encoder? * > > Sorry, I got confused when reviewing. Forget about that point! > > > 6) In mapping_matrix_multiply_float(), for the !FIXED_POINT case > you're > > multiplying by (1.f / 32768.f), but I think in the FIXED_POINT > case, you > > should instead >>15 > > > > *My mistake. Is there a good resource I can read about fixed point > float >...

thanks for all your feedback. here's the revised patch: On Wed, Oct 11, 2017 at 2:20 PM Timothy B. Terriberry <tterribe at xiph.org> wrote: > Jean-Marc Valin wrote: > > I think you'll want something like: > > (opus_int16)((unsigned)demixing_matrix[2*i+1] << 8) > > (though you might want to check it too) > > FWIW, we use the construct > int s =

...error code, but the code that's > calling it never checks it. Considering that it's an internal call, I > would say it's probably better not to return anything, but instead to > assert in the function. > > Done. > 7) Same for mapping_matrix_multiply_short() and > mapping_matrix_multiply_float(), the return value isn't checked. So it > should either be replaced by an asssert or (if the user can cause a > failure) actually checked. > > Done. > 8) I see there's a "gain" field in the matrix, but I can't see it used > anywhere. Did I miss something? &...

...s it. Considering that it's an internal call, I > > would say it's probably better not to return anything, but instead to > > assert in the function. > > > > Done. > > > > > > 7) Same for mapping_matrix_multiply_short() and > > mapping_matrix_multiply_float(), the return value isn't checked. So > it > > should either be replaced by an asssert or (if the user can cause a > > failure) actually checked. > > > > Done. > > > > 8) I see there's a "gain" field in the matrix, but I can't...

...date? 6) mapping_matrix_init() returns an error code, but the code that's calling it never checks it. Considering that it's an internal call, I would say it's probably better not to return anything, but instead to assert in the function. 7) Same for mapping_matrix_multiply_short() and mapping_matrix_multiply_float(), the return value isn't checked. So it should either be replaced by an asssert or (if the user can cause a failure) actually checked. 8) I see there's a "gain" field in the matrix, but I can't see it used anywhere. Did I miss something? 9) In get_streams_from_channels(), I...

Hello all, Attached is an up-to-date patch for supporting channel mapping 253. Please advise and Thank you for your time. Cheers, Drew -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20170919/055d9034/attachment-0001.html> -------------- next part -------------- A non-text attachment was scrubbed... Name:

...39;s > calling it never checks it. Considering that it's an internal call, I > would say it's probably better not to return anything, but instead to > assert in the function. > > Done. >   > > 7) Same for mapping_matrix_multiply_short() and > mapping_matrix_multiply_float(), the return value isn't checked. So it > should either be replaced by an asssert or (if the user can cause a > failure) actually checked. > > Done.  > > 8) I see there's a "gain" field in the matrix, but I can't see it used > anywhere....

...gt;     instead to > >     >     assert in the function. > >     > > >     > Done. > >     >   > >     > > >     >     7) Same for mapping_matrix_multiply_short() and > >     >     mapping_matrix_multiply_float(), the return value isn't > >     checked. So it > >     >     should either be replaced by an asssert or (if the > user can > >     cause a > >     >     failure) actually checked. > >     > >...

...> > > > Done. > > > > > > > > > > > > > > > 7) Same for > > mapping_matrix_multiply_short() and > > > > > mapping_matrix_multiply_float(), the > > return value isn't > > > > checked. So it > > > > > should either be replaced by an asssert or > > (if the > > > user can > > > >...

...         >     > > >         >     > Done. > >         >     >   > >         >     > > >         >     >     7) Same for > mapping_matrix_multiply_short() and > >         >     >     mapping_matrix_multiply_float(), the > return value isn't > >         >     checked. So it > >         >     >     should either be replaced by an asssert or > (if the > >         user can > >         >     cause a > >   ...

...> > Done. >> > > > > >> > > > > >> > > > > 7) Same for >> > mapping_matrix_multiply_short() and >> > > > > mapping_matrix_multiply_float(), the >> > return value isn't >> > > > checked. So it >> > > > > should either be replaced by an asssert or >> > (if the >> > > user can >> >...

...ne. > >         >         >     >   > >         >         >     > > >         >         >     >     7) Same for > >         mapping_matrix_multiply_short() and > >         >         >     >     mapping_matrix_multiply_float(), the > >         return value isn't > >         >         >     checked. So it > >         >         >     >     should either be replaced by an > asssert or > >         (if the > >         >   ...