search for: manywarnings

Shuffle the order of the various CFLAGS used when building the Ruby extension: first the flags from manywarnings (gnulib), then libguestfs own CFLAGS, and then -DGUESTFS_PRIVATE=1 (so it is not overridden). This matches also what happens in automake parts, and makes it possible to override any flags from manywarnings also in the Ruby extension. --- ruby/ext/guestfs/extconf.rb.in | 5 +++-- 1 file changed, 3...

...aemon/m4/gnulib-cache.m4 @@ -15,11 +15,12 @@ # Specification in the form of a command-line invocation: -# gnulib-tool --import --dir=. --lib=libgnu --source-base=lib --m4-base=m4 --doc-base=doc --tests-base=tests --aux-dir=build-aux --with-tests --no-libtool --macro-prefix=gl hash ignore-value manywarnings warnings +# gnulib-tool --import --dir=. --lib=libgnu --source-base=lib --m4-base=m4 --doc-base=doc --tests-base=tests --aux-dir=build-aux --with-tests --no-libtool --macro-prefix=gl c-ctype hash ignore-value manywarnings warnings # Specification in the form of a few gnulib-tool.m4 macro invoca...

....m4 +++ b/daemon/m4/gnulib-cache.m4 @@ -15,12 +15,13 @@ # Specification in the form of a command-line invocation: -# gnulib-tool --import --dir=. --lib=libgnu --source-base=lib --m4-base=m4 --doc-base=doc --tests-base=tests --aux-dir=build-aux --with-tests --no-libtool --macro-prefix=gl hash manywarnings warnings +# gnulib-tool --import --dir=. --lib=libgnu --source-base=lib --m4-base=m4 --doc-base=doc --tests-base=tests --aux-dir=build-aux --with-tests --no-libtool --macro-prefix=gl hash ignore-value manywarnings warnings # Specification in the form of a few gnulib-tool.m4 macro invocations:...

...xplicitly. See: https://www.redhat.com/archives/libguestfs/2010-March/thread.html#00094 --- bootstrap | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/bootstrap b/bootstrap index ce8eeb0..349cf1c 100755 --- a/bootstrap +++ b/bootstrap @@ -76,6 +76,7 @@ maintainer-makefile manywarnings netinet_in progname +setenv strchrnul strerror strndup -- 1.6.4.1

Nearly any program that writes to standard output can benefit from this sort of fix. Without it, running e.g., ./guestfish --version > /dev/full would exit successfully, even though it got ENOSPC when writing to the full device. That means regular output redirected to a file on a full partition may also fail to be written, and the error ignored. Before: $ guestfish --version >

...rm of a command-line invocation: -# gnulib-tool --import --dir=. --lib=libgnu --source-base=lib --m4-base=m4 --doc-base=doc --tests-base=tests --aux-dir=build-aux --with-tests --no-libtool --macro-prefix=gl byteswap c-ctype connect error fsusage futimens getaddrinfo getline glob hash ignore-value manywarnings mkdtemp netdb openat perror pread read-file readlink select sleep socket strchrnul strndup symlinkat sys_select sys_wait vasprintf warnings +# gnulib-tool --import --dir=. --lib=libgnu --source-base=lib --m4-base=m4 --doc-base=doc --tests-base=tests --aux-dir=build-aux --with-tests --no-libtool -...

...miss new ones) so I spent some time last week and today working on removing them. The first patch gets us down to almost no warnings with the original -Wall setting. That was by far the hardest part. Once I'd done that, I enabled nearly all of gcc's warnings via gnulib's warnings and manywarnings modules and the code added to configure.ac in the final patch. I did it that way so that we can still bisect without compile failure, even when using the new --enable-gcc-warnings option. I.e., fix all warnings, *and then* add the code that turns on the new -W options along with -Werror. I sugges...

...| 7 +++++-- generator/bindtests.ml | 14 ++++++++------ 7 files changed, 45 insertions(+), 18 deletions(-) diff --git a/bootstrap b/bootstrap index 071682c..037d07e 100755 --- a/bootstrap +++ b/bootstrap @@ -66,6 +66,7 @@ hash-pjw human iconv ignore-value +intprops lock maintainer-makefile manywarnings diff --git a/cat/filesystems.c b/cat/filesystems.c index 1036c6f..0c7748d 100644 --- a/cat/filesystems.c +++ b/cat/filesystems.c @@ -33,6 +33,7 @@ #include "c-ctype.h" #include "human.h" +#include "intprops.h" #include "getprogname.h" #include "g...

v1 -> v2: - Use intprops macro suggested by danpb. Rich.

Without this option, configure will fail when there is no display. Signed-off-by: Masami HIRATA <msmhrt at gmail.com> --- configure.ac | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index de8a064..61d6f69 100644 --- a/configure.ac +++ b/configure.ac @@ -593,16 +593,16 @@ working. AC_MSG_FAILURE([$QEMU version must be >=

Brought to you by the "I haven't rebuilt the libguestfs universe in a while" saga -- now with working test suite. Pino Toscano (5): build: remove extra gnulib submodule build: remove extra checks and submodules build: stop using gnulib in test-harness build: remove unused gnulib modules Remove extra entries from podfiles .gitmodules | 3 -- Makefile.am

These patches first make src/ warning free, and then turn on the strict warning options. 75 0001-build-suppress-an-ignored-write-return-value-warning.patch 38 0002-build-suppress-an-ignored-dup-return-value-warning.patch 27 0003-generator.ml-suppress-signed-unsigned-compare-warnin.patch 48 0004-build-don-t-perform-arithmetic-on-void-pointers.patch 30

...Daniel P. Berrange) - qemu: Rewrite LOOKUP_PTYS macro into a function (Jiri Denemark) - Enable use of -Wold-style-definition compiler flag (Daniel P. Berrange) - Enable use of -Wmissing-noreturn (Daniel P. Berrange) - Enable -Wmissing-format-attribute warning (Daniel P. Berrange) - Use gnulib's manywarnings and warnings modules (Daniel P. Berrange) - Use virBufferPtr for sexpr2string instead of manual buffer handling (Matthias Bolte) - xend: Remove 4kb stack allocation (Matthias Bolte) - uml: Remove PATH_MAX sized stack allocation from /proc parsing code (Matthias Bolte) - storage: Remove PATH_MAX siz...

Brought to you by the "I haven't rebuilt the libguestfs universe in a while" saga. Pino Toscano (5): build: remove extra gnulib submodule build: remove extra checks and submodules build: stop using gnulib in test-harness build: remove unused gnulib modules Remove extra entries from podfiles .gitmodules | 3 -- Makefile.am | 2 - bootstrap

From: Jim Meyering <meyering at redhat.com> * lib/hivex.c (hivex_node_set_value): Remove unnecessary test-before-free. --- lib/hivex.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/lib/hivex.c b/lib/hivex.c index d042f4f..a72fa77 100644 --- a/lib/hivex.c +++ b/lib/hivex.c @@ -2748,8 +2748,7 @@ hivex_node_set_value (hive_h *h, hive_node_h node, leave_partial:

In an effort to reduce the code, start to use few bits of GLib: - replace the gnulib c-type module - replace the gnulib getprogname module - use g_spawn_sync to launch curl, and drop a file reading function Pino Toscano (6): Include glib.h in p2v.h Use g_ascii_isspace instead of c_isspace from gnulib Use g_get_prgname instead of getprogname from gnulib build: remove no more used gnulib

...glob glob-tests hash hash-pjw hash-tests hostent ignore-value include_next inet_ntop inet_ntop-tests inet_pton inet_pton-tests inline intprops inttostr ioctl lchown lchown-tests listen localcharset lseek lseek-tests lstat lstat-tests malloc-posix manywarnings mbrtowc mbrtowc-tests mbsinit mbsinit-tests mbsrtowcs mbsrtowcs-tests memchr memchr-tests mempcpy memrchr memrchr-tests mgetgroups mkdir mkdir-tests mkdtemp multiarch netdb netdb-tests netinet_in netinet_in-tests open open-tests openat openat-die op...

...glob glob-tests hash hash-pjw hash-tests hostent ignore-value include_next inet_ntop inet_ntop-tests inet_pton inet_pton-tests inline intprops inttostr ioctl lchown lchown-tests listen localcharset lseek lseek-tests lstat lstat-tests malloc-posix manywarnings mbrtowc mbrtowc-tests mbsinit mbsinit-tests mbsrtowcs mbsrtowcs-tests memchr memchr-tests mempcpy memrchr memrchr-tests mgetgroups mkdir mkdir-tests mkdtemp multiarch netdb netdb-tests netinet_in netinet_in-tests open open-tests openat openat-die op...

...s inttypes-incomplete inttypes-tests ioctl lchown lchown-tests listen localcharset locale locale-tests localename localename-tests lock lock-tests lseek lseek-tests lstat lstat-tests malloc-posix malloca malloca-tests manywarnings mbrtowc mbrtowc-tests mbsinit mbsinit-tests mbsrtowcs mbsrtowcs-tests mbtowc memchr memchr-tests mempcpy memrchr memrchr-tests mgetgroups mkdir mkdir-tests mkdtemp multiarch netdb netdb-tests netinet_in netinet_in-tests...

...glob glob-tests hash hash-pjw hash-tests hostent ignore-value include_next inet_ntop inet_ntop-tests inet_pton inet_pton-tests inline intprops inttostr ioctl lchown lchown-tests listen localcharset lseek lseek-tests lstat lstat-tests malloc-posix manywarnings mbrtowc mbrtowc-tests mbsinit mbsinit-tests mbsrtowcs mbsrtowcs-tests memchr memchr-tests mempcpy memrchr memrchr-tests mgetgroups mkdir mkdir-tests mkdtemp multiarch netdb netdb-tests netinet_in netinet_in-tests open open-tests openat openat-die op...