search for: malcious

...esses of vq metadata tends to be consistent for a while, and vhost knows > they will be frequently. SMAP doesn't help too much in this case. > > Thanks. It's true for a real life applications but a malicious one can call the setup ioctls any number of times. And SMAP is all about malcious applications. > > > > > > Packet or AF_XDP benefit from > > > accessing metadata directly, we should do it as well. > > > > > > Thanks

...esses of vq metadata tends to be consistent for a while, and vhost knows > they will be frequently. SMAP doesn't help too much in this case. > > Thanks. It's true for a real life applications but a malicious one can call the setup ioctls any number of times. And SMAP is all about malcious applications. > > > > > > Packet or AF_XDP benefit from > > > accessing metadata directly, we should do it as well. > > > > > > Thanks

...d vhost knows > > > they will be frequently. SMAP doesn't help too much in this case. > > > > > > Thanks. > > It's true for a real life applications but a malicious one > > can call the setup ioctls any number of times. And SMAP is > > all about malcious applications. > > > We don't do this in the path of ioctl, there's no context switch between > userspace and kernel in the worker thread. SMAP is used to prevent kernel > from accessing userspace pages unexpectedly which is not the case for > metadata access. > >...

...d vhost knows > > > they will be frequently. SMAP doesn't help too much in this case. > > > > > > Thanks. > > It's true for a real life applications but a malicious one > > can call the setup ioctls any number of times. And SMAP is > > all about malcious applications. > > > We don't do this in the path of ioctl, there's no context switch between > userspace and kernel in the worker thread. SMAP is used to prevent kernel > from accessing userspace pages unexpectedly which is not the case for > metadata access. > >...

...ly. SMAP doesn't help too much in this case. > > > > > > > > > > Thanks. > > > > It's true for a real life applications but a malicious one > > > > can call the setup ioctls any number of times. And SMAP is > > > > all about malcious applications. > > > > > > We don't do this in the path of ioctl, there's no context switch between > > > userspace and kernel in the worker thread. SMAP is used to prevent kernel > > > from accessing userspace pages unexpectedly which is not the case for...

...ly. SMAP doesn't help too much in this case. > > > > > > > > > > Thanks. > > > > It's true for a real life applications but a malicious one > > > > can call the setup ioctls any number of times. And SMAP is > > > > all about malcious applications. > > > > > > We don't do this in the path of ioctl, there's no context switch between > > > userspace and kernel in the worker thread. SMAP is used to prevent kernel > > > from accessing userspace pages unexpectedly which is not the case for...

...gt; > > > > > > > > > > > > > Thanks. > > > > > > It's true for a real life applications but a malicious one > > > > > > can call the setup ioctls any number of times. And SMAP is > > > > > > all about malcious applications. > > > > > We don't do this in the path of ioctl, there's no context switch between > > > > > userspace and kernel in the worker thread. SMAP is used to prevent kernel > > > > > from accessing userspace pages unexpectedly which is no...

...s to be consistent for a while, and vhost knows >> they will be frequently. SMAP doesn't help too much in this case. >> >> Thanks. > It's true for a real life applications but a malicious one > can call the setup ioctls any number of times. And SMAP is > all about malcious applications. We don't do this in the path of ioctl, there's no context switch between userspace and kernel in the worker thread. SMAP is used to prevent kernel from accessing userspace pages unexpectedly which is not the case for metadata access. Thanks > >>>> Packet...

.... SMAP doesn't help too much in this case. >>>>>> >>>>>> Thanks. >>>>> It's true for a real life applications but a malicious one >>>>> can call the setup ioctls any number of times. And SMAP is >>>>> all about malcious applications. >>>> We don't do this in the path of ioctl, there's no context switch between >>>> userspace and kernel in the worker thread. SMAP is used to prevent kernel >>>> from accessing userspace pages unexpectedly which is not the case for >>&...

...>>>> they will be frequently. SMAP doesn't help too much in this case. >>>> >>>> Thanks. >>> It's true for a real life applications but a malicious one >>> can call the setup ioctls any number of times. And SMAP is >>> all about malcious applications. >> >> We don't do this in the path of ioctl, there's no context switch between >> userspace and kernel in the worker thread. SMAP is used to prevent kernel >> from accessing userspace pages unexpectedly which is not the case for >> metadata access...

On Fri, Dec 14, 2018 at 11:57:35AM +0800, Jason Wang wrote: > > On 2018/12/13 ??11:44, Michael S. Tsirkin wrote: > > On Thu, Dec 13, 2018 at 06:10:22PM +0800, Jason Wang wrote: > > > It was noticed that the copy_user() friends that was used to access > > > virtqueue metdata tends to be very expensive for dataplane > > > implementation like vhost since it

On Fri, Dec 14, 2018 at 11:57:35AM +0800, Jason Wang wrote: > > On 2018/12/13 ??11:44, Michael S. Tsirkin wrote: > > On Thu, Dec 13, 2018 at 06:10:22PM +0800, Jason Wang wrote: > > > It was noticed that the copy_user() friends that was used to access > > > virtqueue metdata tends to be very expensive for dataplane > > > implementation like vhost since it

...ssed all comments from Daniel Berrange on the qemu side. * changes in v4) - use qio_channel_file_new_path() (Daniel) - rename to delete_old_pstore_file (Daniel) - convert G_REMOVE_SOURCE to FALSE (Daniel) * changes in v3) - use QIOChannel API (Stefan, Daniel) - add bound check for malcious guests (Daniel) - drop support PSTORE_TYPE_CONSOLE for now - update license to allow GPL v2 or later (Michael) - limit number of pstore files on qemu * changes in v2) - update VIRTIO_ID_PSTORE to 22 (Cornelia, Stefan) - make buffer size configurable (Cornelia) - support PSTORE_TYP...

...ssed all comments from Daniel Berrange on the qemu side. * changes in v4) - use qio_channel_file_new_path() (Daniel) - rename to delete_old_pstore_file (Daniel) - convert G_REMOVE_SOURCE to FALSE (Daniel) * changes in v3) - use QIOChannel API (Stefan, Daniel) - add bound check for malcious guests (Daniel) - drop support PSTORE_TYPE_CONSOLE for now - update license to allow GPL v2 or later (Michael) - limit number of pstore files on qemu * changes in v2) - update VIRTIO_ID_PSTORE to 22 (Cornelia, Stefan) - make buffer size configurable (Cornelia) - support PSTORE_TYP...

...tion of the virtio-pstore work. In this patchset I addressed most of feedbacks from previous version and drooped the support for PSTORE_TYPE_CONSOLE for simplicity. It'll be added once the basic implementation * changes in v3) - use QIOChannel API (Stefan, Daniel) - add bound check for malcious guests (Daniel) - drop support PSTORE_TYPE_CONSOLE for now - update license to allow GPL v2 or later (Michael) - limit number of pstore files on qemu * changes in v2) - update VIRTIO_ID_PSTORE to 22 (Cornelia, Stefan) - make buffer size configurable (Cornelia) - support PSTORE_TYP...

...tion of the virtio-pstore work. In this patchset I addressed most of feedbacks from previous version and drooped the support for PSTORE_TYPE_CONSOLE for simplicity. It'll be added once the basic implementation * changes in v3) - use QIOChannel API (Stefan, Daniel) - add bound check for malcious guests (Daniel) - drop support PSTORE_TYPE_CONSOLE for now - update license to allow GPL v2 or later (Michael) - limit number of pstore files on qemu * changes in v2) - update VIRTIO_ID_PSTORE to 22 (Cornelia, Stefan) - make buffer size configurable (Cornelia) - support PSTORE_TYP...