search for: makeinvari

...s available within the loop and preheader done. There's an argument for doing instcombine style optimizations within the loop as well, but that's less clear to me. > All trivial LICM done. By this I mean LICM which does not require aliasing or speculation safety logic. This is Loop::makeInvariant. > All trivial branches discharged. By this I mean both CFGSimplify style elimination of constant branch conditions, but also CVP, KnownBits, and SCEV. (Today, this is often true on entry to a loop pass manager, but is not upheld as passes run.) > To be clear, the above list is aspirati...

...le within the loop and preheader done.  There's an argument for doing instcombine style optimizations within the loop as well, but that's less clear to me. * All trivial LICM done.  By this I mean LICM which does not require aliasing or speculation safety logic.  This is Loop::makeInvariant. * All trivial branches discharged.  By this I mean both CFGSimplify style elimination of constant branch conditions, but also CVP, KnownBits, and SCEV.  (Today, this is often true on entry to a loop pass manager, but is not upheld as passes run.) To be clear, the above list is as...

Hi, I think we should remove the LoopInstSimplify pass, as it has no test coverage and no users (afaik). If you are using the pass, or think that it should stay in tree for some other reason, please let me know. Here's the patch: https://reviews.llvm.org/D44053 <https://reviews.llvm.org/D44053> vedant -------------- next part -------------- An HTML attachment was scrubbed... URL:

...;s an argument for doing instcombine >> style optimizations within the loop as well, but that's less >> clear to me. >> * All trivial LICM done.  By this I mean LICM which does not >> require aliasing or speculation safety logic.  This is >> Loop::makeInvariant. >> * All trivial branches discharged.  By this I mean both CFGSimplify >> style elimination of constant branch conditions, but also CVP, >> KnownBits, and SCEV.  (Today, this is often true on entry to a >> loop pass manager, but is not upheld as passes run....