search for: makeabsolut

Hello everyone, The Path::makeAbsolute is broken for Windows. It doesn't handle correctly a given absolute path with a drive letter or any UNC name. Please find the patch attached. -Viktor -------------- next part -------------- A non-text attachment was scrubbed... Name: makeAbsolute.patch Type: application/octet-stream Size: 2...

...=============================================================== > --- include/llvm/Support/FileSystem.h (revision 157010) > +++ include/llvm/Support/FileSystem.h (working copy) > @@ -426,12 +454,35 @@ > /// @param result_path Set to the opened file's absolute path. > /// @param makeAbsolute If true and @model is not an absolute path, a temp > /// directory will be prepended. > +/// @param private_file If true file will have permissions set to only > +/// be accessible by the current user. If false, then the file > +/// permissions are set to be glob...

I now have an implementation of FileOutputBuffer (OutputBuffer was already taken). The patch supports the functionality listed below and I've tested that it works for lld. -------------- next part -------------- A non-text attachment was scrubbed... Name: FileOutputBuffer.patch Type: application/octet-stream Size: 25308 bytes Desc: not available URL:

...Your last tweak looks reasonable. However, there are 2 things with that: 1. It has changed the behaviour of the FindExecutable method. Before this change, it searched the directory the executable has been started from, then directories from PATH. Now it checks the current working directory first (makeAbsolute does this for just a file name) and then does what it did before. I'm not saying this is bad, just different. Both works fine for the bugpoint. 2. makeAbsolute doesn't really work for the Windows if full path is provided. :) It checked the first character and if it is not "/" it...

...----- > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > -------------- next part -------------- A non-text attachment was scrubbed... Name: makeAbsolute.patch Type: application/octet-stream Size: 2937 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090710/196e7251/attachment.obj> -------------- next part -------------- A non-text attachment was scrubbed... Name: ToolRunner.diff Type: application/octet-s...

...------------------------------------------------------- > > >> _______________________________________________ >> LLVM Developers mailing list >> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > < > makeAbsolute > .patch > ><ToolRunner.diff>_______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

Hi Viktor, I did not see your patches, can you send them again. Here are the changes that I have made that seem to get remote execution working for bugpoint. I have not yet changed the test system to provide -remote- client and -remote-port. David -------------- next part -------------- A non-text attachment was scrubbed... Name: patch2 Type: application/octet-stream Size: 1906 bytes Desc:

...----------------------- >> >> >>> _______________________________________________ >>> LLVM Developers mailing list >>> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >> < >> makeAbsolute >> .patch >> ><ToolRunner.diff>_______________________________________________ >> LLVM Developers mailing list >> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > > ________________________...