search for: make_qcow2_overlay

...en using a non-file protocol.\n" + "If the format is known, pass the format to libguestfs, eg. using the\n" + "'--format' option, or via the optional 'format' argument to 'add-drive'.")); + return NULL; +} + static char * make_qcow2_overlay (guestfs_h *g, const char *backing_drive, const char *format) @@ -169,6 +213,8 @@ make_qcow2_overlay (guestfs_h *g, const char *backing_drive, char *overlay; struct guestfs_disk_create_argv optargs; + assert (format != NULL); + if (guestfs_int_lazy_make_tmpdir (g) =...

...;format> parameter is the backing file format. > + * The C<format> parameter can be NULL, in this case the backing > + * format will be determined automatically. This is used to create > + * the appliance overlay, and also for read-only drives. > */ > static char * > make_qcow2_overlay (guestfs_h *g, const char *backing_drive, > @@ -223,8 +224,6 @@ make_qcow2_overlay (guestfs_h *g, const char *backing_drive, > char *overlay; > struct guestfs_disk_create_argv optargs; > > - assert (format != NULL); > - > if (guestfs_int_lazy_make_tmpdir (g) == -1)...

Link to version 1: https://www.redhat.com/archives/libguestfs/2013-February/thread.html#00122 Changes since version 1: - I've pushed two (of the three) code refactoring patches. The third one proved rather hard to move. - selinuxnorelabel option is no more. Instead there is a second internal API (internal_set_libvirt_selinux_norelabel_disks). - fixed bogus commit message -

...e u; + + /* The format of the drive we add. */ char *format; }; @@ -135,8 +136,8 @@ static int is_custom_qemu (guestfs_h *g); static int is_blk (const char *path); static int random_chars (char *ret, size_t len); static void ignore_errors (void *ignore, virErrorPtr ignore2); -static char *make_qcow2_overlay (guestfs_h *g, const char *path, const char *format, const char *selinux_imagelabel); -static int make_qcow2_overlay_for_drive (guestfs_h *g, struct drive *drv, const char *selinux_imagelabel); +static char *make_qcow2_overlay (guestfs_h *g, const char *backing_device, const char *format, const cha...

https://bugzilla.redhat.com/show_bug.cgi?id=912499 (especially comments 7 & 10) This patch set is the final fix so that we can access disks in use by other guests when SELinux and sVirt are enabled. Previously such disks were inaccessible because sVirt labels the disks with a random SELinux label to prevent other instances of qemu from being able to read them. So naturally the libguestfs

The drive used for the appliance is a raw (sparse) disk: specify that explicitly in its -drive qemu command line options, so qemu can skip the autodetection of its format and save a tiny bit of time. --- src/launch-direct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/launch-direct.c b/src/launch-direct.c index ee0a855..8521e5a 100644 --- a/src/launch-direct.c +++

QEMU upstream has broken snapshot=on ... again. These two patches stop using it entirely. Instead we run 'qemu-img create' to create overlay disks as required. Note that the libvirt and UML backends were already doing this: The libvirt backend because <transient/> has never worked, and the UML backend was running uml_mkcow because the UML-equivalent syntax of snapshot=on was

v1 was here: https://www.redhat.com/archives/libguestfs/2020-February/msg00220.html This patch series is a little bit better. It's still a bit of a hack. The _real_ fix for this is outlined in the TODO file (see patch 1) but that requires a lot more work than we could do before 1.42 is released, unless we delay 1.42 for a lot longer. I'm hoping with this to have something which works

...("file=%s,snapshot=on,id=appliance,cache=unsafe,if=none,format=raw", > appliance); ACK. If I'm right, it seems we don't need any change in src/launch-libvirt.c, because we specify the backing file format ("raw") when creating the overlay in make_qcow2_overlay, and we set the overlay format ("qcow2") when adding the disk XML in construct_libvirt_xml_appliance. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit v...

...nt_add_sprintf (g, &optionsv, "preallocation=%s", preallocation); backingformat is an optional parameter (controlled by ‘optargs->bitmask & GUESTFS_DISK_CREATE_BACKINGFORMAT_BITMASK’), so just don't pass it, rather than defining new API. Then ... > @@ -233,7 +232,7 @@ make_qcow2_overlay (guestfs_h *g, const char *backing_drive, > optargs.bitmask = GUESTFS_DISK_CREATE_BACKINGFILE_BITMASK; > optargs.backingfile = backing_drive; > optargs.bitmask |= GUESTFS_DISK_CREATE_BACKINGFORMAT_BITMASK; > - optargs.backingformat = format; > + optargs.backingformat = for...

...- optargs.bitmask = GUESTFS_DISK_CREATE_BACKINGFILE_BITMASK; optargs.backingfile = backing_drive; if (drv->src.format) { diff --git a/lib/launch-libvirt.c b/lib/launch-libvirt.c index 98c947288..e5121799e 100644 --- a/lib/launch-libvirt.c +++ b/lib/launch-libvirt.c @@ -224,11 +224,10 @@ make_qcow2_overlay (guestfs_h *g, const char *backing_drive, char *overlay; struct guestfs_disk_create_argv optargs; - if (guestfs_int_lazy_make_tmpdir (g) == -1) + overlay = guestfs_int_make_temp_path (g, "overlay", "qcow2"); + if (!overlay) return NULL; - overlay = safe_asprin...

This is, I guess, version 3 of this patch series which adds disk labels and hotplugging (only hot-add implemented so far). The good news is .. it works! Rich.

This rounds off hotplugging support by allowing you to add and remove drives at any stage (before and after launch). Rich.

A lot of code runs 'qemu-img create' or 'truncate' to create blank disk images. In the past I resisted adding an API to do this, since it essentially duplicates what you can already do using other tools (ie. qemu-img). However this does simplify calling code quite a lot since qemu-img is somewhat error-prone to use (eg: don't try to create a disk called "foo:bar")

Inspired by libvirt's virCommand* internal mini-library, this adds some internal APIs for running commands. The first patch contains the new APIs. The subsequent patches change various parts of the library over to use it. Rich.

v1 -> v2: - Remove the unnecessary calls to guestfs_int_lazy_make_tmpdir in the final patch. Rich.

Miscellaneous small cleanups in lib/ directory. Rich.

Tested with 'make check-release'. tests/parallel (in check-slow) failed, although it does regularly and that seems to be because of libvirt. Rich.

In the kernel and qemu communities it is routine for patches that will be backported to stable branches to be posted for review. I'm proposing we do the same for libguestfs stable branches. All of the attached have been tested with 'make check-release'. Rich.

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.