Displaying 2 results from an estimated 2 matches for "make_notify_variant_of_call".
2019 Jun 29
1
Re: [libnbd PATCH 5/6] api: Add new nbd_aio_FOO_notify functions
Obvious change given the previous patch, so ACK.
I do wonder if we should make the notify parameter mandatory (and
therefore avoid the duplicate functions).
Another trick you might do if feeling really keen is to
programmatically generate the notify variants of commands, something
like this:
let make_notify_variant_of_call ({ args; longdesc } as call) =
let args = List.rev args in
let flags, args = List.hd args, List.tl args in
assert (flags = Flags "flags");
let args = flags :: CallbackPersist ("notify", [ etc ]) :: args in
let args = List.rev args in
let longdesc = longdesc ^ "\...
2019 Jun 29
19
[libnbd PATCH 0/6] new APIs: aio_in_flight, aio_FOO_notify
I still need to wire in the use of *_notify functions into nbdkit to
prove whether it makes the code any faster or easier to maintain, but
at least the added example shows one good use case for the new API.
Eric Blake (6):
api: Add nbd_aio_in_flight
generator: Allow DEAD state actions to run
generator: Allow Int64 in callbacks
states: Prepare for aio notify callback
api: Add new