search for: make_absolute_pwd_glob

We had one more report from Coverity Scan after we brought 9.1p1 into the FreeBSD base system. It complains that calls like "path1 = make_absolute_pwd_glob(path1, *pwd);" in sftp.c leak the allocation. All make_absolute_pwd_glob() calls but one are of that form, so perhaps have it consume and free the first arg, as below (and https://reviews.freebsd.org/D37253)? diff --git a/crypto/openssh/sftp.c b/crypto/openssh/sftp.cindex c3c347e087e4..630e7...

On Fri, 11 Nov 2022 at 11:05, Ed Maste <emaste at freebsd.org> wrote: > > We had one more report from Coverity Scan after we brought 9.1p1 into > the FreeBSD base system. It complains that calls like "path1 = > make_absolute_pwd_glob(path1, *pwd);" in sftp.c leak the allocation. I see this same issue has since been reported by Coverity upstream and fixed in 36c6c3eff5e4, but that change still missed all of the other leaks addressed by my change. Updated patch in https://reviews.freebsd.org/D37253

On Wed, 22 Mar 2023 at 06:14, Ed Maste <emaste at freebsd.org> wrote: [...] > I see this same issue has since been reported by Coverity upstream and > fixed in 36c6c3eff5e4, but that change still missed all of the other > leaks addressed by my change. Applied, thanks. Interestingly our shiny new Coverity scan did not report any fixed leaks, though. -- Darren Tucker (dtucker at