Displaying 13 results from an estimated 13 matches for "major_".
Did you mean:
major
2016 May 26
1
[PATCH] lib: qemu: use guestfs_int_version_from_x_y for qemu version parsing
...0 100644
--- a/src/qemu.c
+++ b/src/qemu.c
@@ -37,16 +37,12 @@
#include <libxml/uri.h>
-#include <pcre.h>
-
#include "ignore-value.h"
#include "guestfs.h"
#include "guestfs-internal.h"
#include "guestfs_protocol.h"
-COMPILE_REGEXP (re_major_minor, "(\\d+)\\.(\\d+)", 0)
-
struct qemu_data {
char *qemu_help; /* Output of qemu -help. */
char *qemu_devices; /* Output of qemu -device ? */
@@ -265,29 +261,15 @@ static void
parse_qemu_version (guestfs_h *g, const char *qemu_help,
s...
2016 Mar 22
0
[PATCH v3 07/11] launch: direct: Don't run qemu -version.
...ect_data *data)
@@ -1013,13 +999,13 @@ parse_qemu_version (guestfs_h *g, struct backend_direct_data *data)
data->qemu_version_major = 0;
data->qemu_version_minor = 0;
- if (!data->qemu_version)
+ if (!data->qemu_help)
return;
- if (!match2 (g, data->qemu_version, re_major_minor, &major_s, &minor_s)) {
+ if (!match2 (g, data->qemu_help, re_major_minor, &major_s, &minor_s)) {
parse_failed:
- debug (g, "%s: failed to parse qemu version string '%s'",
- __func__, data->qemu_version);
+ debug (g, "%s: failed...
2016 May 18
2
[PATCH v2 0/2] lib: qemu: Memoize qemu feature detection.
v1 -> v2:
- Rebase on top of Pino's version work.
Two patches went upstream, these are the two remaining patches.
Note the generation number is still inside the qemu.stat file. We
could put it in the filename, I have no particular preference.
Rich.
2016 May 12
7
[PATCH 0/4] lib: qemu: Memoize qemu feature detection.
Doing qemu feature detection in the direct backend takes ~100ms
because we need to run `qemu -help' and `qemu -devices ?', and each of
those interacts with glibc's very slow link loader.
Fixing the link loader is really hard. Instead memoize the
output of those two commands.
This patch series first separates all the code dealing with qemu into
a separate module (src/qemu.c) and
2016 May 17
0
[PATCH 1/2] src: start unifying version handling
...or == 1 && minor >= 5))
+ if (guestfs_int_version_is (&data->qemu_version, 1, 5, 0))
discard_mode = ",discard=unmap";
break;
}
@@ -1002,8 +999,7 @@ parse_qemu_version (guestfs_h *g, struct backend_direct_data *data)
CLEANUP_FREE char *major_s = NULL, *minor_s = NULL;
int major_i, minor_i;
- data->qemu_version_major = 0;
- data->qemu_version_minor = 0;
+ version_init_null (&data->qemu_version);
if (!data->qemu_help)
return;
@@ -1023,8 +1019,7 @@ parse_qemu_version (guestfs_h *g, struct backend_direct_da...
2019 Feb 19
2
Re: [PATCH nbdkit 4/4] Add linuxdisk plugin.
...ather than in readdir() order.
> +static int
> +e2emptyinode (ext2_filsys fs, ext2_ino_t dir_ino,
> + const char *name, const struct stat *statbuf,
> + int ino_flags, ext2_ino_t *ino)
> +{
> + errcode_t err;
> + struct ext2_inode inode;
> + int major_, minor_;
> +
> + err = ext2fs_new_inode (fs, dir_ino, statbuf->st_mode, 0, ino);
> + if (err) {
> + nbdkit_error ("ext2fs_new_inode: %s", error_message (err));
> + return -1;
> + }
> +
> + memset (&inode, 0, sizeof inode);
> + inode.i_mode = st...
2019 Feb 19
0
[PATCH nbdkit 4/4] Add linuxdisk plugin.
...to do some other stuff. For directories, use
+ * e2mkdir instead.
+ */
+static int
+e2emptyinode (ext2_filsys fs, ext2_ino_t dir_ino,
+ const char *name, const struct stat *statbuf,
+ int ino_flags, ext2_ino_t *ino)
+{
+ errcode_t err;
+ struct ext2_inode inode;
+ int major_, minor_;
+
+ err = ext2fs_new_inode (fs, dir_ino, statbuf->st_mode, 0, ino);
+ if (err) {
+ nbdkit_error ("ext2fs_new_inode: %s", error_message (err));
+ return -1;
+ }
+
+ memset (&inode, 0, sizeof inode);
+ inode.i_mode = statbuf->st_mode;
+ inode.i_uid = statbuf-&...
2019 Feb 19
7
[PATCH nbdkit 0/4] New plugin: Add linuxdisk plugin.
Turns out Japanese trains are good for coding!
In supermin we have a bunch of code to create the libguestfs
appliance. It creates it directly using libext2fs (part of
e2fsprogs). We can use the same technique to create ext2 virtual
disks in nbdkit, which is what this new plugin does. Why a new plugin
instead of modifying the floppy plugin? See the 4/4 commit message
for an explanation.
The
2019 Feb 19
6
[PATCH nbdkit v2 0/5] Add linuxdisk plugin.
Another interesting thing you can do with this plugin:
https://rwmj.wordpress.com/2019/02/19/nbdkit-linuxdisk-plugin/
v2:
- Fix inconsistent tab/space.
- All 3 plugins now contain a block of text pointing to the
other 2 plugins.
- TMDIR -> TMPDIR
- Unlink the temporary file and other cleanups along error paths.
- fclose -> pclose, and check the return value for errors.
-
2016 May 17
3
[PATCH 0/2] src: introduce an helper version struct
Hi,
this adds an helper version struct, and uses it in the backends (for the
libvirt and qemu versions) and inspection code. This also moves common
code to that, so it is not repeated in many places.
This should help with the small refactoring proposed with
https://www.redhat.com/archives/libguestfs/2016-May/msg00070.html
Thanks,
Pino Toscano (2):
src: start unifying version handling
2016 May 18
3
[PATCH v2 0/2] src: introduce an helper version struct
Hi,
this adds an helper version struct, and uses it in the backends (for the
libvirt and qemu versions) and inspection code. This also moves common
code to that, so it is not repeated in many places.
This should help with the small refactoring proposed with
https://www.redhat.com/archives/libguestfs/2016-May/msg00070.html
Thanks,
Pino Toscano (2):
src: start unifying version handling
2016 Mar 22
19
[PATCH v3 0/11] tests/qemu: Add program for tracing and analyzing boot times.
Lots of changes since v2, too much to remember or summarize.
Please ignore patch 11/11, it's just for my testing.
Rich.
2015 Feb 14
2
[PATCH 0/2] Change guestfs__*
libguestfs has used double and triple underscores in identifiers.
These aren't valid for global names in C++.
(http://stackoverflow.com/a/228797)
These large but completely mechanical patches change the illegal
identifiers to legal ones.
Rich.