search for: maiorani

Hi, I am new around here, so I am not sure of all your procedures for submitting patches/pull requests. The attached patch fixes all Clang compilation warnings. Note, some of these warnings were real problems. There is the potential for API users to misinterpret the state being returned since the return variable was of type FLAC__StreamDecoderState, but the value being returned was

On Apr 7, 2014, at 4:07 AM, Erik de Castro Lopo <mle+la at mega-nerd.com> wrote: > Lenny Maiorani wrote: > >> I am new around here, so I am not sure of all your procedures >> for submitting patches/pull requests. > > A patch like you sent is fine. When I commit that I will add > a Patch-from line to the commit. > > Otherwise, you can commit to you local repo and...

Lenny Maiorani wrote: > I am new around here, so I am not sure of all your procedures > for submitting patches/pull requests. A patch like you sent is fine. When I commit that I will add a Patch-from line to the commit. Otherwise, you can commit to you local repo and then use the git format-patch sub com...

Erik de Castro Lopo wrote: > This could also be fixed by adding a: > > decoder->protected_->initstate > > and using that correctly. Right? > > I'm going to play with this idea. That fixed it. Commit is here: https://git.xiph.org/?p=flac.git;a=commit;h=3f5208c30022b7cbd0b9095ad3550c4f6cb348c9 What didn't get added was this: diff --git

Hi Chris (or anyone else), Today I ran across a stack overflow in EarlyCSE::processNode(). Basically, the issue is that EarlyCSE::processNode() is recursive and with a very large function, such as the machine generated one I have, it blows the stack. The attached script generates a function which re-creates the problem. On my 64-bit FreeBSD 7.3 build machine I come across this issue with a

This also causes a warning and looks like it is the wrong #ifdef. ioctl() is only used inside of a '#if !defined __ANDROID__'. Note, this compiler warning was generated when compiling on Mac OSX 10.9 with clang: utils.c:189:6: warning: implicit declaration of function 'ioctl' is invalid in C99 [-Wimplicit-function-declaration] Also, at the moment, TOT does not compile. It