search for: mailbox_keywords_unref

In 2.2.5 and earlier it appears that mailbox_keywords_unref(&keywords) is not called in some return paths from cmd_append_handle_args(). Should it be?

...ES, &status); + if (status.messages >= MAX_MSGS_PER_MAILBOX) { + mail_storage_set_error(box->storage, MAIL_ERROR_NOSPACE, + "Mailbox full: Too many messages"); + ret = -1; + } else { + ret = ctx->transaction->box->v.copy(ctx, mail); + } if (keywords != NULL) mailbox_keywords_unref(&keywords); return ret; } int mailbox_save_using_mail(struct mail_save_context **ctx, struct mail *mail) -------------- next part -------------- --- dovecot-2.0.7/src/lib-storage/mail-storage.c.ORIG 2010-11-11 19:46:14.000000000 +0000 +++ dovecot-2.0.7/src/lib-storage/mail-storage.c 2010-...

Hi! I am currently in the process of preparing a migration of our old Courier-based IMAP/POP server setup to a Dovecot-based one. During this process I came across the following problem with the difference Courier and Dovecot handle deleted messages and mail quota. Quote from http://www.courier-mta.org/imap/README.maildirquota.html: ,---- | The default application configuration that uses this

...#0 0x00007f404e58e3b6 in mail_index_keywords_unref >> #(_keywords=_keywords at entry=0x7ffecb8adeb8) at mail-index.c:383 >> keywords = 0x7f404e27066d <buffer_alloc+45> >> __FUNCTION__ = "mail_index_keywords_unref" >> #1 0x00007f404e559975 in mailbox_keywords_unref >> (keywords=keywords at entry=0x7ffecb8adeb8) at mailbox-keywords.c:94 >> No locals. >> #2 0x00007f404ea254ad in cmd_append_handle_args >> (nonsync_r=0x7ffecb8ade8f, >> #args=<optimized out>, cmd=0x7f4050bc3250) at cmd-append.c:602 >> ctx = 0x7f40...

...58e3b6 in mail_index_keywords_unref >>> #(_keywords=_keywords at entry=0x7ffecb8adeb8) at mail-index.c:383 >>> keywords = 0x7f404e27066d <buffer_alloc+45> >>> __FUNCTION__ = "mail_index_keywords_unref" >>> #1 0x00007f404e559975 in mailbox_keywords_unref >>> (keywords=keywords at entry=0x7ffecb8adeb8) at mailbox-keywords.c:94 >>> No locals. >>> #2 0x00007f404ea254ad in cmd_append_handle_args >>> (nonsync_r=0x7ffecb8ade8f, >>> #args=<optimized out>, cmd=0x7f4050bc3250) at cmd-append.c:602 >>&...