search for: mail_update_keyword

...e feature: add a keyword to a message when it is moved or copied into a virtual folder (let's forget about what keyword to add, I'm starting with a hard-coded one to understand Dovecot plugin development). So I've added a mail_copy hook by the notify plugin [2] and did a simple call to mail_update_keywords [3]. The current source code shows a call to mail_get_backend_mail, this is me experimenting, I've also tried calling mail_update_keywords directly on "dst" mail. The result is an imap crash: Oct 14 21:22:26 notebook dovecot: imap(daniele): Panic: file mail-log-plugin.c: line 461 (...

...th applying this patch to the official version, if that is desired. The patch is based on current tip and feedback is appreciated. I took some inspiration from dovecot-core/src/plugins/notify/notify-storage.c -- this requires the use of struct mail_private to be able to override the vfunc for mail_update_keywords, which I actually do not like. However, when I tried to make this patch base on the use of the notify plugin (via notify_register), I ran into the issue that the transaction is partially freed before the transaction_commit event from notify is emitted, which is unfortunate and breaks at least...

...10:39:08.000000000 +0200 @@ -99,6 +99,10 @@ failed = TRUE; break; } + + if( ( (mail_get_flags(mail) & MAIL_DELETED) == 0) && + (flags & MAIL_DELETED)) + client->deleted_count++; } if (modify_type == MODIFY_REPLACE || keywords != NULL) { if (mail_update_keywords(mail, modify_type, diff -ur dovecot-1.0.alpha1.orig/src/imap/imap-expunge.c dovecot-1.0.alpha1/src/imap/imap-expunge.c --- dovecot-1.0.alpha1.orig/src/imap/imap-expunge.c 2005-03-29 10:38:42.000000000 +0200 +++ dovecot-1.0.alpha1/src/imap/imap-expunge.c 2005-08-23 10:39:08.000000000 +0200 @@ -5,7...