Displaying 2 results from an estimated 2 matches for "mail_sendmail".
2016 Aug 16
3
[patch] Improved error checking for the dovecot-antispam-plugin
Hi,
Hopefully this is the right channel for such a patch. I have a minor
enhancement to submit for the antispam plugin
http://hg.dovecot.org/dovecot-antispam-plugin
It adds minimal error checking for the sendmail_binary, otherwise the
reported error in case of a missing binary or one with missing
permissions is generic and not useful.
Thanks,
Robert
--
http://robert.muntea.nu/
2016 Aug 18
3
[patch] Improved error checking for the dovecot-antispam-plugin
...,
>>
>> Robert
>
> Robert, I like that you did this.
>
> Beyond that and without even looking at the actual code, I'm curious why
> you:
>
> + if (access(cfg->binary, F_OK) == -1)
> + {
> + mail_storage_set_error(storage, MAIL_ERROR_TEMP, "mail_sendmail
> file does not exist");
>
> instead of finding a way to include the value of cfg->binary in the
> error message string.
>
> This might not be needed if it's really obvious from the config file
> what the path to the executable is, but if there is any doubt it might...