search for: macho_embedded

...I can get support from the community that this is the direction we'd all like to take... I'd rather not make triples more complicated by introducing lots of special cases. Do you know who the right folks are to ask about the SPIR triples? Tim, This patch changes behavior a little for macho_embedded targets (i.e. from OSType::Unknown to OSType::NoneOS). I see that there is existing code to transform triples from things like thumbv7-apple-darwin into thumbv7m-apple-unknown-macho. Do you have an expectation to support users who are using the latter form of triples who would be surprised by t...

...e'd all like to take... I'd rather not >> make triples more complicated by introducing lots of special cases. >> >> Do you know who the right folks are to ask about the SPIR triples? >> >> >> Tim, >> >> This patch changes behavior a little for macho_embedded targets (i.e. from >> OSType::Unknown to OSType::NoneOS). I see that there is existing code to >> transform triples from things like thumbv7-apple-darwin into >> thumbv7m-apple-unknown-macho. Do you have an expectation to support users >> who are using the latter form of tri...

Hi Jonathan, The main issue with your patch is that it can change user expected behaviour, and I can't tell you what is the expected behaviour in Darwin or BSD. If people usually use "unknown" in triples, this will break their builds. If not, this could break the build of someone who does. My advice is to create a "default" mechanism for the affected targets, something

...- a/runtime/compiler-rt/Makefile +++ b/runtime/compiler-rt/Makefile @@ -83,7 +83,7 @@ RuntimeLibrary.darwin.Configs := \ eprintf.a 10.4.a osx.a ios.a cc_kext.a cc_kext_ios5.a \ asan_osx_dynamic.dylib \ profile_osx.a profile_ios.a \ - ubsan_osx.a + ubsan_osx.a safestack_osx.a RuntimeLibrary.macho_embedded.Configs := \ hard_static.a hard_pic.a @@ -127,7 +127,7 @@ TryCompile = \ # We try to build 32-bit runtimes both on 32-bit hosts and 64-bit hosts. Runtime32BitConfigs = \ builtins-i386.a profile-i386.a san-i386.a asan-i386.a asan_cxx-i386.a \ - ubsan-i386.a ubsan_cxx-i386.a + ubsan-i386.a ubsa...