Displaying 9 results from an estimated 9 matches for "macfij7".
2017 May 14
8
[PATCH 1/3] Fix ERROR: trailing statements should be on next line
From: Maciej Fijalkowski <macfij7 at wp.pl>
Signed-off-by: Maciej Fijalkowski <macfij7 at wp.pl>
---
drivers/net/virtio_net.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 9320d96..f20dfb8 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers...
2017 May 14
8
[PATCH 1/3] Fix ERROR: trailing statements should be on next line
From: Maciej Fijalkowski <macfij7 at wp.pl>
Signed-off-by: Maciej Fijalkowski <macfij7 at wp.pl>
---
drivers/net/virtio_net.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 9320d96..f20dfb8 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers...
2017 May 15
0
[PATCH 2/3] Fix ERROR: Macros with complex values should be enclosed in parentheses
On Sun, May 14, 2017 at 07:51:29PM +0200, Maciek Fijalkowski wrote:
> From: Maciej Fijalkowski <macfij7 at wp.pl>
>
> Signed-off-by: Maciej Fijalkowski <macfij7 at wp.pl>
This is not a complex value.
> ---
> drivers/net/virtio_net.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> i...
2017 May 15
0
[PATCH 1/3] Fix ERROR: trailing statements should be on next line
On Sun, May 14, 2017 at 07:51:28PM +0200, Maciek Fijalkowski wrote:
> From: Maciej Fijalkowski <macfij7 at wp.pl>
>
> Signed-off-by: Maciej Fijalkowski <macfij7 at wp.pl>
I prefer the original form - ; isn't a full statement.
> ---
> drivers/net/virtio_net.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/virtio_net.c b/dri...
2017 May 15
0
[PATCH 3/3] Fix ERROR: code indent should use tabs where possible
On Sun, May 14, 2017 at 07:51:30PM +0200, Maciek Fijalkowski wrote:
> From: Maciej Fijalkowski <macfij7 at wp.pl>
>
> Signed-off-by: Maciej Fijalkowski <macfij7 at wp.pl>
Acked-by: Michael S. Tsirkin <mst at redhat.com>
But you really want to fix the subject. Make it less verbose
drop upper case and add info about module. Something like:
virtio_net: coding style fix: use tab...
2017 May 15
1
[PATCH 1/3] Fix ERROR: trailing statements should be on next line
On Mon, 15 May 2017 05:58:05 +0300
"Michael S. Tsirkin" <mst at redhat.com> wrote:
> On Sun, May 14, 2017 at 07:51:28PM +0200, Maciek Fijalkowski wrote:
> > From: Maciej Fijalkowski <macfij7 at wp.pl>
> >
> > Signed-off-by: Maciej Fijalkowski <macfij7 at wp.pl>
>
> I prefer the original form - ; isn't a full statement.
>
> > ---
> > drivers/net/virtio_net.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
&...
2017 May 14
0
[PATCH 2/3] Fix ERROR: Macros with complex values should be enclosed in parentheses
From: Maciej Fijalkowski <macfij7 at wp.pl>
Signed-off-by: Maciej Fijalkowski <macfij7 at wp.pl>
---
drivers/net/virtio_net.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index f20dfb8..6c8170c 100644
--- a/drivers/net/virtio_net.c
+++ b/drive...
2017 May 14
0
[PATCH 3/3] Fix ERROR: code indent should use tabs where possible
From: Maciej Fijalkowski <macfij7 at wp.pl>
Signed-off-by: Maciej Fijalkowski <macfij7 at wp.pl>
---
drivers/net/virtio_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 6c8170c..5d71e9f 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/n...
2017 May 15
1
[PATCH 1/3] Fix ERROR: trailing statements should be on next line
On Mon, 15 May 2017 05:58:05 +0300
"Michael S. Tsirkin" <mst at redhat.com> wrote:
> On Sun, May 14, 2017 at 07:51:28PM +0200, Maciek Fijalkowski wrote:
> > From: Maciej Fijalkowski <macfij7 at wp.pl>
> >
> > Signed-off-by: Maciej Fijalkowski <macfij7 at wp.pl>
>
> I prefer the original form - ; isn't a full statement.
>
> > ---
> > drivers/net/virtio_net.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
&...