search for: m_next

...er upgrading to Tiger, they still work fine when on our LAN. But if they try to connect to a share over the VPN, Finder hangs. The Mac logs the following messages in /var/log/system.log during the hang: Jul 29 09:59:46 brian-daniels-powerbook-g4-15 kernel[0]: bug: ecnt = 32, but m_len = 0 and m_next = 0 (please report) Jul 29 09:59:46 brian-daniels-powerbook-g4-15 kernel[0]: bug: ecnt = 33, but m_len = 0 and m_next = 0 (please report) Jul 29 09:59:46 brian-daniels-powerbook-g4-15 kernel[0]: bug: ecnt = 32, but m_len = 0 and m_next = 0 (please report) Jul 29 09:59:46 brian-daniels-powerbook-g...

...t;; pr "=head1 API CALLS\n"; diff --git a/lib/handle.c b/lib/handle.c index 6f5a4d6..840702a 100644 --- a/lib/handle.c +++ b/lib/handle.c @@ -90,7 +90,6 @@ nbd_create (void) void nbd_close (struct nbd_handle *h) { - struct close_callback *cc, *cc_next; struct meta_context *m, *m_next; if (h == NULL) @@ -100,12 +99,6 @@ nbd_close (struct nbd_handle *h) if (h->debug_fn) h->debug_fn (LIBNBD_CALLBACK_FREE, h->debug_data, NULL, NULL); - for (cc = h->close_callbacks; cc != NULL; cc = cc_next) { - cc_next = cc->next; - cc->cb (cc->user_data);...

...w BasicBlock("entry", MyFunc); ... Value *Zero = ConstantSInt::get(Type::IntTy, 0); Value *UZero = ConstantUInt::get(Type::UIntTy, 0); MallocInst* mi = new MallocInst( STyStru ); mi->setName("tmp.0"); BBlock->getInstList().push_back( mi ); GetElementPtrInst *m_Next = new GetElementPtrInst(mi, UZero, Zero, "tmp.3", BBlock ); ... ======================== But I tried your code instead of the lines above: GetElementPtrInst *GEP = new GetElementPtrInst(mi, // %tmp.0 ConstantSInt::get(Type::IntTy, 0), C...

...our LAN. But if they try to connect to a [Samba 3.0.10-1] > share over the [IPsec] VPN, Finder hangs. The Mac logs the > following messages in /var/log/system.log during the hang: > > Jul 29 09:59:46 brian-daniels-powerbook-g4-15 kernel[0]: bug: ecnt > = 32, but m_len = 0 and m_next = 0 (please report) > > It keeps logging these errors until Finder is forced to quit. > Interestingly, if the server connected to has only a few files > (<~30) in the root directory, then the hang does not occur. But if > the user then tries to cd to a dir containing more f...

While working on can_FOO caching, at one point I got confused by whether 'readonly' meant the global set by -r or a local passed to .open(). A quick attempt to compile with -Wshadow found several other confusing points; this series gets us to the point that we can add -Wshadow to builds with --enable-gcc-warnings. Eric Blake (10): server: Avoid -Wshadow warnings guestfs: Avoid

.../* Free user callbacks first. */ - if (h->debug_callback) - h->debug_callback (LIBNBD_CALLBACK_FREE, h->debug_data, NULL, NULL); - h->debug_callback = NULL; + nbd_unlocked_clear_debug_callback (h); free (h->bs_entries); for (m = h->meta_contexts; m != NULL; m = m_next) { -- 2.22.0

This isn't quite finished because not all of the tests or examples have been updated, but it demonstrates an idea: Should we forget about the concept of having multiple connections managed under a single handle? In this patch there is a single ‘struct nbd_handle *’ which manages a single state machine and connection (and therefore no nbd_connection). To connect to a multi-conn server you must

I think I've addressed everything that was raised in review. Some of the highlights: - Callbacks should be freed reliably along all exit paths. - There's a simple test of closure lifetimes. - I've tried to use VALID|FREE in all the places where I'm confident that it's safe and correct to do. There may be more places. Note this is an optimization and shouldn't

...PLY.START); + SET_NEXT_STATE (%^OPT_LIST.START); return 0; } /* Continue handshake. */ diff --git a/lib/handle.c b/lib/handle.c index 88b18e3..4e93144 100644 --- a/lib/handle.c +++ b/lib/handle.c @@ -113,6 +113,7 @@ void nbd_close (struct nbd_handle *h) { struct meta_context *m, *m_next; + size_t i; nbd_internal_set_error_context ("nbd_close"); @@ -130,6 +131,9 @@ nbd_close (struct nbd_handle *h) free (m->name); free (m); } + for (i = 0; i < h->nr_exports; ++i) + free (h->exports[i]); + free (h->exports); free_cmd_list (h->c...

v1 was here: https://www.redhat.com/archives/libguestfs/2019-August/msg00168.html I pushed uncontroversial patches 1-4 v2: - The implementation of OClosure (new patch 1) in Python is fixed. - Patch 2 (old patch 5) is unchanged. - I added a new API for removing debug callbacks. I think this approach has some advantages over using OClosure. - I didn't yet do any work on changing the

Well, I'm not quite done (I still want to get nbdinfo to work on a single nbd connection for all cases when reading the heads of the file is not required), but I'm happy with patches 1-11, and 12-13 show where I'm headed for getting NBD_OPT_INFO to work. Posting now to see if some of the earlier patches are ready to commit while I continue working on the latter half. Eric Blake (13):

...(LIBNBD_CALLBACK_FREE, h->debug_data, NULL, NULL); - h->debug_fn = NULL; + if (h->debug_callback) + h->debug_callback (LIBNBD_CALLBACK_FREE, h->debug_data, NULL, NULL); + h->debug_callback = NULL; free (h->bs_entries); for (m = h->meta_contexts; m != NULL; m = m_next) { diff --git a/lib/internal.h b/lib/internal.h index 90ce6aa..d85fb4b 100644 --- a/lib/internal.h +++ b/lib/internal.h @@ -47,7 +47,6 @@ struct meta_context; struct socket; struct command; -typedef int (*debug_fn) (unsigned, void *, const char *, const char *); struct nbd_handle { /* Lock...

Proposal for new APIs to list exports. The general shape of the API can probably best be seen from the examples/list-exports.c example. Rich.

v1 was here: https://www.redhat.com/archives/libguestfs/2019-July/thread.html#00231 The changes address everything that Eric picked up in his review of the first two patches. I have also added two more patches (4 and 5) which respectively fix docs and change int status -> unsigned status, as discussed. Passes make, check, check-valgrind. Rich.

This implements most of what I wrote here: https://www.redhat.com/archives/libguestfs/2019-July/msg00213.html