search for: lto_codegen_release

...2_t index); > > extern lto_symbol_attributes > lto_module_get_symbol_attribute(lto_module_t mod, uint32_t index); Why uint32_t instead of size_t? > // > // frees all memory for a code generator > // upon return the lto_code_gen_t is no longer valid > // > extern void > lto_codegen_release(lto_code_gen_t); Existing bindings use the term dispose to avoid any possible retain/ release confusion. — Gordon -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20080224/42e7da52/attachment.html>

..._module_get_symbol_attribute(lto_module_t mod, uint32_t index); // // instantiates a code generator // returns NULL if there is an error // extern lto_code_gen_t lto_codegen_create(); // // frees all memory for a code generator // upon return the lto_code_gen_t is no longer valid // extern void lto_codegen_release(lto_code_gen_t); // // add an object module to the set of modules for which code will be generated // returns true on error (check lto_get_error_message() for details) // extern bool lto_codegen_add_module(lto_code_gen_t cg, lto_module_t mod); // // sets what if any format of debug info sho...

...use capital letters and also start with prefix LLVM. e.g. > LLVMLTOFooBar. As we discussed, this is interface is llvm independent. It may even migrate out of include/llvm-c at some point. > 2. Do we need those #include's? We need stddef.h for size_t and stdbool.h for bool. > 4. lto_codegen_release -> lto_codegen_release_memory to be clearer > and more consistent. Renamed to lto_codegen_dispose() > 5. Use C comments /* ... */? Fixed. > 6. Please start comments with capital letters and end sentences > with periods! Or perhaps not since it'll drive Chris nuts. :-) Fixed...

More stylistic nitpicking for consistency sakes... 1. __LTO__ -> LLVM_C_LTO 2. Do we need those #include's? 3. Rather than using underscore in function names, e.g. lt_foo_bar, use capital letters and also start with prefix LLVM. e.g. LLVMLTOFooBar. 4. lto_codegen_release -> lto_codegen_release_memory to be clearer and more consistent. 5. Use C comments /* ... */? 6. Please start comments with capital letters and end sentences with periods! Or perhaps not since it'll drive Chris nuts. :-) Evan On Feb 22, 2008, at 10:34 PM, Nick Kledzik wrote: > Hell...