search for: ls_ucode_gr

...to change the last 'goto free_data' into a 'goto free_img' in order to have a 'logical' goto layout. Then, I changed my mind and added another label to revert the 'kmemdup' a few lines above. I hope I'm correct :) --- drivers/gpu/drm/nouveau/nvkm/subdev/secboot/ls_ucode_gr.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/ls_ucode_gr.c b/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/ls_ucode_gr.c index d1cf02d22db1..1b83e1395c34 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/ls_ucode_gr.c +++...

...d and added another label to revert the 'kmemdup' a > few lines above. > > I hope I'm correct :) Coffee hasn't kicked in fully, but I think this is off. This free() will be called even on success leading to issues. > --- > drivers/gpu/drm/nouveau/nvkm/subdev/secboot/ls_ucode_gr.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/ls_ucode_gr.c b/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/ls_ucode_gr.c > index d1cf02d22db1..1b83e1395c34 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/s...

...1a6 ("drm/nouveau/secboot: abstract LS firmware loading functions") Signed-off-by: Christophe JAILLET <christophe.jaillet at wanadoo.fr> --- v2: update topic only free 'img->sig' if 'ls_ucode_img_build()' fails --- drivers/gpu/drm/nouveau/nvkm/subdev/secboot/ls_ucode_gr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/ls_ucode_gr.c b/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/ls_ucode_gr.c index d1cf02d22db1..1b0c793c0192 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/ls_ucode_gr.c +++...

ucode_header is not used anywhere, so just get rid of it. Signed-off-by: Alexandre Courbot <acourbot at nvidia.com> --- drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 25 +++++++------------------ drm/nouveau/nvkm/subdev/secboot/ls_ucode.h | 2 -- drm/nouveau/nvkm/subdev/secboot/ls_ucode_gr.c | 2 -- 3 files changed, 7 insertions(+), 22 deletions(-) diff --git a/drm/nouveau/nvkm/subdev/secboot/acr_r352.c b/drm/nouveau/nvkm/subdev/secboot/acr_r352.c index b350e107eff0..cdba9ffc5bbe 100644 --- a/drm/nouveau/nvkm/subdev/secboot/acr_r352.c +++ b/drm/nouveau/nvkm/subdev/secboot/acr_r352....

...dev/secboot/acr_r352.c | 102 +++++++++++++--------- drm/nouveau/nvkm/subdev/secboot/acr_r352.h | 119 ++++++++++++++++++++++++++ drm/nouveau/nvkm/subdev/secboot/acr_r361.c | 9 +- drm/nouveau/nvkm/subdev/secboot/ls_ucode.h | 100 +--------------------- drm/nouveau/nvkm/subdev/secboot/ls_ucode_gr.c | 39 ++++----- 5 files changed, 208 insertions(+), 161 deletions(-) diff --git a/drm/nouveau/nvkm/subdev/secboot/acr_r352.c b/drm/nouveau/nvkm/subdev/secboot/acr_r352.c index 4b72371bdbae..6d79fa27ef14 100644 --- a/drm/nouveau/nvkm/subdev/secboot/acr_r352.c +++ b/drm/nouveau/nvkm/subdev/secboo...

....c | 95 +- drm/nouveau/nvkm/subdev/secboot/gm200.c | 1283 +------------------ drm/nouveau/nvkm/subdev/secboot/gm200.h | 43 +- drm/nouveau/nvkm/subdev/secboot/gm20b.c | 125 +-- drm/nouveau/nvkm/subdev/secboot/ls_ucode.h | 151 ++- drm/nouveau/nvkm/subdev/secboot/ls_ucode_gr.c | 158 ++- drm/nouveau/nvkm/subdev/secboot/priv.h | 200 +--- 17 files changed, 1990 insertions(+), 1551 deletions(-) create mode 100644 drm/nouveau/nvkm/subdev/secboot/acr.c create mode 100644 drm/nouveau/nvkm/subdev/secboot/acr.h create mode 100644 drm/nouveau/nvkm/subdev/secboot/ac...

...| 118 ++- drm/nouveau/nvkm/subdev/secboot/gm200.c | 1335 +------------------------ drm/nouveau/nvkm/subdev/secboot/gm200.h | 43 + drm/nouveau/nvkm/subdev/secboot/gm20b.c | 127 +-- drm/nouveau/nvkm/subdev/secboot/ls_ucode.h | 151 +++ drm/nouveau/nvkm/subdev/secboot/ls_ucode_gr.c | 158 +++ drm/nouveau/nvkm/subdev/secboot/priv.h | 199 +--- 22 files changed, 2095 insertions(+), 1647 deletions(-) create mode 100644 drm/nouveau/include/nvkm/core/falcon.h create mode 100644 drm/nouveau/nvkm/core/falcon.c create mode 100644 drm/nouveau/nvkm/subdev/secboot/acr.c c...

...| 118 ++- drm/nouveau/nvkm/subdev/secboot/gm200.c | 1335 +------------------------ drm/nouveau/nvkm/subdev/secboot/gm200.h | 43 + drm/nouveau/nvkm/subdev/secboot/gm20b.c | 127 +-- drm/nouveau/nvkm/subdev/secboot/ls_ucode.h | 151 +++ drm/nouveau/nvkm/subdev/secboot/ls_ucode_gr.c | 158 +++ drm/nouveau/nvkm/subdev/secboot/priv.h | 199 +--- 22 files changed, 2091 insertions(+), 1647 deletions(-) create mode 100644 drm/nouveau/include/nvkm/core/falcon.h create mode 100644 drm/nouveau/nvkm/core/falcon.c create mode 100644 drm/nouveau/nvkm/subdev/secboot/acr.c c...

...6 +- drm/nouveau/nvkm/subdev/secboot/gm200.h | 3 + drm/nouveau/nvkm/subdev/secboot/gm20b.c | 17 +-- drm/nouveau/nvkm/subdev/secboot/gp10b.c | 93 +++++++++++++++++ drm/nouveau/nvkm/subdev/secboot/ls_ucode.h | 12 +-- drm/nouveau/nvkm/subdev/secboot/ls_ucode_gr.c | 10 +- .../nvkm/subdev/secboot/ls_ucode_msgqueue.c | 90 +++++++++++++--- 46 files changed, 749 insertions(+), 145 deletions(-) create mode 100644 drm/nouveau/nvkm/engine/fifo/gp10b.c create mode 100644 drm/nouveau/nvkm/engine/gr/gp10b.c create mode 100644 drm/nouveau/nvkm/subd...

...| 151 +- drm/nouveau/nvkm/subdev/secboot/gm200.c | 1337 +----------------- drm/nouveau/nvkm/subdev/secboot/gm200.h | 43 +- drm/nouveau/nvkm/subdev/secboot/gm20b.c | 128 +-- drm/nouveau/nvkm/subdev/secboot/ls_ucode.h | 153 ++- drm/nouveau/nvkm/subdev/secboot/ls_ucode_gr.c | 158 ++- drm/nouveau/nvkm/subdev/secboot/ls_ucode_pmu.c | 89 +- drm/nouveau/nvkm/subdev/secboot/priv.h | 199 +--- 32 files changed, 3636 insertions(+), 1667 deletions(-) create mode 100644 drm/nouveau/include/nvkm/core/falcon.h create mode 100644 drm/nouveau/nvkm/core/falcon.c...