search for: lrintf

This commit https://github.com/xiph/opus/commit/94b68f341cadd5433a10d346c1c248a641d8be57 Enabled HAVE_LRINTF defined in CMake builds. As later versions of visual studio have LRINTF it got enabled by default due to precedence over SSE in MSVC. The use of lrintf is a lot slower which can easily be seen in the tests >From test result Windows X64 (similar results on X86): LRINTF 4/4 Test #4: test_opus_en...

The following tiny patches make opus and opusfile to use xmm intrinsics for lrintf() with mingw-w64 builds when targetting x64 instead of their default x87 asm. Regards. -- O.S. diff --git a/celt/float_cast.h b/celt/float_cast.h index ed5a39b..b9b8484 100644 --- a/celt/float_cast.h +++ b/celt/float_cast.h @@ -61,7 +61,14 @@ ** the config.h file. */ -#if (HAVE_LRINTF) +...

...k' tests failed. Time one I downloaded the tar.gz for 1.1.4. ./configure gave the following output: ------------------------------------------------------------------------ opus 1.1.4: Automatic configuration OK. Compiler support: C99 var arrays: ................ yes C99 lrintf: .................... yes Use alloca: .................... no (using var arrays) General configuration: Floating point support: ........ yes Fast float approximations: ..... no Fixed point debugging: ......... no Inline Assembly Optimizations: . No inline ASM for...

Hi all, I failed to build libvorbis with ./configure --host=mipsel-linux-uclibc I got the message "no lrintf()". Could you give me help? Best Regards Kevin -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/vorbis/attachments/20090713/48611292/attachment.htm

...e gave the following output: > > > > ------------------------------------------------------------------------ > > opus 1.1.4: Automatic configuration OK. > > > > Compiler support: > > > > C99 var arrays: ................ yes > > C99 lrintf: .................... yes > > Use alloca: .................... no (using var arrays) > > > > General configuration: > > > > Floating point support: ........ yes > > Fast float approximations: ..... no > > Fixed point debugging: ....

...AM_INIT_AUTOMAKE([1.11 foreign dist-bzip2]) + +LT_INIT + +AC_ARG_ENABLE([http], AS_HELP_STRING([--disable-http], [Disable HTTP support])) + +AS_IF([test "x$enable_http" != "xno"], [openssl="openssl"]) +PKG_CHECK_MODULES([DEPS], [ogg opus ]${openssl}) + +AC_SEARCH_LIBS([lrintf], [m]) + +AC_OUTPUT([Makefile]) -- 1.7.12

...-disable-hardening, --enable-fixed-point-debug, --enable-float-approx, --enable-fuzzing, and --enable-check-asm. I tried a cmake build on a non-x86 Linux host but encountered numerous warnings of the form: celt/float_cast.h:129:10: warning: #warning "Don't have the functions lrint() and lrintf ()." [-Wcpp] celt/float_cast.h:130:10: warning: #warning "Replacing these functions with a standard C cast." [-Wcpp] The host does have both the lrint and lrintf functions; the problem is that cmake did not define either HAVE_LRINT or HAVE_LRINTF. - Mark

...with the occasional benign warning message) except for one place, and that is in "float_cast.h" where there is some inline assembly language that gets complied for Windows. Since the Microsoft 64-bit compiler won't allow inline assembly language (and *still* doesn't have "lrintf"), I suggest the following change to use intrinsics for the 64-bit compiler: --- float_cast.h Sat Oct 17 19:51:32 2009 +++ new\float_cast.h Fri Oct 15 12:09:38 2010 @@ -72,8 +72,14 @@ #include <math.h> #define float2int(x) lrint(x) -#elif (defined (WIN32) || defined (_WIN3...

...r.gz for 1.1.4. > > ./configure gave the following output: > > ------------------------------------------------------------------------ > opus 1.1.4: Automatic configuration OK. > > Compiler support: > > C99 var arrays: ................ yes > C99 lrintf: .................... yes > Use alloca: .................... no (using var arrays) > > General configuration: > > Floating point support: ........ yes > Fast float approximations: ..... no > Fixed point debugging: ......... no > Inline Ass...

...; > > > ------------------------------------------------------------------------ > > opus 1.1.4: Automatic configuration OK. > > > > Compiler support: > > > > C99 var arrays: ................ yes > > C99 lrintf: .................... yes > > Use alloca: .................... no (using var arrays) > > > > General configuration: > > > > Floating point support: ........ yes > > Fast float approximations: ..... no > >...

...--enable-assertions --enable-fixed-point-debug config.log results for Raspberry Pi 2: ------------------------------------------------------------------------ opus 1.1.1-beta-38-gfc0276f: Automatic configuration OK. Compiler support: C99 var arrays: ................ yes C99 lrintf: .................... yes Use alloca: .................... no (using var arrays) General configuration: Floating point support: ........ no Fast float approximations: ..... no Fixed point debugging: ......... yes Inline Assembly Optimizations: . ARM (EDSP) (Media...

...able floating-point API]),, + enable_float=yes) + +AS_IF([test "x$enable_float" = "xno"], + [enable_fixed_point=yes + AC_DEFINE([OP_DISABLE_FLOAT_API], [1], [Disable floating-point API]) + ], + [dnl This only has to be tested for if float API is enabled + AC_SEARCH_LIBS([lrintf], [m], [ + AC_DEFINE([OP_HAVE_LRINTF], [1], [Enable use of lrintf function]) + ]) +]) + +AS_IF([test "x$enable_fixed_point" = "xyes"], [ + AC_DEFINE([OP_FIXED_POINT], [1], [Enable fixed-point calculation]) +]) + +CC_ATTRIBUTE_VISIBILITY([default], [ + CC_FLAG_VISIBILITY(...

...able floating-point API]),, + enable_float=yes) + +AS_IF([test "x$enable_float" = "xno"], + [enable_fixed_point=yes + AC_DEFINE([OP_DISABLE_FLOAT_API], [1], [Disable floating-point API]) + ], + [dnl This only has to be tested for if float API is enabled + AC_SEARCH_LIBS([lrintf], [m], [ + AC_DEFINE([OP_HAVE_LRINTF], [1], [Enable use of lrintf function]) + ]) +]) + +AS_IF([test "x$enable_fixed_point" = "xyes"], [ + AC_DEFINE([OP_FIXED_POINT], [1], [Enable fixed-point calculation]) +]) + +CC_ATTRIBUTE_VISIBILITY([default], [ + CC_FLAG_VISIBILITY(...

On Wed, Apr 10, 2019 at 5:30 PM Marcus Asteborg <xnorpx at outlook.com> wrote: > Hi Mark, > > Thanks for the feedback. > > By default CMake is building the static library in debug, to get other > things one has to explicit turn it on. > > Hi, By default CMake uses the "empty" build, which is used in combination with the environment variables CFLAGS and

...LOAT_API], [1], [Disable floating-point API]) + ] +) + +AS_IF([test "x$enable_fixed_point" = "xyes"], + [AC_DEFINE([OP_FIXED_POINT], [1], [Enable fixed-point calculation])], + [dnl This only has to be tested for if float->fixed conversions are required + AC_SEARCH_LIBS([lrintf], [m], [ + AC_DEFINE([OP_HAVE_LRINTF], [1], [Enable use of lrintf function]) + lrintf_notice=" + Library for lrintf() ....... : ${ac_cv_search_lrintf}" + ]) + ] +) + +CC_ATTRIBUTE_VISIBILITY([default], [ + CC_FLAG_VISIBILITY([CFLAGS="${CFLAGS} -fvisibility=hidden"...

Hi everyone, After much waiting, Opus 1.1.1 is finally here. The main changes are: - x86 SSE, SSE2 and SSE4.1 optimizations contributed by Cisco, - MIPS optimizations contributed by Imagination Technologies, - ARM Neon optimizations contributed by Linaro and ARM, - many architecture-independent optimizations, - memory footprint reductions, and - several minor bug fixes. The quality of the

...which > is not in MSVC6's math.h or anywhere else I could find. The operation of lround() is basically the same as lrint(). In src/float_cast.h I have: __inline long int lrint (double flt) { int intgr ; _asm { fld flt fistp intgr } ; return intgr ; } __inline long int lrintf (float flt) { int intgr ; _asm { fld flt fistp intgr } ; return intgr ; } Hope this helps, Erik -- +-----------------------------------------------------------+ Erik de Castro Lopo +-----------------------------------------------------------+ The National Multiple Sclerosis So...

AC_SEARCH_LIBS will give a result of "none required" if the relevant function is available without any special libraries. (This is the case for lrintf on MinGW.) Make sure this special value isn't put verbatim into the pkg-config files, as it would cause the linker to search for files named "none" and "required", and fail. --- configure.ac | 6 +++++- opusfile-uninstalled.pc.in | 2 +- opusfile.pc.in...

AC_SEARCH_LIBS will give a result of "none required" if the relevant function is available without any special libraries. (This is the case for lrintf on MinGW.) Make sure this special value isn't put verbatim into the pkg-config files, as it would cause the linker to search for files named "none" and "required", and fail. --- configure.ac | 6 +++++- opusfile-uninstalled.pc.in | 2 +- opusfile.pc.in...

...e as well as whether it makes an appreciable audible difference. Thanks, -a From OS X: ------------------------------------------------------------------------ opus 1.1.1-beta-38-gfc0276f: Automatic configuration OK. Compiler support: C99 var arrays: ................ yes C99 lrintf: .................... yes Use alloca: .................... no (using var arrays) General configuration: Floating point support: ........ yes Fast float approximations: ..... no Fixed point debugging: ......... no Inline Assembly Optimizations: . No inline ASM for...