search for: lowercasestr

I agree they are broken on all platforms. However, FileManager.cpp already contains an #if WIN32 conditional around the code calling LowercaseString, so you can use MultiByteToWideChar and CharLowerBuffW directly there, and not call the LowercaseString function. I don't think there are any other places where LowercaseString is called with non-ascii data, so you can punt on fixing it for now. On Sep 28, 2011, at 10:11 PM, Nikola Smiljani...

...just enable them and include Windows.h inside and #ifdef section? > > On Thu, Sep 29, 2011 at 7:57 AM, Bryce Cogswell <bryceco at gmail.com> wrote: > I agree they are broken on all platforms. However, FileManager.cpp already contains an #if WIN32 conditional around the code calling LowercaseString, so you can use MultiByteToWideChar and CharLowerBuffW directly there, and not call the LowercaseString function. I don't think there are any other places where LowercaseString is called with non-ascii data, so you can punt on fixing it for now. > > On Sep 28, 2011, at 10:11 PM, Nikol...

...Do I just enable them and include Windows.h inside and #ifdef section? On Thu, Sep 29, 2011 at 7:57 AM, Bryce Cogswell <bryceco at gmail.com> wrote: > I agree they are broken on all platforms. However, FileManager.cpp already > contains an #if WIN32 conditional around the code calling LowercaseString, > so you can use MultiByteToWideChar and CharLowerBuffW directly there, and > not call the LowercaseString function. I don't think there are any other > places where LowercaseString is called with non-ascii data, so you can punt > on fixing it for now. > > On Sep 28, 2011,...

...and include Windows.h inside and #ifdef section? > > On Thu, Sep 29, 2011 at 7:57 AM, Bryce Cogswell <bryceco at gmail.com> wrote: > >> I agree they are broken on all platforms. However, FileManager.cpp already >> contains an #if WIN32 conditional around the code calling LowercaseString, >> so you can use MultiByteToWideChar and CharLowerBuffW directly there, and >> not call the LowercaseString function. I don't think there are any other >> places where LowercaseString is called with non-ascii data, so you can punt >> on fixing it for now. >> &...

...them and include Windows.h inside and #ifdef section? >> >> On Thu, Sep 29, 2011 at 7:57 AM, Bryce Cogswell <bryceco at gmail.com> wrote: >> I agree they are broken on all platforms. However, FileManager.cpp already contains an #if WIN32 conditional around the code calling LowercaseString, so you can use MultiByteToWideChar and CharLowerBuffW directly there, and not call the LowercaseString function. I don't think there are any other places where LowercaseString is called with non-ascii data, so you can punt on fixing it for now. >> >> On Sep 28, 2011, at 10:11 P...

...d #ifdef section? >> >> On Thu, Sep 29, 2011 at 7:57 AM, Bryce Cogswell <bryceco at gmail.com>wrote: >> >>> I agree they are broken on all platforms. However, FileManager.cpp >>> already contains an #if WIN32 conditional around the code calling >>> LowercaseString, so you can use MultiByteToWideChar and CharLowerBuffW >>> directly there, and not call the LowercaseString function. I don't think >>> there are any other places where LowercaseString is called with non-ascii >>> data, so you can punt on fixing it for now. >&gt...

I think the assert you have for _stat64i32 is fine. It is a constant expression so should compile to nothing, and the chance of the definition changing is pretty much zero. LowercaseString appears to be used by ASM printers where the output is expected to be ASCII, and then some WIN32-conditioned code in FileManager.cpp. I hate to say it but you'll probably need to convert the UTF-8 paths to wide char, lower case it using CharLowerBuffW (since it needs to match the casing rule...

.... What do I do? On Tue, Sep 27, 2011 at 5:09 AM, Bryce Cogswell <bryceco at yahoo.com> wrote: > I think the assert you have for _stat64i32 is fine. It is a constant > expression so should compile to nothing, and the chance of the definition > changing is pretty much zero. > > LowercaseString appears to be used by ASM printers where the output is > expected to be ASCII, and then some WIN32-conditioned code in > FileManager.cpp. I hate to say it but you'll probably need to convert the > UTF-8 paths to wide char, lower case it using CharLowerBuffW (since it needs > to m...

...Do I just enable them and include Windows.h inside and #ifdef section? On Thu, Sep 29, 2011 at 7:57 AM, Bryce Cogswell <bryceco at gmail.com> wrote: > I agree they are broken on all platforms. However, FileManager.cpp already > contains an #if WIN32 conditional around the code calling LowercaseString, > so you can use MultiByteToWideChar and CharLowerBuffW directly there, and > not call the LowercaseString function. I don't think there are any other > places where LowercaseString is called with non-ascii data, so you can punt > on fixing it for now. > > On Sep 28, 2011,...

...clude Windows.h inside and #ifdef section? >>> >>> On Thu, Sep 29, 2011 at 7:57 AM, Bryce Cogswell <bryceco at gmail.com> wrote: >>> I agree they are broken on all platforms. However, FileManager.cpp already contains an #if WIN32 conditional around the code calling LowercaseString, so you can use MultiByteToWideChar and CharLowerBuffW directly there, and not call the LowercaseString function. I don't think there are any other places where LowercaseString is called with non-ascii data, so you can punt on fixing it for now. >>> >>> On Sep 28, 2011, at...

...4_t (time_t is a typedef for __time64_t but this depends on one more macro). I check to see that size of these two structures is the same, but is there something more that I could do? I'd also like to use some kind of static assert instead of runtime assert. I've also noticed that function LowercaseString (the same applies to UppercaseString) doesn't work with UTF8 input. It's calling isupper and tolower and these functions can't handle UTF8. This should get a new issue probably? On Wed, Sep 21, 2011 at 1:41 AM, Aaron Ballman <aaron at aaronballman.com>wrote: > On Tue, Sep...

On Tue, Sep 20, 2011 at 4:15 PM, Nikola Smiljanic <popizdeh at gmail.com> wrote: > OK since this approach makes sense I'll shoot with my questions :) > 1. Where should get_utf8_argv go and is the name of this function OK? Right > now the function is inside llvm::sys::fs namespace because I need access to > Windows.h, should I leave it there. I don't think it belongs