search for: logfile_w

...ools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index ad434f0..8ed2d2e 100644 --- a/tools/libxl/libxl_dm.c +++ b/tools/libxl/libxl_dm.c @@ -46,9 +46,11 @@ static const char *qemu_xen_path(libxl__gc *gc) static int libxl__create_qemu_logfile(libxl__gc *gc, char *name) { char *logfile; - int logfile_w; + int rc, logfile_w; + + rc = libxl_create_logfile(CTX, name, &logfile); + if (rc) return rc; - libxl_create_logfile(CTX, name, &logfile); logfile_w = open(logfile, O_WRONLY|O_CREAT|O_APPEND, 0644); free(logfile); -- 2.1.4

The first patch is a leftover from the switch to libxl__create_qemu_logfile, and while there it also handles possible errors when opening /dev/null. The second one is a fix for the issues present in do_daemonize. Thanks, Roger.

...l_dm.c > index ad434f0..8ed2d2e 100644 > --- a/tools/libxl/libxl_dm.c > +++ b/tools/libxl/libxl_dm.c > @@ -46,9 +46,11 @@ static const char *qemu_xen_path(libxl__gc *gc) > static int libxl__create_qemu_logfile(libxl__gc *gc, char *name) > { > char *logfile; > - int logfile_w; > + int rc, logfile_w; > + > + rc = libxl_create_logfile(CTX, name, &logfile); > + if (rc) return rc; > > - libxl_create_logfile(CTX, name, &logfile); > logfile_w = open(logfile, O_WRONLY|O_CREAT|O_APPEND, 0644); > free(logfile); > >...

Package: xen-utils-4.4 Version: 4.4.1-9 Severity: normal # /usr/lib/xen-4.4/bin/xl create -c /etc/xen/katana Parsing config from /etc/xen/katana libxl: error: libxl_utils.c:217:logrename: failed to rotate logfile - could not rename /var/log/xen/qemu-dm-katana.log.6 to /var/log/xen/qemu-dm-katana.log.7: Permission denied Segmentation fault The above happens repeatably when I run xl on a system

* Introduce new variants of the logging functions which include errno values (converted using strerror) in the messages passed to the application''s logging callback. * Use the new errno-including logging functions everywhere where appropriate. In general, xc_... functions return errno values or 0; xs_... functions return 0 or -1 (or some such) setting errno. * When

Anthony PERARD (3): libxl_qmp: Use GC instead of CTX as parameter for _initialize. Provide dm_vnc() as a in libxl helper. libxl: Set VNC password through QMP tools/libxl/libxl_create.c | 2 +- tools/libxl/libxl_dm.c | 32 ++++++++++++++---------- tools/libxl/libxl_internal.h | 7 ++++- tools/libxl/libxl_qmp.c | 55 ++++++++++++++++++++++++++++++----------- 4 files

...(libxl_ctx *ctx, @@ -1487,6 +1580,7 @@ int libxl_create_device_model(libxl_ctx libxl_device_nic *vifs, int num_vifs, libxl_device_model_starting **starting_r) { + libxl_gc gc = LIBXL_INIT_GC(ctx); char *path, *logfile; int logfile_w, null; int rc; @@ -1501,48 +1595,55 @@ int libxl_create_device_model(libxl_ctx libxl_device_vkb vkb; libxl_vfb_and_vkb_from_device_model_info(ctx, info, &vfb, &vkb); - return libxl_create_stubdom(ctx, info, disks, num_disks, vifs, num_vifs, &vfb, &vk...