search for: logang

On 2019-06-13 3:43 a.m., Christoph Hellwig wrote: > Passing the actual typed structure leads to more understandable code > vs the actual references. Ha, ok, I originally suggested this to Dan when he introduced the callback[1]. Reviewed-by: Logan Gunthorpe <logang at deltatee.com> Logan [1] https://lore.kernel.org/lkml/8f0cae82-130f-8a64-cfbd-fda5fd76bb79 at deltatee.com/T/#u

On Thu, Jun 13, 2019 at 1:12 PM Logan Gunthorpe <logang at deltatee.com> wrote: > > > > On 2019-06-13 3:43 a.m., Christoph Hellwig wrote: > > Passing the actual typed structure leads to more understandable code > > vs the actual references. > > Ha, ok, I originally suggested this to Dan when he introduced the > callba...

On 2019-06-13 2:21 p.m., Dan Williams wrote: > On Thu, Jun 13, 2019 at 1:18 PM Logan Gunthorpe <logang at deltatee.com> wrote: >> >> >> >> On 2019-06-13 12:27 p.m., Dan Williams wrote: >>> On Thu, Jun 13, 2019 at 2:43 AM Christoph Hellwig <hch at lst.de> wrote: >>>> >>>> Hi Dan, Jérôme and Jason, >>>> >>>> belo...

On Thu, 13 Jun 2019 14:24:20 -0600 Logan Gunthorpe <logang at deltatee.com> wrote: > > > On 2019-06-13 2:21 p.m., Dan Williams wrote: > > On Thu, Jun 13, 2019 at 1:18 PM Logan Gunthorpe <logang at deltatee.com> wrote: > >> > >> > >> > >> On 2019-06-13 12:27 p.m., Dan Williams wrote: > >&g...

On Thu, 27 Aug 2020 at 22:36, Logan Gunthorpe <logang at deltatee.com> wrote: > > > > On 2020-08-23 6:04 p.m., Tom Murphy wrote: > > I have added a check for the sg_dma_len == 0 : > > """ > > } __sgt_iter(struct scatterlist *sgl, bool dma) { > > struct sgt_iter s = { .sgp = sgl }; > &gt...

On 2019-06-13 12:27 p.m., Dan Williams wrote: > On Thu, Jun 13, 2019 at 2:43 AM Christoph Hellwig <hch at lst.de> wrote: >> >> Hi Dan, Jérôme and Jason, >> >> below is a series that cleans up the dev_pagemap interface so that >> it is more easily usable, which removes the need to wrap it in hmm >> and thus allowing to kill a lot of code >>

...ately and it would be a shame for the work to go to waste. [0] https://github.com/torvalds/linux/blob/d012a7190fc1fd72ed48911e77ca97ba4521bccd/drivers/gpu/drm/i915/i915_scatterlist.h#L28 [1] https://linuxplumbersconf.org/event/7/contributions/846/ On Fri, 29 May 2020 at 22:21, Logan Gunthorpe <logang at deltatee.com> wrote: > > > > On 2020-05-29 3:11 p.m., Marek Szyprowski wrote: > > Patches are pending: > > https://lore.kernel.org/linux-iommu/20200513132114.6046-1-m.szyprowski at samsung.com/T/ > > Cool, nice! Though, I still don't think that fixes the issu...

On Thu, Jun 13, 2019 at 1:18 PM Logan Gunthorpe <logang at deltatee.com> wrote: > > > > On 2019-06-13 12:27 p.m., Dan Williams wrote: > > On Thu, Jun 13, 2019 at 2:43 AM Christoph Hellwig <hch at lst.de> wrote: > >> > >> Hi Dan, Jérôme and Jason, > >> > >> below is a series that cleans up th...

...pagemap is a growing too many callbacks. Move them into a > separate ops structure so that they are not duplicated for multiple > instances, and an attacker can't easily overwrite them. > > Signed-off-by: Christoph Hellwig <hch at lst.de> > Reviewed-by: Logan Gunthorpe <logang at deltatee.com> > Reviewed-by: Jason Gunthorpe <jgg at mellanox.com> > --- > drivers/dax/device.c | 11 ++++++---- > drivers/dax/pmem/core.c | 2 +- > drivers/nvdimm/pmem.c | 19 +++++++++------- > drivers/pci/p2pdma.c |...

...an'.) > > > > I do not want to mess up the build system any more. > > > > Given that this issue will be solved in a cleaner way sooner or later, > > let's revert the in-kernel workarounds, and wait for GCC 9. > > > > Reported-by: Logan Gunthorpe <logang at deltatee.com> # distcc > > Reported-by: Sedat Dilek <sedat.dilek at gmail.com> # deb/rpm package > > It is customary to cc those who report an issue. OK. > The distcc issue has already been resolved both in distcc Precisely, the fix-up was submitted, but not pulled yet...

The dev_pagemap is a growing too many callbacks. Move them into a separate ops structure so that they are not duplicated for multiple instances, and an attacker can't easily overwrite them. Signed-off-by: Christoph Hellwig <hch at lst.de> Reviewed-by: Logan Gunthorpe <logang at deltatee.com> Reviewed-by: Jason Gunthorpe <jgg at mellanox.com> --- drivers/dax/device.c | 11 ++++++---- drivers/dax/pmem/core.c | 2 +- drivers/nvdimm/pmem.c | 19 +++++++++------- drivers/pci/p2pdma.c | 9 +++++--- include/linux/mem...

Hi Dan, Jérôme and Jason, below is a series that cleans up the dev_pagemap interface so that it is more easily usable, which removes the need to wrap it in hmm and thus allowing to kill a lot of code Note: this series is on top of the rdma/hmm branch + the dev_pagemap releas fix series from Dan that went into 5.2-rc5. Git tree: git://git.infradead.org/users/hch/misc.git

...fundamentally, we cannot build external modules after 'make clean'.) I do not want to mess up the build system any more. Given that this issue will be solved in a cleaner way sooner or later, let's revert the in-kernel workarounds, and wait for GCC 9. Reported-by: Logan Gunthorpe <logang at deltatee.com> # distcc Reported-by: Sedat Dilek <sedat.dilek at gmail.com> # deb/rpm package Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com> Cc: Nadav Amit <namit at vmware.com> Cc: Segher Boessenkool <segher at kernel.crashing.org> --- Please consid...

Hi Dan, Jérôme and Jason, below is a series that cleans up the dev_pagemap interface so that it is more easily usable, which removes the need to wrap it in hmm and thus allowing to kill a lot of code Note: this series is on top of Linux 5.2-rc5 and has some minor conflicts with the hmm tree that are easy to resolve. Diffstat summary: 32 files changed, 361 insertions(+), 1012 deletions(-) Git

..., we cannot build external modules after 'make clean') Patching around the build system would make the code even uglier. Given that this issue will be solved in a cleaner way sooner or later, let's revert the in-kernel workarounds, and wait for GCC 9. Reported-by: Logan Gunthorpe <logang at deltatee.com> # distcc Reported-by: Sedat Dilek <sedat.dilek at gmail.com> # debian/rpm package Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com> Cc: Nadav Amit <namit at vmware.com> Cc: Segher Boessenkool <segher at kernel.crashing.org> --- Please con...

..., we cannot build external modules after 'make clean') Patching around the build system would make the code even uglier. Given that this issue will be solved in a cleaner way sooner or later, let's revert the in-kernel workarounds, and wait for GCC 9. Reported-by: Logan Gunthorpe <logang at deltatee.com> # distcc Reported-by: Sedat Dilek <sedat.dilek at gmail.com> # debian/rpm package Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com> Cc: Nadav Amit <namit at vmware.com> Cc: Segher Boessenkool <segher at kernel.crashing.org> --- Please con...

Hi Dan, Jérôme and Jason, below is a series that cleans up the dev_pagemap interface so that it is more easily usable, which removes the need to wrap it in hmm and thus allowing to kill a lot of code Diffstat: 22 files changed, 245 insertions(+), 802 deletions(-) Git tree: git://git.infradead.org/users/hch/misc.git hmm-devmem-cleanup Gitweb:

On 2019-06-17 6:27 a.m., Christoph Hellwig wrote: > diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c > index a98126ad9c3a..e083567d26ef 100644 > --- a/drivers/pci/p2pdma.c > +++ b/drivers/pci/p2pdma.c > @@ -100,7 +100,7 @@ static void pci_p2pdma_percpu_cleanup(struct percpu_ref *ref) > struct p2pdma_pagemap *p2p_pgmap = to_p2p_pgmap(ref); > >