search for: log_user

----- Original Message ----- > Fix the warning: [-Werror=-Wframe-larger-than=] > > drivers/vhost/vhost.c: In function log_used: > drivers/vhost/vhost.c:1906:1: > warning: the frame size of 1040 bytes is larger than 1024 bytes > > Signed-off-by: Li Wang <li.wang at windriver.com> > --- > drivers/vhost/vhost.c | 14 ++++++++++---- > 1 file changed, 10

On 2020/9/15 ??2:08, Li Wang wrote: > Fix the warning: [-Werror=-Wframe-larger-than=] > > drivers/vhost/vhost.c: In function log_used: > drivers/vhost/vhost.c:1906:1: > warning: the frame size of 1040 bytes is larger than 1024 bytes > > Signed-off-by: Li Wang <li.wang at windriver.com> > --- > drivers/vhost/vhost.c | 2 +- > drivers/vhost/vhost.h | 1 + >

When fail, translate_desc() returns negative value, otherwise the number of iovs. So we should fail when the return value is negative instead of a blindly check against zero. Detected by CoverityScan, CID# 1442593: Control flow issues (DEADCODE) Fixes: cc5e71075947 ("vhost: log dirty page correctly") Acked-by: Michael S. Tsirkin <mst at redhat.com> Reported-by: Stephen

When fail, translate_desc() returns negative value, otherwise the number of iovs. So we should fail when the return value is negative instead of a blindly check against zero. Reported-by: Stephen Hemminger <stephen at networkplumber.org> Fixes: cc5e71075947 ("vhost: log dirty page correctly") Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/vhost/vhost.c | 2

When fail, translate_desc() returns negative value, otherwise the number of iovs. So we should fail when the return value is negative instead of a blindly check against zero. Reported-by: Stephen Hemminger <stephen at networkplumber.org> Fixes: cc5e71075947 ("vhost: log dirty page correctly") Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/vhost/vhost.c | 2

From: Jason Wang <jasowang at redhat.com> Date: Fri, 15 Feb 2019 15:53:24 +0800 > When fail, translate_desc() returns negative value, otherwise the > number of iovs. So we should fail when the return value is negative > instead of a blindly check against zero. > > Reported-by: Stephen Hemminger <stephen at networkplumber.org> > Fixes: cc5e71075947 ("vhost: log

On Fri, 15 Feb 2019 15:53:24 +0800 Jason Wang <jasowang at redhat.com> wrote: > When fail, translate_desc() returns negative value, otherwise the > number of iovs. So we should fail when the return value is negative > instead of a blindly check against zero. > > Reported-by: Stephen Hemminger <stephen at networkplumber.org> > Fixes: cc5e71075947 ("vhost: log

On Wed, Dec 12, 2018 at 06:08:19PM +0800, Jason Wang wrote: > Vhost dirty page logging API is designed to sync through GPA. But we > try to log GIOVA when device IOTLB is enabled. This is wrong and may > lead to missing data after migration. > > To solve this issue, when logging with device IOTLB enabled, we will: > > 1) reuse the device IOTLB translation result of

On Wed, Dec 12, 2018 at 06:08:19PM +0800, Jason Wang wrote: > Vhost dirty page logging API is designed to sync through GPA. But we > try to log GIOVA when device IOTLB is enabled. This is wrong and may > lead to missing data after migration. > > To solve this issue, when logging with device IOTLB enabled, we will: > > 1) reuse the device IOTLB translation result of

...thought users of rsync would probably have experience writing such cron scripts. ------------------------------------------------------------------------------------ #!/bin/sh # \ exec expect "$0" ${1+"$@"} # # -n dry run // --progress -v for testing # -z for file compression log_user 0 spawn time /usr/bin/rsync -anrultvPz --delete --exclude="vu/" -e /usr/bin/ssh --timeout 30 root@apache:/home/jhill/ /usr/local/bkup/home/jhill expect "password: " send "secret\n" log_user 1 interact --------------------------------------------------------------...

Vhost dirty page logging API is designed to sync through GPA. But we try to log GIOVA when device IOTLB is enabled. This is wrong and may lead to missing data after migration. To solve this issue, when logging with device IOTLB enabled, we will: 1) reuse the device IOTLB translation result of GIOVA->HVA mapping to get HVA, for writable descriptor, get HVA through iovec. For used ring

Vhost dirty page logging API is designed to sync through GPA. But we try to log GIOVA when device IOTLB is enabled. This is wrong and may lead to missing data after migration. To solve this issue, when logging with device IOTLB enabled, we will: 1) reuse the device IOTLB translation result of GIOVA->HVA mapping to get HVA, for writable descriptor, get HVA through iovec. For used ring

On Fri, 11 May 2018 09:14:24 +0200 Marco Gaiarin via samba <samba at lists.samba.org> wrote: > Mandi! Rowland Penny via samba > In chel di` si favelave... > > > You would replace 'FACILITY' with one of the facilities shown in > > 'man syslog' e.g. full_audit:facility = LOG_AUTH > > OK, done. But samba (as stated in previous email) still reply:

Hi: This series tries to fix various issues of vhost: - Patch 1 adds a missing write barrier between used idx updating and logging. - Patch 2-3 brings back the protection of device IOTLB through vq mutex, this fixes possible use after free in device IOTLB entries. - Patch 4-7 fixes the diry page logging when device IOTLB is enabled. We should done through GPA instead of GIOVA, this was

Hi: This series tries to fix various issues of vhost: - Patch 1 adds a missing write barrier between used idx updating and logging. - Patch 2-3 brings back the protection of device IOTLB through vq mutex, this fixes possible use after free in device IOTLB entries. - Patch 4-7 fixes the diry page logging when device IOTLB is enabled. We should done through GPA instead of GIOVA, this was

On 2018/12/12 ??10:32, Michael S. Tsirkin wrote: > On Wed, Dec 12, 2018 at 06:08:19PM +0800, Jason Wang wrote: >> Vhost dirty page logging API is designed to sync through GPA. But we >> try to log GIOVA when device IOTLB is enabled. This is wrong and may >> lead to missing data after migration. >> >> To solve this issue, when logging with device IOTLB enabled, we

...{1 .1} proc send {ignore arg} { sleep .1 exp_send -s -- $arg } } set timeout -1 set username [lindex $argv 0] send_user "new" system stty echo expect_user -re "(.*)\n" set password $expect_out(1,string) send_user "OK\n" log_user 0 spawn $ssh $ypserver expect "<change to fit your system> :" send -- "passwd $username\r" expect -exact "passwd $username\r New password: " send -- "$password\r" expect -exact "\r Re-enter new password: " send -- "$password\r" expec...

On Thu, Dec 13, 2018 at 10:39:41AM +0800, Jason Wang wrote: > > On 2018/12/12 ??10:32, Michael S. Tsirkin wrote: > > On Wed, Dec 12, 2018 at 06:08:19PM +0800, Jason Wang wrote: > > > Vhost dirty page logging API is designed to sync through GPA. But we > > > try to log GIOVA when device IOTLB is enabled. This is wrong and may > > > lead to missing data after

On Thu, Dec 13, 2018 at 10:39:41AM +0800, Jason Wang wrote: > > On 2018/12/12 ??10:32, Michael S. Tsirkin wrote: > > On Wed, Dec 12, 2018 at 06:08:19PM +0800, Jason Wang wrote: > > > Vhost dirty page logging API is designed to sync through GPA. But we > > > try to log GIOVA when device IOTLB is enabled. This is wrong and may > > > lead to missing data after

From: Colin Ian King <colin.king at canonical.com> Currently the loop that calls log_write_hva on each iovec is never executed because of an incorrect error check on the return from the call to translate_desc. The check should be checking for a -ve error return and because it makes no sense to iterate over zero items, the checks should also check for zero too. Detected by CoverityScan,