search for: log_to

...[--run CMD] [-s|--single] [--selinux-label LABEL] diff --git a/server/internal.h b/server/internal.h index 9314e8ff..5da3e3c3 100644 --- a/server/internal.h +++ b/server/internal.h @@ -90,6 +90,7 @@ extern const char *exportname; extern bool foreground; extern const char *ipaddr; extern enum log_to log_to; +extern unsigned mask_handshake; extern bool newstyle; extern bool no_sr; extern const char *port; diff --git a/server/options.h b/server/options.h index a69f413a..c74e0b8b 100644 --- a/server/options.h +++ b/server/options.h @@ -46,6 +46,7 @@ enum { FILTER_OPTION, LOG_OPTION, L...

...with-parent] [--filter FILTER ...] [-f|--foreground] [-g|--group GROUP] [-i|--ipaddr IPADDR] [--log stderr|syslog|null] diff --git a/server/internal.h b/server/internal.h index 4911a49b..1acbbb06 100644 --- a/server/internal.h +++ b/server/internal.h @@ -108,6 +108,7 @@ enum log_to { }; extern struct debug_flag *debug_flags; +extern const char *export_name; extern bool foreground; extern const char *ipaddr; extern enum log_to log_to; diff --git a/server/captive.c b/server/captive.c index 53b82782..a8947d7c 100644 --- a/server/captive.c +++ b/server/captive.c @@ -61,6 +6...

...me; /* plugin or filter name */ char *flag; /* flag name */ int value; /* value of flag */ - int used; /* if flag was successfully set */ + bool used; /* if flag was successfully set */ }; enum log_to { @@ -94,22 +94,22 @@ extern struct debug_flag *debug_flags; extern const char *exportname; extern const char *ipaddr; extern enum log_to log_to; -extern int newstyle; +extern bool newstyle; extern const char *port; -extern int readonly; +extern bool readonly; extern const char *selinux_label;...

This is similar to the recent --no-sr option - it's a change that is unlikely to ever be used except by someone testing whether a client is compliant to the protocol, but in that niche case, it can be quite handy (it's a lot nicer to be able to purposefully cripple a server from the command line than from a one-off compile, when testing if a client's fallback for a spec-compliant but

...with-parent] [--filter FILTER ...] [-f|--foreground] [-g|--group GROUP] [-i|--ipaddr IPADDR] [--log stderr|syslog|null] diff --git a/server/internal.h b/server/internal.h index 68c53366..ebc63a52 100644 --- a/server/internal.h +++ b/server/internal.h @@ -108,7 +108,6 @@ enum log_to { }; extern struct debug_flag *debug_flags; -extern const char *exportname; extern bool foreground; extern const char *ipaddr; extern enum log_to log_to; diff --git a/server/captive.c b/server/captive.c index f8107604..aa717870 100644 --- a/server/captive.c +++ b/server/captive.c @@ -61,8 +6...

...-port PORT] [-r|--readonly] [--run CMD] [-s|--single] [--selinux-label LABEL] diff --git a/server/internal.h b/server/internal.h index 29a89606..22e13b6d 100644 --- a/server/internal.h +++ b/server/internal.h @@ -88,6 +88,7 @@ extern bool foreground; extern const char *ipaddr; extern enum log_to log_to; extern bool newstyle; +extern bool no_sr; extern const char *port; extern bool readonly; extern const char *run; diff --git a/server/options.h b/server/options.h index 0be19f15..a69f413a 100644 --- a/server/options.h +++ b/server/options.h @@ -1,5 +1,5 @@ /* nbdkit - * Copyright (C) 20...

libFuzzer is Clang's fuzzer, and alternative to using AFL: https://llvm.org/docs/LibFuzzer.html I implemented an alternative method of fuzzing for libnbd earlier today and it's pretty simple: https://github.com/libguestfs/libnbd/commit/c19a6fbae9a21a7d4693418706c59e81ed256875 However it's considerably more difficult to use libFuzzer with non-library code -- in this case nbdkit.

...quot; -/* Call the right nbdkit_verror function depending on log_sink. +/* Call the right log_*_verror function depending on log_sink. * Note: preserves the previous value of errno. */ void -nbdkit_verror (const char *fs, va_list args) +log_verror (const char *fs, va_list args) { switch (log_to) { case LOG_TO_DEFAULT: @@ -65,9 +65,14 @@ nbdkit_verror (const char *fs, va_list args) } } -/* Wrapper around nbdkit_verror. - * Note: preserves the previous value of errno. - */ +/* Note: preserves the previous value of errno. */ +void +nbdkit_verror (const char *fs, va_list args) +{ +...

While working on can_FOO caching, at one point I got confused by whether 'readonly' meant the global set by -r or a local passed to .open(). A quick attempt to compile with -Wshadow found several other confusing points; this series gets us to the point that we can add -Wshadow to builds with --enable-gcc-warnings. Eric Blake (10): server: Avoid -Wshadow warnings guestfs: Avoid

This is the previous 5/9 patch posted earlier today, split into reviewable chunks. This passes bisection with -x 'make && make check', but I didn't work very hard on the commit messages, so I refer you back to the original patch to explain how it works: https://www.redhat.com/archives/libguestfs/2020-March/msg00248.html Rich.

This creates libnbdkit.so as discussed in the following thread: https://www.redhat.com/archives/libguestfs/2020-March/thread.html#00203 test-delay-shutdown.sh fails for unclear reasons. This series starts by reverting "tests: Don't strand hung nbdkit processes" which is because several other tests fail randomly unless I revert this patch. I didn't investigate this yet so it