search for: locinfo

Thanks. More questions :-) /// Information about how the value is assigned. - LocInfo HTP : 7; + LocInfo HTP : 6; Do you know why this change is needed? Are we running out of bits? - NeededStackSize = 4; - break; - case MVT::i64: - case MVT::f64: - if (firstGPR < 3) - NeededGPRs = 2; - else if (firstGPR == 3) { - NeededGPRs = 1; - NeededStackSize...

On Mon, Feb 16, 2009 at 11:00 AM, Evan Cheng <evan.cheng at apple.com> wrote: > /// Information about how the value is assigned. > - LocInfo HTP : 7; > + LocInfo HTP : 6; > > Do you know why this change is needed? Are we running out of bits? HTP was't using all of these bits. I needed the hasCustom bit to come from somewhere unless we wanted to grow this struct, so I grabbed a bit from HTP. > - NeededStackSize =...

...me with the test cases actually attached. deep On Tue, Feb 17, 2009 at 4:41 PM, Sandeep Patel <deeppatel1987 at gmail.com> wrote: > On Mon, Feb 16, 2009 at 11:00 AM, Evan Cheng <evan.cheng at apple.com> wrote: >> /// Information about how the value is assigned. >> - LocInfo HTP : 7; >> + LocInfo HTP : 6; >> >> Do you know why this change is needed? Are we running out of bits? > > HTP was't using all of these bits. I needed the hasCustom bit to come > from somewhere unless we wanted to grow this struct, so I grabbed a > bit from HTP....

...> deep > > On Tue, Feb 17, 2009 at 4:41 PM, Sandeep Patel <deeppatel1987 at gmail.com > > wrote: >> On Mon, Feb 16, 2009 at 11:00 AM, Evan Cheng <evan.cheng at apple.com> >> wrote: >>> /// Information about how the value is assigned. >>> - LocInfo HTP : 7; >>> + LocInfo HTP : 6; >>> >>> Do you know why this change is needed? Are we running out of bits? >> >> HTP was't using all of these bits. I needed the hasCustom bit to come >> from somewhere unless we wanted to grow this struct, so I grabb...

...Val, possibly > updating > +/// all args to reflect changes and indicates if it handled it. It > must set > +/// isCustom if it handles the arg and returns true. > +typedef bool CCCustomFn(unsigned &ValNo, MVT &ValVT, > + MVT &LocVT, CCValAssign::LocInfo &LocInfo, > + ISD::ArgFlagsTy &ArgFlags, CCState &State, > + bool &result); > > Is it necessary to return two bools (the second is returned by > reference in 'result')? I am confused about the semantics of 'res...

...t; On Tue, Feb 17, 2009 at 4:41 PM, Sandeep Patel <deeppatel1987 at gmail.com >> > wrote: >>> On Mon, Feb 16, 2009 at 11:00 AM, Evan Cheng <evan.cheng at apple.com> >>> wrote: >>>>   /// Information about how the value is assigned. >>>> -  LocInfo HTP : 7; >>>> +  LocInfo HTP : 6; >>>> >>>> Do you know why this change is needed? Are we running out of bits? >>> >>> HTP was't using all of these bits. I needed the hasCustom bit to come >>> from somewhere unless we wanted to grow...

...on assigns a location for Val, possibly updating +/// all args to reflect changes and indicates if it handled it. It must set +/// isCustom if it handles the arg and returns true. +typedef bool CCCustomFn(unsigned &ValNo, MVT &ValVT, + MVT &LocVT, CCValAssign::LocInfo &LocInfo, + ISD::ArgFlagsTy &ArgFlags, CCState &State, + bool &result); Is "result" what you refer to as "isCustom" in the comments? Sorry, I am still confused. You mean it could return true but set 'result...

...s and indicates if it handled it. It >>>>> must set >>>>> +/// isCustom if it handles the arg and returns true. >>>>> +typedef bool CCCustomFn(unsigned &ValNo, MVT &ValVT, >>>>> + MVT &LocVT, CCValAssign::LocInfo &LocInfo, >>>>> + ISD::ArgFlagsTy &ArgFlags, CCState &State, >>>>> + bool &result); >>>>> >>>>> Is "result" what you refer to as "isCustom" in the comments?...

...if it handled it. It >>>>>> must set >>>>>> +/// isCustom if it handles the arg and returns true. >>>>>> +typedef bool CCCustomFn(unsigned &ValNo, MVT &ValVT, >>>>>> + MVT &LocVT, CCValAssign::LocInfo &LocInfo, >>>>>> + ISD::ArgFlagsTy &ArgFlags, CCState &State, >>>>>> + bool &result); >>>>>> >>>>>> Is "result" what you refer to as "isCustom" i...

...l1987 at gmail.com >>>>> wrote: >>>>> On Mon, Feb 16, 2009 at 11:00 AM, Evan Cheng >>>>> <evan.cheng at apple.com> >>>>> wrote: >>>>>> /// Information about how the value is assigned. >>>>>> - LocInfo HTP : 7; >>>>>> + LocInfo HTP : 6; >>>>>> >>>>>> Do you know why this change is needed? Are we running out of >>>>>> bits? >>>>> >>>>> HTP was't using all of these bits. I needed the hasCust...

...Val, possibly > updating > +/// all args to reflect changes and indicates if it handled it. It > must set > +/// isCustom if it handles the arg and returns true. > +typedef bool CCCustomFn(unsigned &ValNo, MVT &ValVT, > + MVT &LocVT, CCValAssign::LocInfo &LocInfo, > + ISD::ArgFlagsTy &ArgFlags, CCState &State, > + bool &result); > > Is "result" what you refer to as "isCustom" in the comments? > > Sorry, I am still confused. You mean it could return t...

...009 at 4:41 PM, Sandeep Patel <deeppatel1987 at gmail.com >>> > wrote: >>>> On Mon, Feb 16, 2009 at 11:00 AM, Evan Cheng <evan.cheng at apple.com> >>>> wrote: >>>>>   /// Information about how the value is assigned. >>>>> -  LocInfo HTP : 7; >>>>> +  LocInfo HTP : 6; >>>>> >>>>> Do you know why this change is needed? Are we running out of bits? >>>> >>>> HTP was't using all of these bits. I needed the hasCustom bit to come >>>> from somewhere...

...>>>>> wrote: >>>>>> On Mon, Feb 16, 2009 at 11:00 AM, Evan Cheng <evan.cheng at apple.com >>>>>> > >>>>>> wrote: >>>>>>> /// Information about how the value is assigned. >>>>>>> - LocInfo HTP : 7; >>>>>>> + LocInfo HTP : 6; >>>>>>> >>>>>>> Do you know why this change is needed? Are we running out of >>>>>>> bits? >>>>>> >>>>>> HTP was't using all of these bi...

...c succeeded >> or failed: > > I like the second solution better. It seems rather cumbersome to embed > multi-line c++ code in td files. > > Evan >> >> >> typedef bool CCCustomFn(unsigned ValNo, MVT ValVT, >> MVT LocVT, CCValAssign::LocInfo LocInfo, >> ISD::ArgFlagsTy ArgFlags, CCState &State, >> bool &result); >> _______________________________________________ >> LLVM Developers mailing list >> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >> http://lists.cs....

...+/// all args to reflect changes and indicates if it handled it. It >>> must set >>> +/// isCustom if it handles the arg and returns true. >>> +typedef bool CCCustomFn(unsigned &ValNo, MVT &ValVT, >>> + MVT &LocVT, CCValAssign::LocInfo &LocInfo, >>> + ISD::ArgFlagsTy &ArgFlags, CCState &State, >>> + bool &result); >>> >>> Is "result" what you refer to as "isCustom" in the comments? >>> >>> Sorry,...

...pdating >> +/// all args to reflect changes and indicates if it handled it. It >> must set >> +/// isCustom if it handles the arg and returns true. >> +typedef bool CCCustomFn(unsigned &ValNo, MVT &ValVT, >> + MVT &LocVT, CCValAssign::LocInfo &LocInfo, >> + ISD::ArgFlagsTy &ArgFlags, CCState &State, >> + bool &result); >> >> Is "result" what you refer to as "isCustom" in the comments? >> >> Sorry, I am still confused. Yo...

...on assigns a location for Val, possibly updating +/// all args to reflect changes and indicates if it handled it. It must set +/// isCustom if it handles the arg and returns true. +typedef bool CCCustomFn(unsigned &ValNo, MVT &ValVT, + MVT &LocVT, CCValAssign::LocInfo &LocInfo, + ISD::ArgFlagsTy &ArgFlags, CCState &State, + bool &result); Is it necessary to return two bools (the second is returned by reference in 'result')? I am confused about the semantics of 'result'. Also, a nit...

...o reflect changes and indicates if it handled it. It >>>> must set >>>> +/// isCustom if it handles the arg and returns true. >>>> +typedef bool CCCustomFn(unsigned &ValNo, MVT &ValVT, >>>> + MVT &LocVT, CCValAssign::LocInfo &LocInfo, >>>> + ISD::ArgFlagsTy &ArgFlags, CCState &State, >>>> + bool &result); >>>> >>>> Is "result" what you refer to as "isCustom" in the comments? >>>>...

...Custom<"MyCustomLoweringFunc">> the function signature for such functions will have to return two results: if the CC processing is finished and if it the func succeeded or failed: typedef bool CCCustomFn(unsigned ValNo, MVT ValVT, MVT LocVT, CCValAssign::LocInfo LocInfo, ISD::ArgFlagsTy ArgFlags, CCState &State, bool &result);

...ich also motivated me to revisit code which I've always felt was a bit clunky. Calling convention lowering in LLVM is typically handled by functions conforming to the CCAssignFn typedef: typedef bool CCAssignFn(unsigned ValNo, MVT ValVT, MVT LocVT, CCValAssign::LocInfo LocInfo, ISD::ArgFlagsTy ArgFlags, CCState &State); Notably, these functions are called after type legalisation so an argument/ret has been split to legal value types. In some cases you want more information than is available through this function interface, which l...