search for: localmountpoint

"localmountpoint" parameter is allocated in JNI before calling mount_local and freed afterward. But guestfs handle keeps reference to passed "localmountpoint" argument and will try to use and free it in umount_local which leads to a crash because an attempt to access already freed memory region. It...

"localmountpoint" parameter is allocated in JNI before calling mount_local and freed afterward. But guestfs handle keeps reference to passed "localmountpoint" parameter and will try to access it in umount_local and free after mount_local_run caller thread ends which leads to a crash (an attempt to a...

The 'localmountpoint' variable in the handle is available only when building with FUSE support, so guard it in a proper #ifdef block. Fixes commit 296370fb86e96eec095d86faf6de8f532395ea54. --- lib/handle.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/handle.c b/lib/handle.c index bc45d29b2..a47aaafab...

This version doesn't crash or cause hung processes or stuck mountpoints, so that's an improvement. Rich.

This patch is just for review. It enables FUSE support in the API via two new calls, 'guestfs_mount_local' and 'guestfs_umount_local'. FUSE turns out to be very easy to deadlock (necessitating that the machine be rebooted). Running the test from the third patch is usually an effective way to demonstrate this. However I have not yet managed to produce a simple reproducer that

...her automatically or manually) in the guestfs handle. --- lib/fuse.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/fuse.c b/lib/fuse.c index 0180f8f..98bbc8d 100644 --- a/lib/fuse.c +++ b/lib/fuse.c @@ -989,8 +989,7 @@ guestfs_impl_mount_local (guestfs_h *g, const char *localmountpoint, return -1; /* Create the FUSE 'args'. */ - /* XXX we don't have a program name */ - if (fuse_opt_add_arg (&args, "guestfs_mount_local") == -1) { + if (fuse_opt_add_arg (&args, g->program) == -1) { arg_error: perrorf (g, _("fuse_opt_add_arg...

This changes the proposed API slightly. Previously 'mount-local' generating a 'mounted' event when the filesystem was ready, and from the 'mounted' event you had to effectively do a fork. Now, 'mount-local' just initializes the mountpoint and you have to call 'mount-local-run' to enter the FUSE main loop. Between these calls you can do a fork or whatever

[These two patches are for discussion only] Allow FUSE support to be used directly through the API. This is the second commit. In order to make this usable from guestfish, we have to also bind the events API in guestfish. This is the first commit. Rich.

...her automatically or manually) in the guestfs handle. --- src/fuse.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/fuse.c b/src/fuse.c index 0180f8f..98bbc8d 100644 --- a/src/fuse.c +++ b/src/fuse.c @@ -989,8 +989,7 @@ guestfs_impl_mount_local (guestfs_h *g, const char *localmountpoint, return -1; /* Create the FUSE 'args'. */ - /* XXX we don't have a program name */ - if (fuse_opt_add_arg (&args, "guestfs_mount_local") == -1) { + if (fuse_opt_add_arg (&args, g->program) == -1) { arg_error: perrorf (g, _("fuse_opt_add_arg...

...handle. > --- > lib/fuse.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/lib/fuse.c b/lib/fuse.c > index 0180f8f..98bbc8d 100644 > --- a/lib/fuse.c > +++ b/lib/fuse.c > @@ -989,8 +989,7 @@ guestfs_impl_mount_local (guestfs_h *g, const char *localmountpoint, > return -1; > > /* Create the FUSE 'args'. */ > - /* XXX we don't have a program name */ > - if (fuse_opt_add_arg (&args, "guestfs_mount_local") == -1) { > + if (fuse_opt_add_arg (&args, g->program) == -1) { > arg_error: >...

Inspired by libvirt's virCommand* internal mini-library, this adds some internal APIs for running commands. The first patch contains the new APIs. The subsequent patches change various parts of the library over to use it. Rich.

Hi everyone, lately I've been getting familiar with library and working on slight re-layering of the library. It's about having locking layer in public API and tracing one layer below that (let's call it __t_ layer. I'm not very good at making up names, so this is temporary:) ). Then making sure that all generated public stuff call __t_ layer and all other internal stuff

...\ debug (g, \ - "%s: %s (" fs ")\n", \ + "%s: %s (" fs ")", \ g->localmountpoint, __func__, ## __VA_ARGS__); \ } -- 1.8.3.1

...ote: '%s' is still mounted. Use 'guestunmount %s' to clean up."), + error (g, _("you must call 'guestfs_mount' first to mount a filesystem on '/'.\nNote: '%s' is still mounted. Use 'guestunmount %s' to clean up"), g->localmountpoint, g->localmountpoint); return -1; } diff --git a/src/launch-libvirt.c b/src/launch-libvirt.c index 706ae38..5a3159d 100644 --- a/src/launch-libvirt.c +++ b/src/launch-libvirt.c @@ -1404,14 +1404,14 @@ construct_libvirt_xml_disk (guestfs_h *g, if (STREQ (format, "unknown&quot...

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.

...\ - if (g->ml_debug_calls) { \ - debug (g, \ - "%s: %s (" fs ")", \ - g->localmountpoint, __func__, ## __VA_ARGS__); \ +#define DEBUG_CALL(fs,...) \ + if (g->ml_debug_calls) { \ + debug (g, \ + "%s: %s (" fs ")", \ + g->localmountpoint, __func__, ## __VA_ARGS__); \ } -#define RETURN_ERRNO...

Result of earlier copy and paste. --- align/scan.c | 35 ++++++++++--------- cat/cat.c | 39 +++++++++++---------- cat/filesystems.c | 69 +++++++++++++++++++------------------- cat/log.c | 35 ++++++++++--------- cat/ls.c | 61 +++++++++++++++++---------------- df/main.c | 43 ++++++++++++------------ diff/diff.c | 67

...stem on '/'.\nNote: '%s' is still mounted. Use 'guestunmount %s' to clean up."), + error (g, _("you must call ‘guestfs_mount’ first to mount a filesystem on '/'.\nNote: ‘%s’ is still mounted. Use ‘guestunmount %s’ to clean up."), g->localmountpoint, g->localmountpoint); return -1; } diff --git a/lib/guestfs.pod b/lib/guestfs.pod index bbc64892b..544ca2a3c 100644 --- a/lib/guestfs.pod +++ b/lib/guestfs.pod @@ -208,7 +208,7 @@ Linux LVM2 logical volumes you could refer to those instead (eg. F</dev/VG/LV>). Note that these are...

Hi Rich, This series includes patches to make `make syntax-check` pass. Some of the fix require change to maint.mk, but the file is not in git repo. Is it intended? Thanks! Hu Tao (13): syntax-check: dirty hack to pass bindtextdomain check syntax-check: fix error_message_period check syntax-check: fix makefile_at_at_check syntax-check: fix prohibit_assert_without_use check

...quot;]; config_only = true; shortdesc = "add the disk(s) from a named libvirt domain"; longdesc = "\ @@ -827,7 +827,7 @@ C<guestfs_add_drive_opts>." }; { defaults with name = "mount_local"; added = (1, 17, 22); - style = RErr, [String "localmountpoint"], [OBool "readonly"; OString "options"; OInt "cachetimeout"; OBool "debugcalls"]; + style = RErr, [String (PlainString, "localmountpoint")], [OBool "readonly"; OString "options"; OInt "cachetimeout"; OBool &quo...