Displaying 3 results from an estimated 3 matches for "llvmuseiterator".
2009 Oct 11
3
[LLVMdev] Some additions to the C bindings
...the
> patch
Hi Kenneth,
Thanks for working on this. I have some additional comments:
+/** See the llvm::Use class. */
+typedef struct LLVMOpaqueUse *LLVMUseRef;
My understanding is that this actually conceptually corresponds to
use_iterator, not Use. Please name this something like
LLVMUseIterator. Also, please document this, not just referring to
llvm::Use.
+int LLVMHasInitializer(LLVMValueRef GlobalVar);
LLVMValueRef LLVMGetInitializer(LLVMValueRef GlobalVar);
Isn't LLVMHasInitializer just LLVMGetInitializer(x) != 0?
Otherwise, looks ok to me,
-Chris
2009 Oct 07
0
[LLVMdev] Some additions to the C bindings
On Tue, Oct 6, 2009 at 2:13 PM, Kenneth Uildriks <kennethuil at gmail.com> wrote:
> My front-end is sync'd with the trunk now, and working well, but it
> required some additional functions exposed in the C bindings. I
> hereby submit them for review and approval for inclusion in the trunk.
>
LLVMGetAttribute had a bug in it. Here's the revised version of the patch
2009 Oct 06
3
[LLVMdev] Some additions to the C bindings
My front-end is sync'd with the trunk now, and working well, but it
required some additional functions exposed in the C bindings. I
hereby submit them for review and approval for inclusion in the trunk.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cbindings.patch
Type: application/octet-stream
Size: 7269 bytes
Desc: not available
URL: