search for: llvmsetinstrparamalign

...Conv(LLVMValueRef Instr, unsigned CC); > unsigned LLVMGetInstructionCallConv(LLVMValueRef Instr); > +void LLVMInstrAddParamAttr(LLVMValueRef Instr, unsigned index, > LLVMParamAttr); > +void LLVMInstrRemoveParamAttr(LLVMValueRef Instr, unsigned index, > LLVMParamAttr); > +void LLVMSetInstrParamAlignment(LLVMValueRef Instr, unsigned index, > unsigned align); Could you swap LLVMSetInstrParamAlignment around to be consistent with the others in sentence formation (LLVM<Verb>Instr<Noun>)? > Index: lib/VMCore/Core.cpp > =====================================================...

...nsigned CC); > > unsigned LLVMGetInstructionCallConv(LLVMValueRef Instr); > > +void LLVMInstrAddParamAttr(LLVMValueRef Instr, unsigned index, > > LLVMParamAttr); > > +void LLVMInstrRemoveParamAttr(LLVMValueRef Instr, unsigned index, > > LLVMParamAttr); > > +void LLVMSetInstrParamAlignment(LLVMValueRef Instr, unsigned index, > > unsigned align); > > Could you swap LLVMSetInstrParamAlignment around to be consistent with > the others in sentence formation (LLVM<Verb>Instr<Noun>)? > > > Index: lib/VMCore/Core.cpp > > ========================...

...ser can know from the > header file what type of LLVMValueRefs are permissible. > - InstrSetAlignment is a confusing name. (I'd think it refers to the > alignment for a load or store, with no additional context.) It > specifically refers to byval parameter alignment, so perhaps > LLVMSetInstrParamAlignment or LLVMSetInstrByValParamAlignment. > - How to set alignment on an Argument*? > > Finally, how to set or clear attributes like noreturn on a Function*? > This might indicate that we should use an indexed API for call sites > as well. > > > Index: lib/VMCore/Core.cpp >...

On Apr 26, 2008, at 19:09, Anders Johnsen wrote: > On Sunday 27 April 2008 00:48:00 Gordon Henriksen wrote: > >> On Apr 26, 2008, at 17:41, Anders Johnsen wrote: >> >> >>> +void LLVMSetInstrParamAlignment(LLVMValueRef Instr, unsigned index, >>> unsigned align) { >>> + CallSite Call = CallSite(unwrap<Instruction>(Instr)); >>> + Call.setParamAttrs( >>> + Call.getParamAttrs().addAttr(index, >>> + ParamAttr::constructAlignmentFromInt(ali...

...the only way a user can know from the header file what type of LLVMValueRefs are permissible. - InstrSetAlignment is a confusing name. (I'd think it refers to the alignment for a load or store, with no additional context.) It specifically refers to byval parameter alignment, so perhaps LLVMSetInstrParamAlignment or LLVMSetInstrByValParamAlignment. - How to set alignment on an Argument*? Finally, how to set or clear attributes like noreturn on a Function*? This might indicate that we should use an indexed API for call sites as well. > Index: lib/VMCore/Core.cpp > ============================...

Hi.. Updated so you now set alignment through LLVMInstrSetAlignment. Anders Johnsen -------------- next part -------------- A non-text attachment was scrubbed... Name: ParamAttr.patch Type: text/x-diff Size: 7420 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20080424/cb72b4bb/attachment.patch>

On Sunday 27 April 2008 01:33:31 Gordon Henriksen wrote: > On Apr 26, 2008, at 19:09, Anders Johnsen wrote: > > On Sunday 27 April 2008 00:48:00 Gordon Henriksen wrote: > >> On Apr 26, 2008, at 17:41, Anders Johnsen wrote: > >>> +void LLVMSetInstrParamAlignment(LLVMValueRef Instr, unsigned index, > >>> unsigned align) { > >>> + CallSite Call = CallSite(unwrap<Instruction>(Instr)); > >>> + Call.setParamAttrs( > >>> + Call.getParamAttrs().addAttr(index, > >>> + ParamAttr::cons...