search for: llvminstrremoveparamattr

...ruct LLVMOpaqueParamAttrs *LLVMParamAttrs; > > Please delete this, as it is unused. > > > +void LLVMInstrAddParamAttr(LLVMValueRef, unsigned index, > > LLVMParamAttr); > > +void LLVMInstrSetAlignment(LLVMValueRef, unsigned index, unsigned > > align); > > +void LLVMInstrRemoveParamAttr(LLVMValueRef, unsigned index, > > LLVMParamAttr); > > +void LLVMAddParamAttr(LLVMValueRef, LLVMParamAttr); > > +void LLVMRemoveParamAttr(LLVMValueRef, LLVMParamAttr); > > - Please put these with the things they operate on. The *Instr* > variants should go with the other f...

...MBuilderRef; > > +typedef struct LLVMOpaqueParamAttrs *LLVMParamAttrs; Please delete this, as it is unused. > +void LLVMInstrAddParamAttr(LLVMValueRef, unsigned index, > LLVMParamAttr); > +void LLVMInstrSetAlignment(LLVMValueRef, unsigned index, unsigned > align); > +void LLVMInstrRemoveParamAttr(LLVMValueRef, unsigned index, > LLVMParamAttr); > +void LLVMAddParamAttr(LLVMValueRef, LLVMParamAttr); > +void LLVMRemoveParamAttr(LLVMValueRef, LLVMParamAttr); - Please put these with the things they operate on. The *Instr* variants should go with the other functions that take call s...

Hi.. Updated so you now set alignment through LLVMInstrSetAlignment. Anders Johnsen -------------- next part -------------- A non-text attachment was scrubbed... Name: ParamAttr.patch Type: text/x-diff Size: 7420 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20080424/cb72b4bb/attachment.patch>

...> @@ -441,6 +459,9 @@ > /* Operations on call sites */ > void LLVMSetInstructionCallConv(LLVMValueRef Instr, unsigned CC); > unsigned LLVMGetInstructionCallConv(LLVMValueRef Instr); > +void LLVMInstrAddParamAttr(LLVMValueRef Instr, unsigned index, > LLVMParamAttr); > +void LLVMInstrRemoveParamAttr(LLVMValueRef Instr, unsigned index, > LLVMParamAttr); > +void LLVMSetInstrParamAlignment(LLVMValueRef Instr, unsigned index, > unsigned align); Could you swap LLVMSetInstrParamAlignment around to be consistent with the others in sentence formation (LLVM<Verb>Instr<Noun>)...

...; > /* Operations on call sites */ > > void LLVMSetInstructionCallConv(LLVMValueRef Instr, unsigned CC); > > unsigned LLVMGetInstructionCallConv(LLVMValueRef Instr); > > +void LLVMInstrAddParamAttr(LLVMValueRef Instr, unsigned index, > > LLVMParamAttr); > > +void LLVMInstrRemoveParamAttr(LLVMValueRef Instr, unsigned index, > > LLVMParamAttr); > > +void LLVMSetInstrParamAlignment(LLVMValueRef Instr, unsigned index, > > unsigned align); > > Could you swap LLVMSetInstrParamAlignment around to be consistent with > the others in sentence formation (LLVM<Ver...