search for: llvm_regex

.... For the time being, though, I'd say lets drop them until some client actually cares. >> This won't work on Windows as stands (Regex.h == regex.h), but I think we should >> just keep regex.h private which solves the problem (still nice to rename it to >> avoid confusion, llvm_regex.h would be consistent). >> > > Ok, I'll try to make it private. Ok! I have one more request; since the implementation ends up being spread into a number of files, could we prefix them with something so they stand out inside the Support directory? Thanks again! - Daniel

...ets drop > them until some client actually cares. > Dropped. > >>> This won't work on Windows as stands (Regex.h == regex.h), but I think we should >>> just keep regex.h private which solves the problem (still nice to rename it to >>> avoid confusion, llvm_regex.h would be consistent). >>> >>> >> Ok, I'll try to make it private. >> > > Ok! > > I have one more request; since the implementation ends up being spread > into a number of files, could we prefix them with something so they > stand out...

...bool AllowBeginOfLine = true, bool AllowEndOfLine = true); > > >> + bool match_sub(const char *string, llvm_regmatch_t pmatch[], >> + unsigned nmatch, bool notbol=false, bool noteol=false); >> > > > >> + private: >> + llvm_regex_t preg; >> + }; >> +} >> > > >> diff --git a/include/llvm/Support/regex.h b/include/llvm/Support/regex.h >> > > This won't work on Windows as stands (Regex.h == regex.h), but I think we should > just keep regex.h private which solves th...

...g, SmallVectorImpl<StringRef> *Matches, bool AllowBeginOfLine = true, bool AllowEndOfLine = true); > + bool match_sub(const char *string, llvm_regmatch_t pmatch[], > + unsigned nmatch, bool notbol=false, bool noteol=false); > + private: > + llvm_regex_t preg; > + }; > +} > diff --git a/include/llvm/Support/regex.h b/include/llvm/Support/regex.h This won't work on Windows as stands (Regex.h == regex.h), but I think we should just keep regex.h private which solves the problem (still nice to rename it to avoid confusion, llvm_regex....

...l provide consistent behaviour and >> execution time, the system one will not. > > Hi Edwin, > > Can you propose the openbsd implementation as a patch to lib/support? > > -Chris Attached is a proposed patch. The Regex class is a fairly simple wrapper around the llvm_regcomp/llvm_regexec functions, maybe the interface could be improved, right now I just focused on getting it to work. Also the OpenBSD implementation has some extensions (see docs/regex.7), if they are useful those can be added to the Regex class also. A summary of changes from OpenBSD version: - rename functions...

...pport/regexec.c:130: /Volumes/Data/Users/ddunbar/llvm/lib/Support/regengine.inc: In function 'lbackref': /Volumes/Data/Users/ddunbar/llvm/lib/Support/regengine.inc:665: warning: control reaches end of non-void function /Volumes/Data/Users/ddunbar/llvm/lib/Support/regexec.c: In function 'llvm_regexec': /Volumes/Data/Users/ddunbar/llvm/lib/Support/regexec.c:157: warning: comparison between signed and unsigned -- And one in the unittest: -- /Volumes/Data/Users/ddunbar/llvm/utils/unittest/googletest/include/gtest/gtest.h: In function 'testing::AssertionResult testing::internal::CmpHelpe...

On Aug 23, 2009, at 11:59 PM, Török Edwin wrote: > If LLVM is going to have an integrated regex library I suggest using > it > regardless if the platform has one. > The LLVM integrated regex library will provide consistent behaviour > and > execution time, the system one will not. Hi Edwin, Can you propose the openbsd implementation as a patch to lib/support? -Chris