Displaying 3 results from an estimated 3 matches for "llvm_enable_debug".
2017 Apr 10
2
Question about LLVM Building Error with "-DLLVM_ENABLE_DUMP" and "RelWithDebInfo"
...ader and need the #if there
> - A similar problem arises in cases where the dump function was declared virtual and ends up in the vtable
> - If you ask me then we shouldn't have LLVM_ENABLE_DUMP and just rely on NDEBUG to keep things simple... (We're in this strange state anyway where LLVM_ENABLE_DEBUG isn't even exposed as a cmake option).
> - Either way, putting LLVM_ENABLE_DUMP into config.h would make the status-quo more consistent.
Using the config.h instead of the NDEBUG makes it robust against client using NDEBUG differently from what LLVM was built with. This seems really better t...
2017 Apr 10
2
Question about LLVM Building Error with "-DLLVM_ENABLE_DUMP" and "RelWithDebInfo"
...em arises in cases where the dump function was
>>> declared virtual and ends up in the vtable
>>> - If you ask me then we shouldn't have LLVM_ENABLE_DUMP and just
>>> rely on NDEBUG to keep things simple... (We're in this strange state
>>> anyway where LLVM_ENABLE_DEBUG isn't even exposed as a cmake option).
>>> - Either way, putting LLVM_ENABLE_DUMP into config.h would make the
>>> status-quo more consistent.
>>
>> Using the config.h instead of the NDEBUG makes it robust against
>> client using NDEBUG differently from wha...
2017 Apr 10
5
Question about LLVM Building Error with "-DLLVM_ENABLE_DUMP" and "RelWithDebInfo"
Presently several of our headers have definitions like:
#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
void dump() const;
#endif
Would it make sense to modify the build system to define LLVM_ENABLE_DUMP in config.h on debug builds?
Then we could wrap dump methods just based on LLVM_ENABLE_DUMP instead of two variables.
-Chris
> On Apr 10, 2017, at 1:34 PM, Robinson, Paul via llvm-dev