search for: llvm_dump_method

...) functions in LLVM. Normalize > them (this should just consistently implement the things discussed in > http://lists.llvm.org/pipermail/cfe-dev/2014-January/034323.html > > For reference: > - Public headers should just declare the dump() method but not use > LLVM_DUMP_METHOD or #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) > - The definition of a dump method should look like this: > #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) > LLVM_DUMP_METHOD void MyClass::dump() { > // print stuff to dbgs()... > } > #en...

...> > them (this should just consistently implement the things discussed in > > http://lists.llvm.org/pipermail/cfe-dev/2014-January/034323.html > > > > For reference: > > - Public headers should just declare the dump() method but not use > > LLVM_DUMP_METHOD or #if !defined(NDEBUG) || > defined(LLVM_ENABLE_DUMP) > > - The definition of a dump method should look like this: > > #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) > > LLVM_DUMP_METHOD void MyClass::dump() { > > // print stuff to dbgs()... &g...

...ust consistently implement the things discussed >> > in >> > http://lists.llvm.org/pipermail/cfe-dev/2014-January/034323.html >> > >> > For reference: >> > - Public headers should just declare the dump() method but not use >> > LLVM_DUMP_METHOD or #if !defined(NDEBUG) || >> > defined(LLVM_ENABLE_DUMP) >> > - The definition of a dump method should look like this: >> > #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) >> > LLVM_DUMP_METHOD void MyClass::dump() { >> > // pr...

...us variants of defining dump() functions in LLVM. Normalize them (this should just consistently implement the things discussed in http://lists.llvm.org/pipermail/cfe-dev/2014-January/034323.html For reference: - Public headers should just declare the dump() method but not use LLVM_DUMP_METHOD or #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) - The definition of a dump method should look like this: #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) LLVM_DUMP_METHOD void MyClass::dump() { // print stuff to dbgs()... } #endif git-svn-id: https://l...

Hi Martin On 25 September 2017 at 21:13, Martin J. O'Riordan <MartinO at theheart.ie> wrote: > Yes, if it is in the interface it would make more sense to have a null implementation at the very least. In my out-of-tree target, I also removed them from the interface if the build was for Release to ensure that I got compile-time errors to reveal other places I might have otherwise

...things discussed > >> > in > >> > http://lists.llvm.org/pipermail/cfe-dev/2014-January/034323.html > >> > > >> > For reference: > >> > - Public headers should just declare the dump() method but not use > >> > LLVM_DUMP_METHOD or #if !defined(NDEBUG) || > >> > defined(LLVM_ENABLE_DUMP) > >> > - The definition of a dump method should look like this: > >> > #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) > >> > LLVM_DUMP_METHOD void MyClass::dump() { > &g...

...ex 7e1e1864356..8d3636432aa 100644 > --- a/utils/TableGen/InfoByHwMode.cpp > +++ b/utils/TableGen/InfoByHwMode.cpp > @@ -98,14 +98,16 @@ void ValueTypeByHwMode::writeToStream(raw_ostream > &OS) const { > OS << '}'; > } > > +#ifdef LLVM_ENABLE_DUMP > LLVM_DUMP_METHOD > void ValueTypeByHwMode::dump() const { > dbgs() << *this << '\n'; > } > +#endif > > ValueTypeByHwMode llvm::getValueTypeByHwMode(Record *Rec, > const CodeGenHwModes &CGH) { > -#ifndef NDEBUG > +...

Is anyone else seeing this bootstrap failure on current svn trunk? [ 6%] Linking CXX executable ../../bin/llvm-tblgen cd /sw/src/fink.build/llvm60-6.0.0-1/build/stage1/utils/TableGen && /sw/bin/cmake -E cmake_link_script CMakeFiles/llvm-tblgen.dir/link.txt --verbose=1 /sw/src/fink.build/llvm60-6.0.0-1/opt-bin/ccclang++ -fno-common -fPIC -fvisibility-inlines-hidden -Werror=date-time

...oByHwMode.cpp >>> +++ b/utils/TableGen/InfoByHwMode.cpp >>> @@ -98,14 +98,16 @@ void ValueTypeByHwMode::writeToStream(raw_ostream >>> &OS) const { >>> OS << '}'; >>> } >>> >>> +#ifdef LLVM_ENABLE_DUMP >>> LLVM_DUMP_METHOD >>> void ValueTypeByHwMode::dump() const { >>> dbgs() << *this << '\n'; >>> } >>> +#endif >>> >>> ValueTypeByHwMode llvm::getValueTypeByHwMode(Record *Rec, >>> cons...

...oByHwMode.cpp >>> +++ b/utils/TableGen/InfoByHwMode.cpp >>> @@ -98,14 +98,16 @@ void ValueTypeByHwMode::writeToStream(raw_ostream >>> &OS) const { >>> OS << '}'; >>> } >>> >>> +#ifdef LLVM_ENABLE_DUMP >>> LLVM_DUMP_METHOD >>> void ValueTypeByHwMode::dump() const { >>> dbgs() << *this << '\n'; >>> } >>> +#endif >>> >>> ValueTypeByHwMode llvm::getValueTypeByHwMode(Record *Rec, >>> cons...

...p >> >>> @@ -98,14 +98,16 @@ void ValueTypeByHwMode::writeToStream(raw_ostream >> >>> &OS) const { >> >>> OS << '}'; >> >>> } >> >>> >> >>> +#ifdef LLVM_ENABLE_DUMP >> >>> LLVM_DUMP_METHOD >> >>> void ValueTypeByHwMode::dump() const { >> >>> dbgs() << *this << '\n'; >> >>> } >> >>> +#endif >> >>> >> >>> ValueTypeByHwMode llvm::getValueTypeByHwMode(Record *Rec, >>...

...Mode.cpp >>>>> @@ -98,14 +98,16 @@ void ValueTypeByHwMode::writeToStream(raw_ostream >>>>> &OS) const { >>>>> OS << '}'; >>>>> } >>>>> >>>>> +#ifdef LLVM_ENABLE_DUMP >>>>> LLVM_DUMP_METHOD >>>>> void ValueTypeByHwMode::dump() const { >>>>> dbgs() << *this << '\n'; >>>>> } >>>>> +#endif >>>>> >>>>> ValueTypeByHwMode llvm::getValueTypeByHwMode(Record *Rec, >>>&gt...

...TypeByHwMode::writeToStream(raw_ostream >> >> >>> &OS) const { >> >> >>> OS << '}'; >> >> >>> } >> >> >>> >> >> >>> +#ifdef LLVM_ENABLE_DUMP >> >> >>> LLVM_DUMP_METHOD >> >> >>> void ValueTypeByHwMode::dump() const { >> >> >>> dbgs() << *this << '\n'; >> >> >>> } >> >> >>> +#endif >> >> >>> >> >> >>> ValueTypeByHw...

...@ void ValueTypeByHwMode::writeToStream(raw_ostream >>>>>>> &OS) const { >>>>>>> OS << '}'; >>>>>>> } >>>>>>> >>>>>>> +#ifdef LLVM_ENABLE_DUMP >>>>>>> LLVM_DUMP_METHOD >>>>>>> void ValueTypeByHwMode::dump() const { >>>>>>> dbgs() << *this << '\n'; >>>>>>> } >>>>>>> +#endif >>>>>>> >>>>>>> ValueTypeByHwMode llvm::g...

...gt; >> >>> &OS) const { >> >> >> >>> OS << '}'; >> >> >> >>> } >> >> >> >>> >> >> >> >>> +#ifdef LLVM_ENABLE_DUMP >> >> >> >>> LLVM_DUMP_METHOD >> >> >> >>> void ValueTypeByHwMode::dump() const { >> >> >> >>> dbgs() << *this << '\n'; >> >> >> >>> } >> >> >> >>> +#endif >> >> >> >>>...