search for: llvm_always_inline

...at lists.llvm.org> wrote: >> >> Hi, >> I would like to propose, based on a previous discussion on llvm-dev, >> the following change. >> https://reviews.llvm.org/D56337 >> >> The main motivation for annotating member functions of ADT clases with >> LLVM_ALWAYS_INLINE was that of speeding up `check-llvm` at `-O0`. >> Turns out this significantly degrades the debuggability of fundamental >> classes in llvm itself, e.g. StringRef or SmallVector. > > > It seems that the issue is not a problem with the inlining these functions but rather that t...

Hi, I would like to propose, based on a previous discussion on llvm-dev, the following change. https://reviews.llvm.org/D56337 The main motivation for annotating member functions of ADT clases with LLVM_ALWAYS_INLINE was that of speeding up `check-llvm` at `-O0`. Turns out this significantly degrades the debuggability of fundamental classes in llvm itself, e.g. StringRef or SmallVector. After discussing we agreed that it's reasonable to drop LLVM_ALWYAS_INLINE from ADT classes member functions and add a...

.... MSBuild) then it gets a little weird, I don't remember exactly how. --paulr From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of Mehdi AMINI via llvm-dev Sent: Saturday, January 05, 2019 7:42 PM To: Paweł Bylica; Chris Bieneman Cc: LLVM Dev Subject: Re: [llvm-dev] Removing LLVM_ALWAYS_INLINE from ADT classes On Fri, Jan 4, 2019 at 3:52 PM Paweł Bylica via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote: On Sat, Jan 5, 2019 at 12:38 AM Duncan P. N. Exon Smith via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org&gt...

On Sun, 6 Jan 2019 at 00:42, Mehdi AMINI via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > > > On Fri, Jan 4, 2019 at 3:52 PM Paweł Bylica via llvm-dev <llvm-dev at lists.llvm.org> wrote: >> >> On Sat, Jan 5, 2019 at 12:38 AM Duncan P. N. Exon Smith via llvm-dev <llvm-dev at lists.llvm.org> wrote: >>> >>> This makes sense to me.

On Thu, Jan 17, 2019 at 2:17 PM David Greene <dag at cray.com> wrote: > Alex Bradbury via llvm-dev <llvm-dev at lists.llvm.org> writes: > > > As mentioned elsewhere in the thread, building TableGen with > > Debug+Asserts isn't only useful for people who want to debug TableGen > > itself. It's useful for anybody modifying .td as many checks on .td >

...; >> I would like to propose, based on a previous discussion on llvm-dev, > > >> the following change. > > >> https://reviews.llvm.org/D56337 > > >> > > >> The main motivation for annotating member functions of ADT clases with > > >> LLVM_ALWAYS_INLINE was that of speeding up `check-llvm` at `-O0`. > > >> Turns out this significantly degrades the debuggability of fundamental > > >> classes in llvm itself, e.g. StringRef or SmallVector. > > > > > > > > > It seems that the issue is not a problem w...

...s.llvm.org> wrote: > > > > Hi, > > I would like to propose, based on a previous discussion on llvm-dev, > > the following change. > > https://reviews.llvm.org/D56337 > > > > The main motivation for annotating member functions of ADT clases with > > LLVM_ALWAYS_INLINE was that of speeding up `check-llvm` at `-O0`. > > Turns out this significantly degrades the debuggability of fundamental > > classes in llvm itself, e.g. StringRef or SmallVector. > > > > After discussing we agreed that it's reasonable to drop > > LLVM_ALWYAS_INL...

On Mon, 14 Jan 2019 at 23:11, Nico Weber via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > I agree that shelling out to `cmake --build` as a build step is pretty ugly. > > It seems kind of simpler to me to just always build Support and TableGen with O3 always, even in debug builds. Most people don't debug code in Support and TableGen, and there could be a disable switch

...; > -----Original Message----- > > From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of > Alex > > Bradbury via llvm-dev > > Sent: Monday, January 07, 2019 11:33 AM > > To: Mehdi AMINI > > Cc: LLVM Dev > > Subject: Re: [llvm-dev] Removing LLVM_ALWAYS_INLINE from ADT classes > > > > On Sun, 6 Jan 2019 at 00:42, Mehdi AMINI via llvm-dev > > <llvm-dev at lists.llvm.org> wrote: > > > > > > > > > > > > On Fri, Jan 4, 2019 at 3:52 PM Paweł Bylica via llvm-dev <llvm- > > dev at lists.llvm.o...

...rom: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org <mailto:llvm-dev-bounces at lists.llvm.org>] On Behalf Of Alex > > Bradbury via llvm-dev > > Sent: Monday, January 07, 2019 11:33 AM > > To: Mehdi AMINI > > Cc: LLVM Dev > > Subject: Re: [llvm-dev] Removing LLVM_ALWAYS_INLINE from ADT classes > > > > On Sun, 6 Jan 2019 at 00:42, Mehdi AMINI via llvm-dev > > <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: > > > > > > > > > > > > On Fri, Jan 4, 2019 at 3:52 PM Paweł Bylica via llvm-...

On Tue, Jan 15, 2019 at 3:44 PM Davide Italiano <davide at freebsd.org> wrote: > On Mon, Jan 14, 2019 at 1:52 PM Reid Kleckner <rnk at google.com> wrote: > > > > On Fri, Jan 11, 2019 at 11:18 AM Davide Italiano via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> > >> After yet another round of discussions, the plan is that of trying not

On Fri, Jan 11, 2019 at 11:18 AM Davide Italiano via llvm-dev < llvm-dev at lists.llvm.org> wrote: > After yet another round of discussions, the plan is that of trying not > to slap another attribute on the members, instead going for making > OPTIMIZED_TLBGEN the default and removing always_inline. > I'll do some testing locally (for the Ninja and the Xcode build >