search for: ll_virtual_anch

...trying to compile LLVM & Clang with -Weverything (disabling any errors that seem like more noise/less interesting). One warning I've recently hit a few instances of is -Wweak-vtable which is, in fact, an explicitly documented LLVM coding standard ( http://llvm.org/docs/CodingStandards.html#ll_virtual_anch ). Some instances of this have been easy to fix (see attached patch - if it looks good to anyone I'll check that in) but a particular set of them have been a little more problematic. If you take a look at CommandLine.h/CommandLine.cpp you'll see some code that basically amounts to this: h...

...>> with -Weverything (disabling any errors that seem like more noise/less >> interesting). One warning I've recently hit a few instances of is >> -Wweak-vtable which is, in fact, an explicitly documented LLVM coding >> standard ( http://llvm.org/docs/CodingStandards.html#ll_virtual_anch >> ). Some instances of this have been easy to fix (see attached patch - >> if it looks good to anyone I'll check that in) but a particular set of >> them have been a little more problematic. > > Nice, please commit your patch.  I don't know about explicit instantiat...

...h -Weverything (disabling any errors that seem like more noise/less >>> interesting). One warning I've recently hit a few instances of is >>> -Wweak-vtable which is, in fact, an explicitly documented LLVM coding >>> standard ( http://llvm.org/docs/CodingStandards.html#ll_virtual_anch >>> ). Some instances of this have been easy to fix (see attached patch - >>> if it looks good to anyone I'll check that in) but a particular set of >>> them have been a little more problematic. >> >> Nice, please commit your patch. I don't know abou...

...LVM & Clang > with -Weverything (disabling any errors that seem like more noise/less > interesting). One warning I've recently hit a few instances of is > -Wweak-vtable which is, in fact, an explicitly documented LLVM coding > standard ( http://llvm.org/docs/CodingStandards.html#ll_virtual_anch > ). Some instances of this have been easy to fix (see attached patch - > if it looks good to anyone I'll check that in) but a particular set of > them have been a little more problematic. Nice, please commit your patch. I don't know about explicit instantiations though, maybe a...

...6:50 PM, David Blaikie <dblaikie at gmail.com> wrote: > Author: dblaikie > Date: Mon Dec 19 20:50:00 2011 > New Revision: 146960 > > URL: http://llvm.org/viewvc/llvm-project?rev=146960&view=rev > Log: > Unweaken vtables as per http://llvm.org/docs/CodingStandards.html#ll_virtual_anch So now that I've got Clang & LLVM almost entirely -Wweak-vtables clean I was wondering: Where/how could the build configuration be changed to help keep it that way? (so that anyone building LLVM/Clang with Clang (including bots) would build with -Wweak-vtables as an error?) (there are ac...

...Header - Output a LLVM style file header to the specified /// ostream. void EmitSourceFileHeader(StringRef Desc, raw_ostream &OS) const; }; Let's go over this class's members one-by-one: anchor(): hack to decrease link time and bloat < http://llvm.org/docs/CodingStandards.html#ll_virtual_anch> ~TableGenBackend(): the standard virtual destructor so that we can polymorphically delete. Except that we never polymorphically delete. Every use of the backends is basically `SubtargetEmitter(Records).run(OS);` and is hardcoded into the respective TableGen.cpp file. No polymorphic creation ev...

...ng (disabling any errors that seem like more noise/less >>>> interesting). One warning I've recently hit a few instances of is >>>> -Wweak-vtable which is, in fact, an explicitly documented LLVM coding >>>> standard ( http://llvm.org/docs/CodingStandards.html#ll_virtual_anch >>>> ). Some instances of this have been easy to fix (see attached patch - >>>> if it looks good to anyone I'll check that in) but a particular set of >>>> them have been a little more problematic. >>> >>> Nice, please commit your patch.  I...

...; region, + raw_ostream& vStream) { Please use "foo_t &f" instead of "foo_t& f". + virtual ~MCDisassembler() { + } Make sure each class with a virtual method has at least one method defined out of line: http://llvm.org/docs/CodingStandards.html#ll_virtual_anch Some bigger stuff: include/llvm/MC/MCDisassembler.h seems to have four copies of itself in the same file. In terms of API design: + /// Constructor - Performs initial setup for the disassembler. This may + /// do the work of disassembly, or may (especially on...

...ng (disabling any errors that seem like more noise/less >>>> interesting). One warning I've recently hit a few instances of is >>>> -Wweak-vtable which is, in fact, an explicitly documented LLVM coding >>>> standard ( http://llvm.org/docs/CodingStandards.html#ll_virtual_anch >>>> ). Some instances of this have been easy to fix (see attached patch - >>>> if it looks good to anyone I'll check that in) but a particular set of >>>> them have been a little more problematic. >>> >>> Nice, please commit your patch.  I...

Bill, thanks for your comments. I'll respond to them individually. I've attached a new revision of the patch that addresses them. Patch built and tested against SVN 79487, with the additional attached fix that fixes an Intel table bug. Sean On 2009/08/18, at 0:57, Bill Wendling wrote: > 0. Watch out for tabs! Fixed. Thanks. > 1. Includes like this "#include