search for: list_md_devices

...++++++++++++++ src/MAX_PROC_NR | 2 +- 9 files changed, 165 insertions(+), 8 deletions(-) create mode 100644 daemon/md.c create mode 100755 regressions/test-list-md-devices.sh -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-New-API-list_md_devices.patch Type: text/x-patch Size: 7912 bytes Desc: not available URL: <http://listman.redhat.com/archives/libguestfs/attachments/20111110/597a0235/attachment.bin>

...+++ b/daemon/listfs.ml > @@ -24,24 +24,20 @@ let rec list_filesystems () = > let has_lvm2 = Lvm.available () in > let has_ldm = Ldm.available () in > > - let devices = Devsparts.list_devices () in > let partitions = Devsparts.list_partitions () in > - let mds = Md.list_md_devices () in > > (* Look to see if any devices directly contain filesystems > - * (RHBZ#590167). However vfs-type will fail to tell us anything > + * (RHBZ#590167). However vfs-type will fail to tell us anything This whitespace change is wrong. > * useful about devices which...

...424f5 100644 --- a/daemon/listfs.ml +++ b/daemon/listfs.ml @@ -24,24 +24,20 @@ let rec list_filesystems () = let has_lvm2 = Lvm.available () in let has_ldm = Ldm.available () in - let devices = Devsparts.list_devices () in let partitions = Devsparts.list_partitions () in - let mds = Md.list_md_devices () in (* Look to see if any devices directly contain filesystems - * (RHBZ#590167). However vfs-type will fail to tell us anything + * (RHBZ#590167). However vfs-type will fail to tell us anything * useful about devices which just contain partitions, so we also - * get the list of p...

...t;> @@ -24,24 +24,20 @@ let rec list_filesystems () = >> let has_lvm2 = Lvm.available () in >> let has_ldm = Ldm.available () in >> >> - let devices = Devsparts.list_devices () in >> let partitions = Devsparts.list_partitions () in >> - let mds = Md.list_md_devices () in >> >> (* Look to see if any devices directly contain filesystems >> - * (RHBZ#590167). However vfs-type will fail to tell us anything >> + * (RHBZ#590167). However vfs-type will fail to tell us anything > > This whitespace change is wrong. Ah, I didn'...

...b/daemon/listfs.ml @@ -24,31 +24,15 @@ let rec list_filesystems () = let has_lvm2 = Optgroups.lvm2_available () in let has_ldm = Optgroups.ldm_available () in + (* Devices. *) let devices = Devsparts.list_devices () in - let partitions = Devsparts.list_partitions () in - let mds = Md.list_md_devices () in - - (* Look to see if any devices directly contain filesystems - * (RHBZ#590167). However vfs-type will fail to tell us anything - * useful about devices which just contain partitions, so we also - * get the list of partitions and exclude the corresponding devices - * by using part-...

...b/daemon/listfs.ml @@ -24,31 +24,15 @@ let rec list_filesystems () = let has_lvm2 = Optgroups.lvm2_available () in let has_ldm = Optgroups.ldm_available () in + (* Devices. *) let devices = Devsparts.list_devices () in - let partitions = Devsparts.list_partitions () in - let mds = Md.list_md_devices () in - - (* Look to see if any devices directly contain filesystems - * (RHBZ#590167). However vfs-type will fail to tell us anything - * useful about devices which just contain partitions, so we also - * get the list of partitions and exclude the corresponding devices - * by using part-...

...o "/dev/vda1" "/" libguestfs: trace: mount_ro = -1 (error) libguestfs: trace: vfs_type "/dev/vda2" libguestfs: trace: vfs_type = "ntfs" libguestfs: trace: mount_ro "/dev/vda2" "/" libguestfs: trace: mount_ro = -1 (error) libguestfs: trace: list_md_devices libguestfs: trace: list_md_devices = [] libguestfs: trace: available "lvm2" libguestfs: trace: available = 0 libguestfs: trace: lvs libguestfs: trace: lvs = [] libguestfs: trace: inspect_os = [] [] ________________________________________ 发件人: Richard W.M. Jones [rjones@redhat.com] 发送时间:...

This patch series addresses comments after v6 series review. Mykola Ivanets (6): daemon: Changing the way that we detect if a device contains partitions. daemon: list-filesystems: Ignore partitioned MD devices. tests: list-filesystems command ignores partitioned MD devices. daemon: list-filesystems: Change the way we filter out LDM partitions. daemon: list-filesystems: Filter out

Before I rush to change something I request your comments on the subject. Let me know what do you think and if it does make sense. The issue: guesfs_list_filesystems is inconsistent in its output. For, example, it filters out partitioned physical devices but doesn't do the same for MD devices. More over, according to its name and API documentation guestfs_list_filesystem should return

I use python-guestfs to mount windows image it have some problems .Here is my code: [root@mfsdata1 ~]# python Python 2.6.6 (r266:84292, Sep 11 2012, 08:34:23) [GCC 4.4.6 20120305 (Red Hat 4.4.6-4)] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import os >>> sheepfs_dir="/tmp/sheepfs"

...;, line); - } - } - - if (end_stringsbuf (&ret) == -1) - return NULL; - - return take_stringsbuf (&ret); -} - int do_md_stop (const char *md) { diff --git a/daemon/md.ml b/daemon/md.ml index caf87cf8f..ba045b5f7 100644 --- a/daemon/md.ml +++ b/daemon/md.ml @@ -46,3 +46,40 @@ let list_md_devices () = (* Return the list sorted. *) sort_device_names devs + +let md_detail md = + let out = command "mdadm" ["-D"; "--export"; md] in + + (* Split the command output into lines. *) + let out = String.trim out in + let lines = String.nsplit "\n" ou...

v8: - Rebased on top of master. v7: - Addresses comments after v6 series review. v6: - Addresses comments after v5 series review. - Large commit is splitted to more granular commits for better code review. v5: - Addresses comments after v4 series review (part_get_mbr_part_type doesn't break original implementation in C). - Rebased on top of master and little bit refactored for

...2d83 100644 --- a/daemon/md.ml +++ b/daemon/md.ml @@ -25,7 +25,7 @@ open Utils external is_raid_device : string -> bool = "guestfs_int_daemon_is_raid_device" "noalloc" -let re_md = Str.regexp "^md[0-9]+$" +let re_md = PCRE.compile "^md[0-9]+$" let list_md_devices () = (* Look for directories under /sys/block matching md[0-9]+ @@ -33,7 +33,7 @@ let list_md_devices () = *) let devs = Sys.readdir "/sys/block" in let devs = Array.to_list devs in - let devs = List.filter (fun d -> Str.string_match re_md d 0) devs in + let devs = List....

...nal_feature_available = 1 libguestfs: trace: feature_available = 0 libguestfs: trace: list_devices libguestfs: trace: list_devices = ["/dev/sda"] libguestfs: trace: list_partitions libguestfs: trace: list_partitions = ["/dev/sda1", "/dev/sda2"] libguestfs: trace: list_md_devices libguestfs: trace: list_md_devices = [] libguestfs: trace: part_to_dev "/dev/sda1" libguestfs: trace: part_to_dev = "/dev/sda" libguestfs: trace: part_to_dev "/dev/sda2" libguestfs: trace: part_to_dev = "/dev/sda" libguestfs: trace: vfs_type "/dev/...

This patch series: 1. Addresses comments from v5 series review 2. Large commit is splitted to more granular commits for better code review. Mykola Ivanets (6): daemon: Changing the way that we detect if a device contains partitions. daemon: list-filesystems: Ignore partitioned MD devices. tests: list-filesystems command ignores partitioned MD devices. daemon: list-filesystems: Change

...libguestfs: trace: feature_available = 0 > libguestfs: trace: list_devices > libguestfs: trace: list_devices = ["/dev/sda"] > libguestfs: trace: list_partitions > libguestfs: trace: list_partitions = ["/dev/sda1", "/dev/sda2"] > libguestfs: trace: list_md_devices > libguestfs: trace: list_md_devices = [] > libguestfs: trace: part_to_dev "/dev/sda1" > libguestfs: trace: part_to_dev = "/dev/sda" > libguestfs: trace: part_to_dev "/dev/sda2" > libguestfs: trace: part_to_dev = "/dev/sda" > libguestf...

...17 15:39:27 CEST Richard W.M. Jones wrote: > +let rec list_filesystems () = > + let has_lvm2 = Lvm.available () in > + let has_ldm = Ldm.available () in > + > + let devices = Devsparts.list_devices () in > + let partitions = Devsparts.list_partitions () in > + let mds = Md.list_md_devices () in > + > + (* Look to see if any devices directly contain filesystems > + * (RHBZ#590167). However vfs-type will fail to tell us anything > + * useful about devices which just contain partitions, so we also > + * get the list of partitions and exclude the corresponding dev...

...race: feature_available = 0 >> libguestfs: trace: list_devices >> libguestfs: trace: list_devices = ["/dev/sda"] >> libguestfs: trace: list_partitions >> libguestfs: trace: list_partitions = ["/dev/sda1", "/dev/sda2"] >> libguestfs: trace: list_md_devices >> libguestfs: trace: list_md_devices = [] >> libguestfs: trace: part_to_dev "/dev/sda1" >> libguestfs: trace: part_to_dev = "/dev/sda" >> libguestfs: trace: part_to_dev "/dev/sda2" >> libguestfs: trace: part_to_dev = "/dev/sda"...

...: trace: list_devices = ["/dev/sda"] Feb 20 15:58:11 tve50 collectd[4689]: libguestfs: trace: list_partitions Feb 20 15:58:11 tve50 collectd[4689]: libguestfs: trace: list_partitions = ["/dev/sda1", "/dev/sda15"] Feb 20 15:58:11 tve50 collectd[4689]: libguestfs: trace: list_md_devices Feb 20 15:58:11 tve50 collectd[4689]: libguestfs: trace: list_md_devices = [] Feb 20 15:58:11 tve50 collectd[4689]: libguestfs: trace: part_to_dev "/dev/sda1" Feb 20 15:58:11 tve50 collectd[4689]: libguestfs: trace: part_to_dev = "/dev/sda" Feb 20 15:58:11 tve50 collectd[4689]:...

.../listfs.ml +++ b/daemon/listfs.ml @@ -25,39 +25,18 @@ let rec list_filesystems () = let has_ldm = Optgroups.ldm_available () in let devices = Devsparts.list_devices () in - let partitions = Devsparts.list_partitions () in + let devices = List.filter check_device devices in let mds = Md.list_md_devices () in - - (* Look to see if any devices directly contain filesystems - * (RHBZ#590167). However vfs-type will fail to tell us anything - * useful about devices which just contain partitions, so we also - * get the list of partitions and exclude the corresponding devices - * by using part-...