search for: list_applications_rpm

...++ b/lib/inspect-apps.c > @@ -122,9 +122,14 @@ guestfs_impl_inspect_list_applications2 (guestfs_h *g, const char *root) > if (STREQ (type, "linux") || STREQ (type, "hurd")) { > if (STREQ (package_format, "rpm")) { > #ifdef DB_DUMP > - ret = list_applications_rpm (g, root); > - if (ret == NULL) > - return NULL; > + /* Allow db_dump to be missing at runtime so that it can be > + * installed as a weak dependency. > + */ > + if (system (DB_DUMP " -V >/dev/null 2>&1") == 0) { > +...

Fix for: https://bugzilla.redhat.com/show_bug.cgi?id=1409024

I got a recent report of virt-v2v (via virt-p2v) failing to migrate a Fedora guest. The issue was that its /var/lib/rpm/Packages was bigger than our current limit (~410M vs 300M), hence the inspection failed. I took the liberty to refactor the limits of the these files, bumping the problematic one, and reducing the ones of the others (as they are supposed to be way smaller than the limit). Pino

...--git a/lib/inspect-apps.c b/lib/inspect-apps.c index f0cf16b38..57428a3ba 100644 --- a/lib/inspect-apps.c +++ b/lib/inspect-apps.c @@ -45,9 +45,7 @@ #include "guestfs-internal-actions.h" #include "structs-cleanups.h" -#ifdef DB_DUMP static struct guestfs_application2_list *list_applications_rpm (guestfs_h *g, const char *root); -#endif static struct guestfs_application2_list *list_applications_deb (guestfs_h *g, const char *root); static struct guestfs_application2_list *list_applications_pacman (guestfs_h *g, const char *root); static struct guestfs_application2_list *list_application...

...est-case, I can write a make-archlinux-img.sh script and send it in another patch. It's not big deal. Another thing, I left out of the patch the epoch translation. Pacman's version formats looks like this: epoch:version-rel. You have the epoch hard-coded to 0 in list_applications_deb() and list_applications_rpm(), so I did the same but I can implement it for the sake of completeness. Should I be using the guestfs___parse_unsigned_int() function for the string to int conversion? Nikos On 17 November 2014 00:16, Richard W.M. Jones <rjones@redhat.com> wrote: > On Sun, Nov 16, 2014 at 03:24:16PM +0...

We went around the houses a few times last year in order to try to fix this old Debian bug: https://bugzilla.redhat.com/show_bug.cgi?id=1409024 My last attempt was: https://www.redhat.com/archives/libguestfs/2017-October/msg00058.html which I believe was neither reviewed nor rejected, so I'm reposting the same patch again, simply rebased against current git. Rich.

Previously posted: https://www.redhat.com/archives/libguestfs/2017-October/msg00032.html This takes a completely different approach. It turns out that POSIX / the shell already defines a special exit code 127 for ‘command not found’. We can make a small adjustment to lib/command.c to return this exit code in that case. Then we just have to modify the db_dump code to test for this exit code. I

...-- a/lib/inspect-apps.c +++ b/lib/inspect-apps.c @@ -122,9 +122,14 @@ guestfs_impl_inspect_list_applications2 (guestfs_h *g, const char *root) if (STREQ (type, "linux") || STREQ (type, "hurd")) { if (STREQ (package_format, "rpm")) { #ifdef DB_DUMP - ret = list_applications_rpm (g, root); - if (ret == NULL) - return NULL; + /* Allow db_dump to be missing at runtime so that it can be + * installed as a weak dependency. + */ + if (system (DB_DUMP " -V >/dev/null 2>&1") == 0) { + ret = list_applications_rpm (g, roo...

...gt; > @@ -122,9 +122,14 @@ guestfs_impl_inspect_list_applications2 (guestfs_h *g, const char *root) > > if (STREQ (type, "linux") || STREQ (type, "hurd")) { > > if (STREQ (package_format, "rpm")) { > > #ifdef DB_DUMP > > - ret = list_applications_rpm (g, root); > > - if (ret == NULL) > > - return NULL; > > + /* Allow db_dump to be missing at runtime so that it can be > > + * installed as a weak dependency. > > + */ > > + if (system (DB_DUMP " -V >/dev/null 2>&1...

...ect-apps.c | 125 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 125 insertions(+) diff --git a/src/inspect-apps.c b/src/inspect-apps.c index b62b432..b7a3b0e 100644 --- a/src/inspect-apps.c +++ b/src/inspect-apps.c @@ -60,6 +60,7 @@ static struct guestfs_application2_list *list_applications_rpm (guestfs_h *g, struct inspect_fs *fs); #endif static struct guestfs_application2_list *list_applications_deb (guestfs_h *g, struct inspect_fs *fs); +static struct guestfs_application2_list *list_applications_pacman (guestfs_h *g, struct inspect_fs *fs); static struct guestfs_application2_list *l...

Here's the new API method and update to virt-inspector. I still need to implement app_arch for debian and windows (if applicable), for now they just return empty strings.

...122,14 @@ guestfs_impl_inspect_list_applications2 (guestfs_h *g, const char *root) > > > if (STREQ (type, "linux") || STREQ (type, "hurd")) { > > > if (STREQ (package_format, "rpm")) { > > > #ifdef DB_DUMP > > > - ret = list_applications_rpm (g, root); > > > - if (ret == NULL) > > > - return NULL; > > > + /* Allow db_dump to be missing at runtime so that it can be > > > + * installed as a weak dependency. > > > + */ > > > + if (system (DB_DUMP &quot...

Here's the new API method and update to virt-inspector. I still need to implement app_arch for debian and windows (if applicable), for now they just return empty strings. New in v2: incorporated feedback from v1, also added patch #3 which updates the documentation where it references the deprecated API. Take it or leave it.

...MAX_DPKG_STATUS_SIZE (50 * 1000 * 1000) /* Maximum APK 'installed' file we will download to /tmp. */ -#define MAX_APK_INSTALLED_SIZE (300 * 1000 * 1000) +#define MAX_APK_INSTALLED_SIZE (50 * 1000 * 1000) #ifdef DB_DUMP static struct guestfs_application2_list *list_applications_rpm (guestfs_h *g, const char *root); -- 2.17.2

...rchlinux-img.sh script and send > it in another patch. It's not big deal. > > Another thing, I left out of the patch the epoch translation. Pacman's > version formats looks like this: epoch:version-rel. You have the epoch > hard-coded to 0 in list_applications_deb() and > list_applications_rpm(), Hmm, this is a bug ... > so I did the same but I can implement it for > the sake of completeness. Should I be using the > guestfs___parse_unsigned_int() function for the string to int > conversion? Yes, or sscanf. Rich. -- Richard Jones, Virtualization Group, Red Hat http://peo...

...pect-apps.c | 121 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 121 insertions(+) diff --git a/src/inspect-apps.c b/src/inspect-apps.c index b54cf07..78c32bf 100644 --- a/src/inspect-apps.c +++ b/src/inspect-apps.c @@ -49,6 +49,7 @@ static struct guestfs_application2_list *list_applications_rpm (guestfs_h *g, st #endif static struct guestfs_application2_list *list_applications_deb (guestfs_h *g, struct inspect_fs *fs); static struct guestfs_application2_list *list_applications_pacman (guestfs_h *g, struct inspect_fs *fs); +static struct guestfs_application2_list *list_applications_apk...

...and send >> it in another patch. It's not big deal. >> >> Another thing, I left out of the patch the epoch translation. Pacman's >> version formats looks like this: epoch:version-rel. You have the epoch >> hard-coded to 0 in list_applications_deb() and >> list_applications_rpm(), > > Hmm, this is a bug ... > >> so I did the same but I can implement it for >> the sake of completeness. Should I be using the >> guestfs___parse_unsigned_int() function for the string to int >> conversion? > > Yes, or sscanf. > > Rich. > > --...

Hi, the libguestfs library uses a number of external tools; for some of them, we search for them at build time, enabling some feature only if found, and later on assuming at runtime they are installed. However, the situation is more complex than that: - hardcoding the full path means that there is an incoherency in the way some of the tools are used, as some other tools (e.g. qemu-img) are

...ect-apps.c | 137 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 137 insertions(+) diff --git a/src/inspect-apps.c b/src/inspect-apps.c index 6fb9665..8e645b7 100644 --- a/src/inspect-apps.c +++ b/src/inspect-apps.c @@ -60,6 +60,7 @@ static struct guestfs_application2_list *list_applications_rpm (guestfs_h *g, struct inspect_fs *fs); #endif static struct guestfs_application2_list *list_applications_deb (guestfs_h *g, struct inspect_fs *fs); +static struct guestfs_application2_list *list_applications_pacman (guestfs_h *g, struct inspect_fs *fs); static struct guestfs_application2_list *l...

...++++++++++++++++++++++++++++++ > 1 file changed, 125 insertions(+) > > diff --git a/src/inspect-apps.c b/src/inspect-apps.c > index b62b432..b7a3b0e 100644 > --- a/src/inspect-apps.c > +++ b/src/inspect-apps.c > @@ -60,6 +60,7 @@ > static struct guestfs_application2_list *list_applications_rpm (guestfs_h *g, struct inspect_fs *fs); > #endif > static struct guestfs_application2_list *list_applications_deb (guestfs_h *g, struct inspect_fs *fs); > +static struct guestfs_application2_list *list_applications_pacman (guestfs_h *g, struct inspect_fs *fs); > static struct guestfs_...