search for: list_applications_deb

...he guest. --- lib/inspect-apps.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/lib/inspect-apps.c b/lib/inspect-apps.c index 1216c52..eabe565 100644 --- a/lib/inspect-apps.c +++ b/lib/inspect-apps.c @@ -51,7 +51,7 @@ static struct guestfs_application2_list *list_applications_deb (guestfs_h *g, st static struct guestfs_application2_list *list_applications_pacman (guestfs_h *g, struct inspect_fs *fs); static struct guestfs_application2_list *list_applications_apk (guestfs_h *g, struct inspect_fs *fs); static struct guestfs_application2_list *list_applications_windows (gue...

...kos Skalkotos <skalkoto@gmail.com> --- src/inspect-apps.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/src/inspect-apps.c b/src/inspect-apps.c index 8e645b7..bd4e6c1 100644 --- a/src/inspect-apps.c +++ b/src/inspect-apps.c @@ -439,6 +439,7 @@ list_applications_deb (guestfs_h *g, struct inspect_fs *fs) FILE *fp; char line[1024]; size_t len; + int32_t epoch = 0; CLEANUP_FREE char *name = NULL, *version = NULL, *release = NULL, *arch = NULL; int installed_flag = 0; @@ -482,23 +483,31 @@ list_applications_deb (guestfs_h *g, struct inspect_fs *f...

...he guest. --- lib/inspect-apps.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/lib/inspect-apps.c b/lib/inspect-apps.c index 1216c52..eabe565 100644 --- a/lib/inspect-apps.c +++ b/lib/inspect-apps.c @@ -51,7 +51,7 @@ static struct guestfs_application2_list *list_applications_deb (guestfs_h *g, st static struct guestfs_application2_list *list_applications_pacman (guestfs_h *g, struct inspect_fs *fs); static struct guestfs_application2_list *list_applications_apk (guestfs_h *g, struct inspect_fs *fs); static struct guestfs_application2_list *list_applications_windows (gue...

...39;ll fix that too. For a test-case, I can write a make-archlinux-img.sh script and send it in another patch. It's not big deal. Another thing, I left out of the patch the epoch translation. Pacman's version formats looks like this: epoch:version-rel. You have the epoch hard-coded to 0 in list_applications_deb() and list_applications_rpm(), so I did the same but I can implement it for the sake of completeness. Should I be using the guestfs___parse_unsigned_int() function for the string to int conversion? Nikos On 17 November 2014 00:16, Richard W.M. Jones <rjones@redhat.com> wrote: > On Sun, N...

...--git a/src/inspect-apps.c b/src/inspect-apps.c index b62b432..b7a3b0e 100644 --- a/src/inspect-apps.c +++ b/src/inspect-apps.c @@ -60,6 +60,7 @@ static struct guestfs_application2_list *list_applications_rpm (guestfs_h *g, struct inspect_fs *fs); #endif static struct guestfs_application2_list *list_applications_deb (guestfs_h *g, struct inspect_fs *fs); +static struct guestfs_application2_list *list_applications_pacman (guestfs_h *g, struct inspect_fs *fs); static struct guestfs_application2_list *list_applications_windows (guestfs_h *g, struct inspect_fs *fs); static void add_application (guestfs_h *g, str...

Here's the new API method and update to virt-inspector. I still need to implement app_arch for debian and windows (if applicable), for now they just return empty strings.

...+++ b/lib/inspect-apps.c @@ -45,9 +45,7 @@ #include "guestfs-internal-actions.h" #include "structs-cleanups.h" -#ifdef DB_DUMP static struct guestfs_application2_list *list_applications_rpm (guestfs_h *g, const char *root); -#endif static struct guestfs_application2_list *list_applications_deb (guestfs_h *g, const char *root); static struct guestfs_application2_list *list_applications_pacman (guestfs_h *g, const char *root); static struct guestfs_application2_list *list_applications_apk (guestfs_h *g, const char *root); @@ -121,11 +119,9 @@ guestfs_impl_inspect_list_applications2 (gues...

We went around the houses a few times last year in order to try to fix this old Debian bug: https://bugzilla.redhat.com/show_bug.cgi?id=1409024 My last attempt was: https://www.redhat.com/archives/libguestfs/2017-October/msg00058.html which I believe was neither reviewed nor rejected, so I'm reposting the same patch again, simply rebased against current git. Rich.

Previously posted: https://www.redhat.com/archives/libguestfs/2017-October/msg00032.html This takes a completely different approach. It turns out that POSIX / the shell already defines a special exit code 127 for ‘command not found’. We can make a small adjustment to lib/command.c to return this exit code in that case. Then we just have to modify the db_dump code to test for this exit code. I

Here's the new API method and update to virt-inspector. I still need to implement app_arch for debian and windows (if applicable), for now they just return empty strings. New in v2: incorporated feedback from v1, also added patch #3 which updates the documentation where it references the deprecated API. Take it or leave it.

This adds package arch inspection for deb-based systems. The patch returns package arch as given by dpkg, which means that it returns 'amd64' instead of 'x86_64', for example. Whether or not we should standardize this to match rpm output is up for debate. I see other places such as guestfs_file_architecture that use the rpm-style arch. I can understand though where a user of

...--git a/src/inspect-apps.c b/src/inspect-apps.c index 6fb9665..8e645b7 100644 --- a/src/inspect-apps.c +++ b/src/inspect-apps.c @@ -60,6 +60,7 @@ static struct guestfs_application2_list *list_applications_rpm (guestfs_h *g, struct inspect_fs *fs); #endif static struct guestfs_application2_list *list_applications_deb (guestfs_h *g, struct inspect_fs *fs); +static struct guestfs_application2_list *list_applications_pacman (guestfs_h *g, struct inspect_fs *fs); static struct guestfs_application2_list *list_applications_windows (guestfs_h *g, struct inspect_fs *fs); static void add_application (guestfs_h *g, str...

...nspect-apps.c > index b62b432..b7a3b0e 100644 > --- a/src/inspect-apps.c > +++ b/src/inspect-apps.c > @@ -60,6 +60,7 @@ > static struct guestfs_application2_list *list_applications_rpm (guestfs_h *g, struct inspect_fs *fs); > #endif > static struct guestfs_application2_list *list_applications_deb (guestfs_h *g, struct inspect_fs *fs); > +static struct guestfs_application2_list *list_applications_pacman (guestfs_h *g, struct inspect_fs *fs); > static struct guestfs_application2_list *list_applications_windows (guestfs_h *g, struct inspect_fs *fs); > static void add_application (gu...

Here's a partially implemented fix for RHBZ#859949. Seeing as this is my first libguestfs patch, I'd like some other eyeballs on it to make sure I've not done anything completely crazy. If the rpm case looks ok, I'll update the deb and windows cases if/where applicable.

...a test-case, I can write a make-archlinux-img.sh script and send > it in another patch. It's not big deal. > > Another thing, I left out of the patch the epoch translation. Pacman's > version formats looks like this: epoch:version-rel. You have the epoch > hard-coded to 0 in list_applications_deb() and > list_applications_rpm(), Hmm, this is a bug ... > so I did the same but I can implement it for > the sake of completeness. Should I be using the > guestfs___parse_unsigned_int() function for the string to int > conversion? Yes, or sscanf. Rich. -- Richard Jones, Virtual...

...21 insertions(+) diff --git a/src/inspect-apps.c b/src/inspect-apps.c index b54cf07..78c32bf 100644 --- a/src/inspect-apps.c +++ b/src/inspect-apps.c @@ -49,6 +49,7 @@ static struct guestfs_application2_list *list_applications_rpm (guestfs_h *g, st #endif static struct guestfs_application2_list *list_applications_deb (guestfs_h *g, struct inspect_fs *fs); static struct guestfs_application2_list *list_applications_pacman (guestfs_h *g, struct inspect_fs *fs); +static struct guestfs_application2_list *list_applications_apk (guestfs_h *g, struct inspect_fs *fs); static struct guestfs_application2_list *list_appl...

...write a make-archlinux-img.sh script and send >> it in another patch. It's not big deal. >> >> Another thing, I left out of the patch the epoch translation. Pacman's >> version formats looks like this: epoch:version-rel. You have the epoch >> hard-coded to 0 in list_applications_deb() and >> list_applications_rpm(), > > Hmm, this is a bug ... > >> so I did the same but I can implement it for >> the sake of completeness. Should I be using the >> guestfs___parse_unsigned_int() function for the string to int >> conversion? > > Yes, or...

I got a recent report of virt-v2v (via virt-p2v) failing to migrate a Fedora guest. The issue was that its /var/lib/rpm/Packages was bigger than our current limit (~410M vs 300M), hence the inspection failed. I took the liberty to refactor the limits of the these files, bumping the problematic one, and reducing the ones of the others (as they are supposed to be way smaller than the limit). Pino

This patch series changes a small part of the library to use __attribute__((cleanup(...))) to automatically free memory when pointers go out of the current scope. In general terms this seems to be a small win although you do have to use it carefully. For functions where you can completely get rid of the "exit code paths", it can simplify things. For a good example, see the

v1 -> v2: - Remove the unnecessary calls to guestfs_int_lazy_make_tmpdir in the final patch. Rich.