search for: line_stripnam

Once upon a time there were two places in the loginrec code that were ifdef'd sgi and which stripped the "tty" off the line along with the "dev" when recording utmp. (Specifically it was being done in line_stripname and line_abbrevname.) Doing that in line_stripname was wrong, because it broke things like wall that expected the ut_line to have the "tty" present. But I lost track of patches and also sent a patch to get it removed from line_abbrevname (which breaks interoperability with native xterms...

...Should this patch be changed to only apply to Solaris hosts? Thoughts? Bill Knox Senior Operating Systems Programmer/Analyst The MITRE Corporation -------------- next part -------------- --- loginrec.c~ Mon Oct 29 21:50:40 2001 +++ loginrec.c Mon Nov 19 12:08:34 2001 @@ -701,6 +701,7 @@ line_stripname(utx->ut_line, li->line, sizeof(utx->ut_line)); set_utmpx_time(li, utx); utx->ut_pid = li->pid; + strncpy(utx->ut_name, li->username, MIN_SIZEOF(utx->ut_name, li->username)); if (li->type == LTYPE_LOGOUT) return; @@ -711,7 +712,6 @@ */ /* strncpy(): D...

...information into the utmpx entry for both a login and a logout. This bugzilla entry duplicates an e-mail I sent in in late November, in case this comes up as a duplicate of a known issue. --- loginrec.c~ Mon Oct 29 21:50:40 2001 +++ loginrec.c Tue Jan 29 10:56:59 2002 @@ -701,6 +701,7 @@ line_stripname(utx->ut_line, li->line, sizeof(utx->ut_line)); set_utmpx_time(li, utx); utx->ut_pid = li->pid; + strncpy(utx->ut_name, li->username, MIN_SIZEOF(utx->ut_name, li->username)); if (li->type == LTYPE_LOGOUT) return; @@ -711,...

...terminal people are attached to, causing commands like wall to fail (as they try to open /dev/q1). Maybe this should be version specific? --- openssh-SNAP-20001129.orig/loginrec.c Thu Nov 9 22:28:31 2000 +++ openssh-SNAP-20001129/loginrec.c Thu Nov 30 13:52:24 2000 @@ -512,13 +512,8 @@ line_stripname(char *dst, const char *src, int dstsize) { memset(dst, '\0', dstsize); -#ifdef sgi - if (strncmp(src, "/dev/tty", 8) == 0) - strlcpy(dst, src + 8, dstsize); -#else if (strncmp(src, "/dev/", 5) == 0) strlcpy(dst, src +...

...the next step. Any ideas? The diffs are against 3.0p1, by the way. Bill Knox Senior Operating Systems Programmer/Analyst The MITRE Corporation -------------- next part -------------- --- loginrec.c.orig Thu Nov 15 09:35:02 2001 +++ loginrec.c Thu Nov 15 09:38:01 2001 @@ -701,6 +701,7 @@ line_stripname(utx->ut_line, li->line, sizeof(utx->ut_line)); set_utmpx_time(li, utx); utx->ut_pid = li->pid; + strncpy(utx->ut_name, li->username, MIN_SIZEOF(utx->ut_name, li->username)); if (li->type == LTYPE_LOGOUT) return; @@ -711,7 +712,6 @@ */ /* strncpy(): D...

...sh-3.8p1.org/loginrec.c 2004-04-29 01:06:46.350105456 +0200 +++ openssh-3.8p1/loginrec.c 2004-04-29 01:07:37.357351176 +0200 @@ -1354,7 +1354,7 @@ syslogin_perform_logout(struct logininfo *li) { # ifdef HAVE_LOGOUT - char line[8]; + char line[LINFO_LINESIZE]; (void)line_stripname(line, li->line, sizeof(line)); ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

...l 6 01:20:46 2003 --- openssh-3.7.1p2/loginrec.c Wed Apr 7 19:35:43 2004 *************** *** 1349,1355 **** --- 1349,1359 ---- syslogin_perform_logout(struct logininfo *li) { # ifdef HAVE_LOGOUT + # ifdef UT_LINESIZE + char line[UT_LINESIZE]; + # else char line[8]; + # endif (void)line_stripname(line, li->line, sizeof(line));