search for: line_abbrevnam

Once upon a time there were two places in the loginrec code that were ifdef'd sgi and which stripped the "tty" off the line along with the "dev" when recording utmp. (Specifically it was being done in line_stripname and line_abbrevname.) Doing that in line_stripname was wrong, because it broke things like wall that expected the ut_line to have the "tty" present. But I lost track of patches and also sent a patch to get it removed from line_abbrevname (which breaks interoperability with native xterms and other things tha...

http://bugzilla.mindrot.org/show_bug.cgi?id=214 Summary: IRIX utmp problem loginrec.c: line_abbrevname() goes wrong Product: Portable OpenSSH Version: 3.1p1 Platform: MIPS URL: http://groups.google.de/groups?hl=de&selm=3B979A7D.10809 06%40nowhere.org&rnum=4 OS/Version: IRIX Status: NEW...

http://bugzilla.mindrot.org/show_bug.cgi?id=214 djm at mindrot.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED ------- Additional Comments From djm at mindrot.org 2002-04-23 23:08 ------- Similar patch applied - please test tommorow's

Hi, In loginrec.c, the 'line' string utility function line_abbrevname() returns the last four characters of the terminal file path. This returned value is assigned to the utmp structure member ut_id[4]. Some sample ut_id values are shown below: /dev/pts/1 will have ut_id set to ts/1 /dev/pts/2 will have ut_id set to ts/2 . . /dev/pts/9 will have ut_id set...

...ZEOF(utx->ut_host, li->hostname)); # endif @@ -942,9 +942,7 @@ { struct utmpx utx; - memset(&utx, '\0', sizeof(utx)); - set_utmpx_time(li, &utx); - line_stripname(utx.ut_line, li->line, sizeof(utx.ut_line)); + construct_utmpx(li, &utx); # ifdef HAVE_ID_IN_UTMPX line_abbrevname(utx.ut_id, li->line, sizeof(utx.ut_id)); # endif --- session.c~ Tue Nov 13 07:46:19 2001 +++ session.c Mon Nov 19 12:08:34 2001 @@ -1863,7 +1863,7 @@ /* Record that the user has logged out. */ if (s->pid != 0) - record_logout(s->pid, s->tty); + record_logout(s->pid, s->t...

...ound (3.7.1p2, 3.8.1p1) Login prematurely quits during session setup (mm_send_fd: sendmsg(3): Bad file number | mm_receive_fd: recvmsg: expected received 1 got 0) (3.8.1p1) Seems the mm_xxxx_() functions arent called when PrivSep is off. The utmpx line field isnt filled in correctly (loginrec.c:line_abbrevname() - easy to fix) but doenst seem to affect these problems. This was found on HP's site with no solution : http://forums1.itrc.hp.com/service/forums/questionanswer.do?admit=716493758+1089735097108+28353475&threadId=43106 Something mentioned was a change in logname to use getsid() instead...

http://bugzilla.mindrot.org/show_bug.cgi?id=345 stevesk at pobox.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Lutz.Jaenicke at aet.TU- | |Cottbus.DE ------- Additional Comments From stevesk at

...e)); # endif @@ -942,9 +942,7 @@ { struct utmpx utx; - memset(&utx, '\0', sizeof(utx)); - set_utmpx_time(li, &utx); - line_stripname(utx.ut_line, li->line, sizeof(utx.ut_line)); + construct_utmpx(li, &utx); # ifdef HAVE_ID_IN_UTMPX line_abbrevname(utx.ut_id, li->line, sizeof(utx.ut_id)); # endif --- session.c~ Sat Dec 1 18:37:08 2001 +++ session.c Tue Jan 29 10:56:59 2002 @@ -1866,7 +1866,7 @@ /* Record that the user has logged out. */ if (s->pid != 0) - record_logout(s->pid, s->tty); +...

...0; + } + } +# endif } #endif /* USE_UTMP || USE_WTMP || USE_LOGIN */ @@ -689,6 +705,9 @@ void construct_utmpx(struct logininfo *li, struct utmpx *utx) { +# ifdef HAVE_ADDR_V6_IN_UTMP + struct sockaddr_in6 *sa6; +# endif memset(utx, '\0', sizeof(*utx)); # ifdef HAVE_ID_IN_UTMPX line_abbrevname(utx->ut_id, li->line, sizeof(utx->ut_id)); @@ -725,6 +744,19 @@ if (li->hostaddr.sa.sa_family == AF_INET) utx->ut_addr = li->hostaddr.sa_in.sin_addr.s_addr; # endif +# ifdef HAVE_ADDR_V6_IN_UTMP + /* this is just a 128-bit IPv6 address */ + if (li->hostaddr.sa.sa_family...

...ZEOF(utx->ut_host, li->hostname)); # endif @@ -942,9 +942,7 @@ { struct utmpx utx; - memset(&utx, '\0', sizeof(utx)); - set_utmpx_time(li, &utx); - line_stripname(utx.ut_line, li->line, sizeof(utx.ut_line)); + construct_utmpx(li, &utx); # ifdef HAVE_ID_IN_UTMPX line_abbrevname(utx.ut_id, li->line, sizeof(utx.ut_id)); # endif --- session.c.orig Thu Nov 15 09:35:02 2001 +++ session.c Thu Nov 15 09:38:01 2001 @@ -1856,7 +1856,7 @@ /* Record that the user has logged out. */ if (s->pid != 0) - record_logout(s->pid, s->tty); + record_logout(s->pid, s-...