search for: libxl_device_disk_local_detach

Hi, List, I''m trying xl create a pv guest with qcow/qcow2 image, it always fails at libxl_device_disk_local_attach. #xl create pv_config_file libxl: error: libxl.c:1119:libxl_device_disk_local_attach: cannot locally attach a qdisk image if the format is not raw libxl: error: libxl_create.c:467:do_domain_create: failed to run bootloader: -3 disk configuration is: disk=[

...a trivial error handling change in nic device init. Signed-off-by: Gianni Tedesco <gianni.tedesco@citrix.com> diff -r efe2d3ea22ae tools/libxl/libxl.c --- a/tools/libxl/libxl.c Tue Jan 11 15:30:48 2011 +0000 +++ b/tools/libxl/libxl.c Tue Jan 11 15:40:45 2011 +0000 @@ -1024,6 +1024,35 @@ int libxl_device_disk_local_detach(libxl } /******************************************************************************/ +int libxl_device_nic_init(libxl_device_nic *nic_info, int devnum) +{ + const uint8_t *r; + libxl_uuid uuid; + + libxl_uuid_generate(&uuid); + r = libxl_uuid_bytearray(&uuid); + memse...

...} @@ -1777,7 +1898,9 @@ const char * libxl_device_disk_local_att XL_LOG(ctx, XL_LOG_ERROR, "unrecognized disk physical type: %d\n", phystype); break; } - return dev; + ret = strdup(dev); + libxl_free_all(&gc); + return ret; } int libxl_device_disk_local_detach(libxl_ctx *ctx, libxl_device_disk *disk) @@ -1795,31 +1918,36 @@ int libxl_device_disk_local_detach(libxl /******************************************************************************/ int libxl_device_nic_add(libxl_ctx *ctx, uint32_t domid, libxl_device_nic *nic) { + libxl_gc gc = LIBXL_IN...

The series introduces auto-generation of the type definitions used in the libxl interface followed by auto-generation of a destructor function for each type. In the future it may be possible to use the related data structures for other purposes, for example auto-generation of the functions to marshal between C and language binding data types. tools/_libxl_types.h should be identical both before