search for: libxl_create_logfile

If libxl_create_logfile fails for some reason then libxl__create_qemu_logfile previously just carried on and dereferenced the uninitialised logfile. Check for the error from libxl_create_logfile, which has already logged for us. This was reported as Debian bug #784880. Reported-by: Russell Coker <russell at coker.co...

On Mon, Jul 13, 2015 at 01:31:23PM +0100, Ian Campbell wrote: > If libxl_create_logfile fails for some reason then > libxl__create_qemu_logfile previously just carried on and dereferenced > the uninitialised logfile. > > Check for the error from libxl_create_logfile, which has already > logged for us. > > This was reported as Debian bug #784880. > > Repor...

Package: xen-utils-4.4 Version: 4.4.1-9 Severity: normal # /usr/lib/xen-4.4/bin/xl create -c /etc/xen/katana Parsing config from /etc/xen/katana libxl: error: libxl_utils.c:217:logrename: failed to rotate logfile - could not rename /var/log/xen/qemu-dm-katana.log.6 to /var/log/xen/qemu-dm-katana.log.7: Permission denied Segmentation fault The above happens repeatably when I run xl on a system

...goto out; + } + + path = libxl_sprintf(&gc, "/local/domain/0/device-model/%d", info->domid); xs_mkdir(ctx->xsh, XBT_NULL, path); - libxl_xs_write(ctx, XBT_NULL, libxl_sprintf(ctx, "%s/disable_pf", path), "%d", !info->xen_platform_pci); - - libxl_create_logfile(ctx, libxl_sprintf(ctx, "qemu-dm-%s", info->dom_name), &logfile); + libxl_xs_write(&gc, XBT_NULL, libxl_sprintf(&gc, "%s/disable_pf", path), "%d", !info->xen_platform_pci); + + libxl_create_logfile(ctx, libxl_sprintf(&gc, "qemu-dm-%s&qu...

a, libxl_event.h is included in libxl.h. So, the former one also need to be installed. b, define __XEN_TOOLS__ in libxl.h: the head file "xen/sysctl.h" need check this macro. It is the same way used by the xen libxc public headers(tools/libxc/xenctrl.h and tools/libxc/xenctrlosdep.h). Signed-off-by: Bamvor Jian Zhang <bjzhang@suse.com> diff -r 87218bd367be