search for: libvirt_utils

Enhance the Libvirt_utils module with libvirt connection objects, and read-only and read-writen open functions for them; adapt the rest of the mini-binding to use these objects, instead of opening + closing libvirt connections every time. This has different improvements: a) a libvirt connection is reused for different API...

Seems it didn't appear on the mailing list, resent it. Hi folks, I'm trying to build libvirt using meson with the latest upstream libvirt, but the compilation fails: (followed on https://libvirt.org/compiling.html, not sure if any dependencies are missed. I checked, src/util/libvirt_util.a.p does not exist.) FAILED: src/util/libvirt_util.a.p/glibcompat.c.o .... In file included from

Use the default libvirt authentication handler as base for ours, overriding it with our callback only in case we have a password to supply. --- v2v/libvirt_utils.ml | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/v2v/libvirt_utils.ml b/v2v/libvirt_utils.ml index 7df17b29..4d0b8639 100644 --- a/v2v/libvirt_utils.ml +++ b/v2v/libvirt_utils.ml @@ -33,10 +33,14 @@ let auth_for_password_file ?password_file () = ) creds in...

This way errors that occur while reading the password file are properly propagated, instead of being reported as errors of the libvirt authentication callback. Reported by: Ming Xie. --- v2v/libvirt_utils.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v2v/libvirt_utils.ml b/v2v/libvirt_utils.ml index 4d0b8639..1a24b049 100644 --- a/v2v/libvirt_utils.ml +++ b/v2v/libvirt_utils.ml @@ -24,8 +24,8 @@ open Common_gettext.Gettext module. *) let auth_for_password_file ?passw...

On Thu, Sep 24, 2020 at 2:58 PM Ján Tomko <jtomko@redhat.com> wrote: > On a Thursday in 2020, Wei Wang wrote: > >Seems it didn't appear on the mailing list, resent it. > > > > Hi folks, > > > >I'm trying to build libvirt using meson with the latest upstream libvirt, > >but the compilation fails: > >(followed on

Currently virt-v2v has few custom C-based functions for libvirt operations, which are limited in what they do, and there is a lot of duplicated code. Instead, switch to ocaml-libvirt for all the libvirt interaction currently done by the Libvirt_utils module. This has few advantages: - each input & output module now opens a libvirt connection only once, only when needed - no need to pass URIs and passwords around, if not needed - a wider range of libvirt APIs can now be used, with no need to create bindings manually The hierarchy of in...

On Fri, Sep 25, 2020 at 10:03 AM Wei Wang <weiwangcloud2020@gmail.com> wrote: > On Thu, Sep 24, 2020 at 2:58 PM Ján Tomko <jtomko@redhat.com> wrote: > >> On a Thursday in 2020, Wei Wang wrote: >> >Seems it didn't appear on the mailing list, resent it. >> > >> > Hi folks, >> > >> >I'm trying to build libvirt using meson

While there are input modes that do not use libvirt, making libvirt mandatory for virt-v2v slightly simplifies the code now, and allow for further improvements/integration with libvirt later on. --- Makefile.am | 2 ++ v2v/Makefile.am | 20 ++++++-------------- v2v/libvirt_utils-c.c | 22 ---------------------- v2v/v2v.ml | 12 +++--------- 4 files changed, 11 insertions(+), 45 deletions(-) diff --git a/Makefile.am b/Makefile.am index 0067d7b7b..cf9ca512e 100644 --- a/Makefile.am +++ b/Makefile.am @@ -169,10 +169,12 @@ SUBDIRS += get-kernel SUBDIRS += resize...

Use -ip instead of --password-file, and various refactorings. It strikes me that we should probably deprecate and eventually remove virt-v2v-copy-to-local. With the introduction of the new SSH and VDDK transports, and with RHEL 5 Xen becoming more irrelevant, it's no longer needed. Rich.

On Fri, Sep 08, 2017 at 05:44:17PM +0200, Pino Toscano wrote: > diff --git a/v2v/libvirt_utils.mli b/v2v/libvirt_utils.mli > index 53dfd48e5..11a83b9a2 100644 > --- a/v2v/libvirt_utils.mli > +++ b/v2v/libvirt_utils.mli > @@ -24,32 +24,42 @@ > password prompt to stdout, which is the same place we would be > reading the XML from. This file works around this brokenn...

...Libvirt.Virterror { message } -> error (f_"cannot get libvirt hypervisor capabilities: %s") @@ -96,7 +98,7 @@ class output_libvirt oc output_pool = object capabilities_doc <- Some doc; (* Does the domain already exist on the target? (RHBZ#889082) *) - if Libvirt_utils.domain_exists conn source.s_name then ( + if Libvirt_utils.domain_exists self#conn source.s_name then ( if source.s_hypervisor = Physical then (* virt-p2v user *) error (f_"a libvirt domain called ‘%s’ already exists on the target.\n\nIf using virt-p2v, select a different ‘N...

On a Thursday in 2020, Wei Wang wrote: >Seems it didn't appear on the mailing list, resent it. > > Hi folks, > >I'm trying to build libvirt using meson with the latest upstream libvirt, >but the compilation fails: >(followed on https://libvirt.org/compiling.html, not sure if any >dependencies are missed. I checked, src/util/libvirt_util.a.p does not >exist.) >

...virt.ml b/v2v/output_libvirt.ml index 0247e5ad..dfd5d1a3 100644 --- a/v2v/output_libvirt.ml +++ b/v2v/output_libvirt.ml @@ -105,9 +105,8 @@ object (self) (* Connect to output libvirt instance and check that the pool exists * and dump out its XML. *) - let xml = - let pool = Libvirt_utils.get_pool self#conn output_pool in - Libvirt.Pool.get_xml_desc (Libvirt.Pool.const pool) in + let pool = Libvirt_utils.get_pool self#conn output_pool in + let xml = Libvirt.Pool.get_xml_desc (Libvirt.Pool.const pool) in let doc = Xml.parse_memory xml in let xpathctx = Xml.xpath_...

Hi folks, I'm trying to build libvirt using meson with the latest upstream libvirt, but the compilation fails: (followed on https://libvirt.org/compiling.html, not sure if any dependencies are missed) FAILED: src/util/libvirt_util.a.p/glibcompat.c.o .... In file included from ../src/util/glibcompat.c:19: ./config.h:1026:10: fatal error: config-post.h: No such file or directory FAILED:

...v2v/input_libvirt_vcenter_https.ml | 13 +- v2v/input_libvirt_vcenter_https.mli | 2 +- v2v/input_libvirt_vddk.ml | 15 +- v2v/input_libvirt_vddk.mli | 4 +- v2v/input_libvirt_xen_ssh.ml | 13 +- v2v/input_libvirt_xen_ssh.mli | 2 +- v2v/libvirt_utils-c.c | 539 -------- v2v/libvirt_utils.ml | 95 +- v2v/libvirt_utils.mli | 51 +- v2v/output_libvirt.ml | 56 +- v2v/parse_libvirt_xml.ml | 23 +- v2v/parse_libvirt_xml.mli | 11 +- v2v/test-harness/...

...v2v/input_libvirt_vcenter_https.mli | 2 +- v2v/input_libvirt_vddk.ml | 21 +- v2v/input_libvirt_vddk.mli | 4 +- v2v/input_libvirt_xen_ssh.ml | 13 +- v2v/input_libvirt_xen_ssh.mli | 2 +- v2v/input_libvirtxml.ml | 3 +- v2v/libvirt_utils-c.c | 539 -------- v2v/libvirt_utils.ml | 95 +- v2v/libvirt_utils.mli | 51 +- v2v/output_libvirt.ml | 56 +- v2v/parse_libvirt_xml.ml | 14 +- v2v/parse_libvirt_xml.mli | 11 +- v2v/test-harness/...

...mount.c | 2 +- inspector/inspector.c | 2 +- make-fs/make-fs.c | 2 +- mllib/getopt-c.c | 2 +- p2v/main.c | 2 +- rescue/rescue.c | 2 +- sparsify/cmdline.ml | 2 +- v2v/libvirt_utils-c.c | 2 +- website/download/builder/index | 4 ++-- website/download/builder/index.asc | 30 +++++++++++++++--------------- 22 files changed, 37 insertions(+), 37 deletions(-) diff --git a/align/scan.c b/align/scan.c index 175df1e83..7ae8adf1f 100644 --- a/align/scan.c +++ b/al...

...v2v/input_libvirt_vcenter_https.mli | 2 +- v2v/input_libvirt_vddk.ml | 15 +- v2v/input_libvirt_vddk.mli | 4 +- v2v/input_libvirt_xen_ssh.ml | 13 +- v2v/input_libvirt_xen_ssh.mli | 2 +- v2v/input_libvirtxml.ml | 3 +- v2v/libvirt_utils-c.c | 539 -------- v2v/libvirt_utils.ml | 95 +- v2v/libvirt_utils.mli | 51 +- v2v/output_libvirt.ml | 56 +- v2v/parse_libvirt_xml.ml | 14 +- v2v/parse_libvirt_xml.mli | 11 +- v2v/test-harness/...

...v2v/input_libvirt_vcenter_https.ml | 13 +- v2v/input_libvirt_vcenter_https.mli | 2 +- v2v/input_libvirt_vddk.ml | 15 +- v2v/input_libvirt_vddk.mli | 4 +- v2v/input_libvirt_xen_ssh.ml | 13 +- v2v/input_libvirt_xen_ssh.mli | 2 +- v2v/libvirt_utils-c.c | 539 -------- v2v/libvirt_utils.ml | 95 +- v2v/libvirt_utils.mli | 51 +- v2v/output_libvirt.ml | 56 +- v2v/parse_libvirt_xml.ml | 23 +- v2v/parse_libvirt_xml.mli | 11 +- v2v/test-harness/...

...v2v/input_libvirt_vcenter_https.mli | 2 +- v2v/input_libvirt_vddk.ml | 15 +- v2v/input_libvirt_vddk.mli | 4 +- v2v/input_libvirt_xen_ssh.ml | 13 +- v2v/input_libvirt_xen_ssh.mli | 2 +- v2v/input_libvirtxml.ml | 3 +- v2v/libvirt_utils-c.c | 539 -------- v2v/libvirt_utils.ml | 95 +- v2v/libvirt_utils.mli | 51 +- v2v/output_libvirt.ml | 56 +- v2v/parse_libvirt_xml.ml | 14 +- v2v/parse_libvirt_xml.mli | 11 +- v2v/test-harness/...