Displaying 2 results from an estimated 2 matches for "libnbd_read_xxx".
2019 Jun 25
2
Re: [libnbd PATCH v2 2/5] states: Wire in a read callback
On Thu, Jun 20, 2019 at 08:45:05PM -0500, Eric Blake wrote:
> If any callback fails, and if no prior error was set, then the
> callback's failure becomes the failure reason for the overall
> read. (Note that this is different from the block status callback,
> which for now quits using the callback on subsequent chunks if an
> earlier chunk failed - we may decide to change one or
2019 Jun 25
0
Re: [libnbd PATCH v2 2/5] states: Wire in a read callback
...t;
> I don't think non-C callbacks will be able to reliably set errno, but
> that's something we can solve in future. Therefore ACK.
Perhaps we could change the API to:
cmd->cb.fn.read (cmd->cb.opaque, cmd->data, cmd->count, cmd->offset,
&error, LIBNBD_READ_XXX)
where the caller is not only passed the current error, but also can
store into that variable to affect the return error (rather than the
return error being implied from whatever is left in errno).
Of course, that necessitates passing a pointer to an integer to the
callback, rather than a bare in...